From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F0BEC43219 for ; Tue, 22 Nov 2022 11:11:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232359AbiKVLLs convert rfc822-to-8bit (ORCPT ); Tue, 22 Nov 2022 06:11:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232934AbiKVLLr (ORCPT ); Tue, 22 Nov 2022 06:11:47 -0500 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DC6272FC2F; Tue, 22 Nov 2022 03:11:45 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 396CB8061; Tue, 22 Nov 2022 11:01:31 +0000 (UTC) Date: Tue, 22 Nov 2022 13:11:43 +0200 From: Tony Lindgren To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Thierry Reding , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Message-ID: References: <20221121115525.36362-1-tony@atomide.com> <20221121144000.7weeyfbbulltfxmd@pengutronix.de> <20221122093650.oouke2utlkvdd7r6@pengutronix.de> <20221122105710.5aow5qsri6pikgri@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20221122105710.5aow5qsri6pikgri@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Uwe Kleine-König [221122 10:47]: > On Tue, Nov 22, 2022 at 12:37:26PM +0200, Tony Lindgren wrote: > > * Uwe Kleine-König [221122 09:26]: > > > On Tue, Nov 22, 2022 at 06:43:55AM +0200, Tony Lindgren wrote: > > > > * Krzysztof Kozlowski [221121 16:05]: > > > > > On 21/11/2022 15:48, Tony Lindgren wrote: > > > > > > * Uwe Kleine-König [221121 14:30]: > > > > > >> On Mon, Nov 21, 2022 at 01:55:24PM +0200, Tony Lindgren wrote: > > > > > >>> Let's allow node numbering in decimal format too. > > > > > >>> > > > > > >>> Simple human-readable increments/IDs are usually decimal, hex is only for > > > > > >>> addresses as noted by Krzysztof Kozlowski . > > > > > >>> > > > > > >>> Cc: Thierry Reding > > > > > >>> Cc: Uwe Kleine-König > > > > > >>> Suggested-by: Krzysztof Kozlowski > > > > > >>> Signed-off-by: Tony Lindgren > > > > > >>> --- > > > > > >>> Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +- > > > > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > >>> > > > > > >>> diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml > > > > > >>> --- a/Documentation/devicetree/bindings/pwm/pwm.yaml > > > > > >>> +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml > > > > > >>> @@ -13,7 +13,7 @@ select: false > > > > > >>> > > > > > >>> properties: > > > > > >>> $nodename: > > > > > >>> - pattern: "^pwm(@.*|-[0-9a-f])*$" > > > > > >>> + pattern: "^pwm(@.*|-([0-9a-f]|1[0-5]))*$" > > > > > >> > > > > > >> I wonder why you don't make this: > > > > > >> > > > > > >> + pattern: "^pwm(@.*|-[0-9a-f]*)$" > > > > > > > > > > Yes, the '*' should be within (). > > > > > > > > Sorry I guess I don't follow. So for what type of naming is the second '*' > > > > actually needed here, or is it needed at all? > > > > > > > > We only want to match the following: > > > > > > > > pwm@1234 > > > > > > > > pwm-0 > > > > ... > > > > pwm-f > > > > > > > > And now also: > > > > > > > > pwm-0 > > > > ... > > > > pwm-15 > > > > > > > > Is there yet another format I'm missing? > > > > > > I think there is a misunderstanding about the type of pattern here. Do > > > we talk about a shell pattern where "[0-9a-f]*" matches a name starting > > > with a hex digit followed by any number of any caracter, or is it a > > > regexp where the * means "any number of the preceding pattern", so > > > effectively a word consisting of only hex digits. > > > > > > The .* part makes me think we're talking about a regexp, so the old > > > pattern ("^pwm(@.*|-[0-9a-f])*$") means that > > > > > > pwm-1-2-3-4 > > > > > > is allowed but > > > > > > pwm-10 > > > > > > isn't. And I think what we want is: > > > > > > "^pwm(@.*|-[0-9a-f]*)$" > > > > Heh so this fails for just node name pwm: > > > > pwm: $nodename:0: 'pwm' does not match '^pwm(@.*|-[0-9a-f]*)$' > > > > Maybe that's why the second '..)*$' was there originally for? > > And adding it back there fixes pwm but allows pwm-1-2-3.. > > > > > (or maybe better "^pwm(@.+|-[0-9a-f]+)$" ?) > > > > And this too fails for just pwm node name. > > Then let's pick: > > > "^pwm(@.+|-[0-9a-f]+)?$" That works for pwm and pwm-11, but now fails for pwm11 :) Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58F36C4332F for ; Tue, 22 Nov 2022 11:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rgebhGcWP2eVVQlXmswYHC+JJF+BHbkCDXVB1JXBksI=; b=yyK8RcCV0gBuDk efb3V2MB+W0iwIybkcfny9n0Cj/sTPOaRM2gZdkcA812pUJ2kaBAKgG2bbDU2wv0qzdHNFaGPQiTR 69WNI/aCAkH9D/3ZzZycjS1RtSbdDvmeYnu1PhLeV6787NriQDtwW3DyEHdu2potuaVYnpXy+slsX kS+zfB/j0RNyZ4eAwr4uQN9346tUevh87VG/DkCm9UMI+hRv/LW6aSWI8Ez1xaWsqyqjBDgavH0Pz R8Y4Kf7xnbHzQBa6qiE8Id4kUCO7BRu1YdTzKswdzOHEL06foQNkBCPCWJhXJ1VVnrb7CZbvY+HiR 7jcoD2EVk9LBvNuBkD/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxRBt-008GnK-4L; Tue, 22 Nov 2022 11:11:49 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxRBq-008Gm4-6X for linux-arm-kernel@lists.infradead.org; Tue, 22 Nov 2022 11:11:47 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 396CB8061; Tue, 22 Nov 2022 11:01:31 +0000 (UTC) Date: Tue, 22 Nov 2022 13:11:43 +0200 From: Tony Lindgren To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Thierry Reding , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Message-ID: References: <20221121115525.36362-1-tony@atomide.com> <20221121144000.7weeyfbbulltfxmd@pengutronix.de> <20221122093650.oouke2utlkvdd7r6@pengutronix.de> <20221122105710.5aow5qsri6pikgri@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221122105710.5aow5qsri6pikgri@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221122_031146_296736_84354A96 X-CRM114-Status: GOOD ( 33.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org KiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiBbMjIx MTIyIDEwOjQ3XToKPiBPbiBUdWUsIE5vdiAyMiwgMjAyMiBhdCAxMjozNzoyNlBNICswMjAwLCBU b255IExpbmRncmVuIHdyb3RlOgo+ID4gKiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29l bmlnQHBlbmd1dHJvbml4LmRlPiBbMjIxMTIyIDA5OjI2XToKPiA+ID4gT24gVHVlLCBOb3YgMjIs IDIwMjIgYXQgMDY6NDM6NTVBTSArMDIwMCwgVG9ueSBMaW5kZ3JlbiB3cm90ZToKPiA+ID4gPiAq IEtyenlzenRvZiBLb3psb3dza2kgPGtyenlzenRvZi5rb3psb3dza2lAbGluYXJvLm9yZz4gWzIy MTEyMSAxNjowNV06Cj4gPiA+ID4gPiBPbiAyMS8xMS8yMDIyIDE1OjQ4LCBUb255IExpbmRncmVu IHdyb3RlOgo+ID4gPiA+ID4gPiAqIFV3ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdA cGVuZ3V0cm9uaXguZGU+IFsyMjExMjEgMTQ6MzBdOgo+ID4gPiA+ID4gPj4gT24gTW9uLCBOb3Yg MjEsIDIwMjIgYXQgMDE6NTU6MjRQTSArMDIwMCwgVG9ueSBMaW5kZ3JlbiB3cm90ZToKPiA+ID4g PiA+ID4+PiBMZXQncyBhbGxvdyBub2RlIG51bWJlcmluZyBpbiBkZWNpbWFsIGZvcm1hdCB0b28u Cj4gPiA+ID4gPiA+Pj4KPiA+ID4gPiA+ID4+PiBTaW1wbGUgaHVtYW4tcmVhZGFibGUgaW5jcmVt ZW50cy9JRHMgYXJlIHVzdWFsbHkgZGVjaW1hbCwgaGV4IGlzIG9ubHkgZm9yCj4gPiA+ID4gPiA+ Pj4gYWRkcmVzc2VzIGFzIG5vdGVkIGJ5IEtyenlzenRvZiBLb3psb3dza2kgPGtyenlzenRvZi5r b3psb3dza2lAbGluYXJvLm9yZz4uCj4gPiA+ID4gPiA+Pj4KPiA+ID4gPiA+ID4+PiBDYzogVGhp ZXJyeSBSZWRpbmcgPHRoaWVycnkucmVkaW5nQGdtYWlsLmNvbT4KPiA+ID4gPiA+ID4+PiBDYzog VXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0BwZW5ndXRyb25peC5kZT4KPiA+ID4g PiA+ID4+PiBTdWdnZXN0ZWQtYnk6IEtyenlzenRvZiBLb3psb3dza2kgPGtyenlzenRvZi5rb3ps b3dza2lAbGluYXJvLm9yZz4KPiA+ID4gPiA+ID4+PiBTaWduZWQtb2ZmLWJ5OiBUb255IExpbmRn cmVuIDx0b255QGF0b21pZGUuY29tPgo+ID4gPiA+ID4gPj4+IC0tLQo+ID4gPiA+ID4gPj4+ICBE b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcHdtL3B3bS55YW1sIHwgMiArLQo+ID4g PiA+ID4gPj4+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkK PiA+ID4gPiA+ID4+Pgo+ID4gPiA+ID4gPj4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvcHdtL3B3bS55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL3B3bS9wd20ueWFtbAo+ID4gPiA+ID4gPj4+IC0tLSBhL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9wd20vcHdtLnlhbWwKPiA+ID4gPiA+ID4+PiArKysgYi9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcHdtL3B3bS55YW1sCj4gPiA+ID4gPiA+Pj4g QEAgLTEzLDcgKzEzLDcgQEAgc2VsZWN0OiBmYWxzZQo+ID4gPiA+ID4gPj4+ICAKPiA+ID4gPiA+ ID4+PiAgcHJvcGVydGllczoKPiA+ID4gPiA+ID4+PiAgICAkbm9kZW5hbWU6Cj4gPiA+ID4gPiA+ Pj4gLSAgICBwYXR0ZXJuOiAiXnB3bShALip8LVswLTlhLWZdKSokIgo+ID4gPiA+ID4gPj4+ICsg ICAgcGF0dGVybjogIl5wd20oQC4qfC0oWzAtOWEtZl18MVswLTVdKSkqJCIKPiA+ID4gPiA+ID4+ Cj4gPiA+ID4gPiA+PiBJIHdvbmRlciB3aHkgeW91IGRvbid0IG1ha2UgdGhpczoKPiA+ID4gPiA+ ID4+Cj4gPiA+ID4gPiA+PiArICAgIHBhdHRlcm46ICJecHdtKEAuKnwtWzAtOWEtZl0qKSQiCj4g PiA+ID4gPiAKPiA+ID4gPiA+IFllcywgdGhlICcqJyBzaG91bGQgYmUgd2l0aGluICgpLgo+ID4g PiA+IAo+ID4gPiA+IFNvcnJ5IEkgZ3Vlc3MgSSBkb24ndCBmb2xsb3cuIFNvIGZvciB3aGF0IHR5 cGUgb2YgbmFtaW5nIGlzIHRoZSBzZWNvbmQgJyonCj4gPiA+ID4gYWN0dWFsbHkgbmVlZGVkIGhl cmUsIG9yIGlzIGl0IG5lZWRlZCBhdCBhbGw/Cj4gPiA+ID4gCj4gPiA+ID4gV2Ugb25seSB3YW50 IHRvIG1hdGNoIHRoZSBmb2xsb3dpbmc6Cj4gPiA+ID4gCj4gPiA+ID4gcHdtQDEyMzQKPiA+ID4g PiAKPiA+ID4gPiBwd20tMAo+ID4gPiA+IC4uLgo+ID4gPiA+IHB3bS1mCj4gPiA+ID4gCj4gPiA+ ID4gQW5kIG5vdyBhbHNvOgo+ID4gPiA+IAo+ID4gPiA+IHB3bS0wCj4gPiA+ID4gLi4uCj4gPiA+ ID4gcHdtLTE1Cj4gPiA+ID4gCj4gPiA+ID4gSXMgdGhlcmUgeWV0IGFub3RoZXIgZm9ybWF0IEkn bSBtaXNzaW5nPwo+ID4gPiAKPiA+ID4gSSB0aGluayB0aGVyZSBpcyBhIG1pc3VuZGVyc3RhbmRp bmcgYWJvdXQgdGhlIHR5cGUgb2YgcGF0dGVybiBoZXJlLiBEbwo+ID4gPiB3ZSB0YWxrIGFib3V0 IGEgc2hlbGwgcGF0dGVybiB3aGVyZSAiWzAtOWEtZl0qIiBtYXRjaGVzIGEgbmFtZSBzdGFydGlu Zwo+ID4gPiB3aXRoIGEgaGV4IGRpZ2l0IGZvbGxvd2VkIGJ5IGFueSBudW1iZXIgb2YgYW55IGNh cmFjdGVyLCBvciBpcyBpdCBhCj4gPiA+IHJlZ2V4cCB3aGVyZSB0aGUgKiBtZWFucyAiYW55IG51 bWJlciBvZiB0aGUgcHJlY2VkaW5nIHBhdHRlcm4iLCBzbwo+ID4gPiBlZmZlY3RpdmVseSBhIHdv cmQgY29uc2lzdGluZyBvZiBvbmx5IGhleCBkaWdpdHMuCj4gPiA+IAo+ID4gPiBUaGUgLiogcGFy dCBtYWtlcyBtZSB0aGluayB3ZSdyZSB0YWxraW5nIGFib3V0IGEgcmVnZXhwLCBzbyB0aGUgb2xk Cj4gPiA+IHBhdHRlcm4gKCJecHdtKEAuKnwtWzAtOWEtZl0pKiQiKSBtZWFucyB0aGF0Cj4gPiA+ IAo+ID4gPiAJcHdtLTEtMi0zLTQKPiA+ID4gCj4gPiA+IGlzIGFsbG93ZWQgYnV0Cj4gPiA+IAo+ ID4gPiAJcHdtLTEwCj4gPiA+IAo+ID4gPiBpc24ndC4gQW5kIEkgdGhpbmsgd2hhdCB3ZSB3YW50 IGlzOgo+ID4gPiAKPiA+ID4gCSJecHdtKEAuKnwtWzAtOWEtZl0qKSQiCj4gPiAKPiA+IEhlaCBz byB0aGlzIGZhaWxzIGZvciBqdXN0IG5vZGUgbmFtZSBwd206Cj4gPiAKPiA+IHB3bTogJG5vZGVu YW1lOjA6ICdwd20nIGRvZXMgbm90IG1hdGNoICdecHdtKEAuKnwtWzAtOWEtZl0qKSQnCj4gPiAK PiA+IE1heWJlIHRoYXQncyB3aHkgdGhlIHNlY29uZCAnLi4pKiQnIHdhcyB0aGVyZSBvcmlnaW5h bGx5IGZvcj8KPiA+IEFuZCBhZGRpbmcgaXQgYmFjayB0aGVyZSBmaXhlcyBwd20gYnV0IGFsbG93 cyBwd20tMS0yLTMuLgo+ID4gCj4gPiA+IChvciBtYXliZSBiZXR0ZXIgIl5wd20oQC4rfC1bMC05 YS1mXSspJCIgPykKPiA+IAo+ID4gQW5kIHRoaXMgdG9vIGZhaWxzIGZvciBqdXN0IHB3bSBub2Rl IG5hbWUuCj4gCj4gVGhlbiBsZXQncyBwaWNrOgo+IAo+IAo+IAkiXnB3bShALit8LVswLTlhLWZd Kyk/JCIKClRoYXQgd29ya3MgZm9yIHB3bSBhbmQgcHdtLTExLCBidXQgbm93IGZhaWxzIGZvciBw d20xMSA6KQoKVG9ueQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=