From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02ABAC433FE for ; Tue, 22 Nov 2022 16:23:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234181AbiKVQXK (ORCPT ); Tue, 22 Nov 2022 11:23:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234227AbiKVQXH (ORCPT ); Tue, 22 Nov 2022 11:23:07 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B608D1C909 for ; Tue, 22 Nov 2022 08:23:06 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id q96-20020a17090a1b6900b00218b8f9035cso5594569pjq.5 for ; Tue, 22 Nov 2022 08:23:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mndX8ySXqV/A7RweyaH+VqXePxP+UtgQs3fmb5mOoe4=; b=GpxBz3aJp8mXpuLCXQZRuQwVMtnYbPN06pv9TC0LpcGwt+HU21kH6PSQN0ikXhlksA KvWGGM3JzytzjwVd6dLDQWLds8yVCxLm8a4BLAHYNwmd0RWSASu2ks6ssvA2GYBpQgjw VelsnDgZaaLmhqxR4fHR7Q0AfyFGvmm9J0cUo8k+0W/KRyxVZXuokFqocve/L7hrsUZ3 5CNWTgursamlmMc1397GMzv0ywMx86ESKyLChOenPs5x+TLV/n5tOAHCxHM3DG849daa 21M3JBTeXZViKa/EcaJDlM2Bmzakyp9NAwK153xr6dufnXOro5EKJFVImF9gdX3tbYl0 zolw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mndX8ySXqV/A7RweyaH+VqXePxP+UtgQs3fmb5mOoe4=; b=ahQiBzhTrdMBNsSw8Rtuo9zUcwUpgW3p5sV9Hobu+RwGu/UQFypfmhW4RfFLq/Vj6Z hKMj9EJE2BRqSMYZF91sFcHAAtlLLhnfHsQ0tJy2qDMgsjZKA/klnyZk1NdhyB5o6pMP 9hrbGG+X1WEJFVLvsakV7OsHMHL6bz+QTmIfcLXIu/+H0bJ1yZ0QAgqCEGm4uDQ+mNuX ZJ9Bp8DI+TDaCabnqQW61HwNkohDJNQUTyYBTxW4u3J1nUIwfTwTdRK7Tu8Kq4+jaPBu yA4XFTWc20Yn102TxbgEoy4z3dYtoNtxFO1RINdIVEQUfwiQv+k28VQfiBBgzko1e2Pk epfQ== X-Gm-Message-State: ANoB5pmWITex9VK6HNAQHykVCpDlHsAYGHjbYGPNZk05DUoyld1tAjc3 zYv29HaeeEWkwBPL572MH2otpA== X-Google-Smtp-Source: AA0mqf52USYIn91Dn1QSnOe5tT5ZXipauDDluMg26sfFbQQxjQ3G3Vq87yA5PMyNeYrqRuJz6jW7+g== X-Received: by 2002:a17:903:4284:b0:189:f57:8f60 with SMTP id ju4-20020a170903428400b001890f578f60mr5130542plb.65.1669134185014; Tue, 22 Nov 2022 08:23:05 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id c30-20020a056a00009e00b0056b3c863950sm10906019pfj.8.2022.11.22.08.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 08:23:04 -0800 (PST) Date: Tue, 22 Nov 2022 16:23:01 +0000 From: Sean Christopherson To: "Durrant, Paul" Cc: David Woodhouse , Paolo Bonzini , "kvm@vger.kernel.org" , "mhal@rbox.co" Subject: Re: [PATCH 3/4] KVM: Update gfn_to_pfn_cache khva when it moves within the same page Message-ID: References: <20221119094659.11868-1-dwmw2@infradead.org> <20221119094659.11868-3-dwmw2@infradead.org> <681cf1b4edf04563bba651efb854e77f@amazon.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <681cf1b4edf04563bba651efb854e77f@amazon.co.uk> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Sat, Nov 19, 2022, Durrant, Paul wrote: > > -----Original Message----- > > From: David Woodhouse > > Sent: 19 November 2022 09:47 > > To: Paolo Bonzini ; Sean Christopherson > > > > Cc: kvm@vger.kernel.org; mhal@rbox.co > > Subject: [EXTERNAL] [PATCH 3/4] KVM: Update gfn_to_pfn_cache khva when it > > moves within the same page Please use a mail client that doesn't include the header gunk in the reply. > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the content is safe. > > > > > > > > From: David Woodhouse > > > > In the case where a GPC is refreshed to a different location within the > > same page, we didn't bother to update it. Mostly we don't need to, but > > since the ->khva field also includes the offset within the page, that does > > have to be updated. > > > > Signed-off-by: David Woodhouse > > Reviewed-by: Tags need your real name, not just your email address, i.e. this should be: Reviewed-by: Paul Durrant