All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	djrscally@gmail.com, heikki.krogerus@linux.intel.com,
	sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org,
	rafael@kernel.org
Subject: Re: [PATCH v2] device property: fix of node refcount leak in fwnode_graph_get_next_endpoint()
Date: Tue, 22 Nov 2022 14:58:07 +0200	[thread overview]
Message-ID: <Y3zHX9FQm8rhLRpt@smile.fi.intel.com> (raw)
In-Reply-To: <Y3zHF8rdguSaavo1@smile.fi.intel.com>

On Tue, Nov 22, 2022 at 02:56:55PM +0200, Andy Shevchenko wrote:
> On Tue, Nov 22, 2022 at 02:54:36PM +0200, Andy Shevchenko wrote:

...

> out:

Actually better name is

out_put_parent:

> > > +	fwnode_handle_put(port_parent);
> > > +	return ep;

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2022-11-22 12:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22 12:00 [PATCH v2] device property: fix of node refcount leak in fwnode_graph_get_next_endpoint() Yang Yingliang
2022-11-22 12:54 ` Andy Shevchenko
2022-11-22 12:56   ` Andy Shevchenko
2022-11-22 12:58     ` Andy Shevchenko [this message]
2022-11-22 13:14       ` Yang Yingliang
2022-11-22 13:12   ` Yang Yingliang
2022-11-22 13:16     ` Andy Shevchenko
2022-11-22 13:41       ` Yang Yingliang
2022-11-22 14:07         ` Andy Shevchenko
2022-11-22 14:22           ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3zHX9FQm8rhLRpt@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=djrscally@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.