From: Jason Gunthorpe <jgg@nvidia.com>
To: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Cc: linux-rdma@vger.kernel.org, zyjzyj2000@gmail.com, leon@kernel.org
Subject: Re: [PATCH] RDMA/rxe: Fix null-ptr-deref in rxe_qp_do_cleanup when socket create failed
Date: Tue, 22 Nov 2022 09:19:16 -0400 [thread overview]
Message-ID: <Y3zMVDXMUwtlHAWy@nvidia.com> (raw)
In-Reply-To: <20221117123347.2576350-1-zhangxiaoxu5@huawei.com>
On Thu, Nov 17, 2022 at 08:33:47PM +0800, Zhang Xiaoxu wrote:
> There is a null-ptr-deref when mount.cifs over rdma:
>
> BUG: KASAN: null-ptr-deref in rxe_qp_do_cleanup+0x2f3/0x360 [rdma_rxe]
> Read of size 8 at addr 0000000000000018 by task mount.cifs/3046
>
> CPU: 2 PID: 3046 Comm: mount.cifs Not tainted 6.1.0-rc5+ #62
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-1.fc3
> Call Trace:
> <TASK>
> dump_stack_lvl+0x34/0x44
> kasan_report+0xad/0x130
> rxe_qp_do_cleanup+0x2f3/0x360 [rdma_rxe]
> execute_in_process_context+0x25/0x90
> __rxe_cleanup+0x101/0x1d0 [rdma_rxe]
> rxe_create_qp+0x16a/0x180 [rdma_rxe]
> create_qp.part.0+0x27d/0x340
> ib_create_qp_kernel+0x73/0x160
> rdma_create_qp+0x100/0x230
> _smbd_get_connection+0x752/0x20f0
> smbd_get_connection+0x21/0x40
> cifs_get_tcp_session+0x8ef/0xda0
> mount_get_conns+0x60/0x750
> cifs_mount+0x103/0xd00
> cifs_smb3_do_mount+0x1dd/0xcb0
> smb3_get_tree+0x1d5/0x300
> vfs_get_tree+0x41/0xf0
> path_mount+0x9b3/0xdd0
> __x64_sys_mount+0x190/0x1d0
> do_syscall_64+0x35/0x80
> entry_SYSCALL_64_after_hwframe+0x46/0xb0
>
> The root cause of the issue is the socket create failed in
> rxe_qp_init_req().
>
> So add a null ptr check about the sk before reset the dst socket.
>
> Fixes: 8700e3e7c485 ("Soft RoCE driver")
> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
> ---
> drivers/infiniband/sw/rxe/rxe_qp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c
> index a62bab88415c..4bab641fdd42 100644
> --- a/drivers/infiniband/sw/rxe/rxe_qp.c
> +++ b/drivers/infiniband/sw/rxe/rxe_qp.c
> @@ -829,7 +829,7 @@ static void rxe_qp_do_cleanup(struct work_struct *work)
> if (qp->resp.mr)
> rxe_put(qp->resp.mr);
>
> - if (qp_type(qp) == IB_QPT_RC)
> + if (qp_type(qp) == IB_QPT_RC && qp->sk)
> sk_dst_reset(qp->sk->sk);
>
> free_rd_atomic_resources(qp);
Please just move this down into the existing if
Jason
prev parent reply other threads:[~2022-11-22 13:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 12:33 [PATCH] RDMA/rxe: Fix null-ptr-deref in rxe_qp_do_cleanup when socket create failed Zhang Xiaoxu
2022-11-17 13:56 ` lizhijian
2022-11-18 7:03 ` Zhu Yanjun
2022-11-18 7:27 ` zhangxiaoxu (A)
2022-11-18 7:30 ` Zhu Yanjun
2022-11-22 13:19 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3zMVDXMUwtlHAWy@nvidia.com \
--to=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=zhangxiaoxu5@huawei.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.