From: Matthias Kaehlcke <mka@chromium.org>
To: Owen Yang <ecs.taipeikernel@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Douglas Anderson <dianders@chromium.org>,
Bob Moragues <moragues@chromium.org>, Harvey <hunge@google.com>,
Stephen Boyd <swboyd@chromium.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sc7280: Add DT for sc7280-herobrine-zombie
Date: Tue, 22 Nov 2022 13:30:17 +0000 [thread overview]
Message-ID: <Y3zO6aY0xANk4Qlb@google.com> (raw)
In-Reply-To: <20221122203635.v2.2.I4d4d860a675d86d328135e5e5f88aefb69a852ab@changeid>
On Tue, Nov 22, 2022 at 08:37:03PM +0800, Owen Yang wrote:
> Add DT for sc7280-herobrine-zombie
>
> arch/arm64/boot/dts/qcom/Makefile
> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dts
> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dts
> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi
Drop this
> Signed-off-by: Owen Yang <ecs.taipeikernel@gmail.com>
> ---
>
> (no changes since v1)
A diff between v1 and v2 shows that this is not correct, please provide
accurate change logs
> arch/arm64/boot/dts/qcom/Makefile | 2 +
> .../dts/qcom/sc7280-herobrine-zombie-lte.dts | 15 +
> .../boot/dts/qcom/sc7280-herobrine-zombie.dts | 16 +
> .../dts/qcom/sc7280-herobrine-zombie.dtsi | 310 ++++++++++++++++++
> 4 files changed, 343 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 384f2fa50646..e3226d7894ad 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -101,6 +101,8 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-herobrine-r1.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r0.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r1.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r1-lte.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-zombie.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-zombie-lte.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp2.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7280-crd-r3.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dts
> new file mode 100644
> index 000000000000..2f1da87e5005
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dts
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Google Zombie board device tree source
> + *
> + * Copyright 2022 Google LLC.
> + */
> +/dts-v1/;
> +
> +#include "sc7280-herobrine-zombie.dtsi"
> +#include "sc7280-herobrine-lte-sku.dtsi"
> +
> +/ {
> + model = "Google Zombie with LTE";
> + compatible = "google,zombie-sku512", "qcom,sc7280";
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dts
> new file mode 100644
> index 000000000000..0246c12b2f40
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dts
> @@ -0,0 +1,16 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Google Zombie board device tree source
> + *
> + * Copyright 2022 Google LLC.
> + */
> +
> +/dts-v1/;
> +
> +#include "sc7280-herobrine-zombie.dtsi"
> +#include "sc7280-herobrine-wifi-sku.dtsi"
> +
> +/ {
> + model = "Google Zombie";
> + compatible = "google,zombie", "qcom,sc7280";
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi
> new file mode 100644
> index 000000000000..15832620ff5d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi
> @@ -0,0 +1,310 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Google Zombie board device tree source
> + *
> + * Copyright 2022 Google LLC.
> + */
> +/dts-v1/;
This was added in v2. It isn't needed, the .dts files which include this file
already make this declaration.
next prev parent reply other threads:[~2022-11-22 13:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 12:37 [PATCH v2 1/2] dt-bindings: arm: qcom: Adding DT binding for zombie Owen Yang
2022-11-22 12:37 ` [PATCH v2 2/2] arm64: dts: qcom: sc7280: Add DT for sc7280-herobrine-zombie Owen Yang
2022-11-22 13:30 ` Matthias Kaehlcke [this message]
2022-11-22 14:14 ` [PATCH v2 1/2] dt-bindings: arm: qcom: Adding DT binding for zombie Matthias Kaehlcke
2022-11-22 14:28 ` Matthias Kaehlcke
[not found] ` <CAPao8GKpXcRm3PmWnv+rsr2z53r6J-ScXAq+fOi4ydQg_Gy31A@mail.gmail.com>
2022-11-23 15:07 ` Matthias Kaehlcke
2022-11-28 16:20 ` Doug Anderson
2022-11-28 17:07 ` Matthias Kaehlcke
2022-11-28 18:51 ` Doug Anderson
-- strict thread matches above, loose matches on Subject: below --
2022-11-25 9:28 [PATCH v2 1/2] dt-bindings: arm: qcom: Add zombie Owen Yang
2022-11-25 9:28 ` [PATCH v2 2/2] arm64: dts: qcom: sc7280: Add DT for sc7280-herobrine-zombie Owen Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3zO6aY0xANk4Qlb@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=ecs.taipeikernel@gmail.com \
--cc=hunge@google.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moragues@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.