From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-pwm@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v5 3/7] pwm: lpss: Include headers we are the direct user of
Date: Tue, 22 Nov 2022 16:34:21 +0200 [thread overview]
Message-ID: <Y3zd7be5LJZWkSjl@smile.fi.intel.com> (raw)
In-Reply-To: <20221122133933.iwo76w4h6wuvp3v4@pengutronix.de>
On Tue, Nov 22, 2022 at 02:39:33PM +0100, Uwe Kleine-König wrote:
> On Thu, Nov 17, 2022 at 01:08:02PM +0200, Andy Shevchenko wrote:
> > For the sake of integrity, include headers we are the direct
> > user of.
> >
> > Replace the inclusion of device.h by a forward declaration
> > of struct device plus a (cheaper) of types.h as device.h is
> > an expensive include (measured in compiler effort).
...
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thank you!
Patch 6 is still in question.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-22 14:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 11:07 [PATCH v5 0/7] pinctrl: intel: Enable PWM optional feature Andy Shevchenko
2022-11-17 11:08 ` [PATCH v5 1/7] pwm: Add a stub for devm_pwmchip_add() Andy Shevchenko
2022-11-17 11:08 ` [PATCH v5 2/7] pwm: lpss: Rename MAX_PWMS --> LPSS_MAX_PWMS Andy Shevchenko
2022-11-17 11:08 ` [PATCH v5 3/7] pwm: lpss: Include headers we are the direct user of Andy Shevchenko
2022-11-22 13:39 ` Uwe Kleine-König
2022-11-22 14:34 ` Andy Shevchenko [this message]
2022-11-17 11:08 ` [PATCH v5 4/7] pwm: lpss: Allow other drivers to enable PWM LPSS Andy Shevchenko
2022-11-17 11:08 ` [PATCH v5 5/7] pwm: lpss: Rename pwm_lpss_probe() --> devm_pwm_lpss_probe() Andy Shevchenko
2022-11-17 11:08 ` [PATCH v5 6/7] pwm: lpss: Add devm_pwm_lpss_probe() stub Andy Shevchenko
2022-11-22 16:47 ` Uwe Kleine-König
2022-11-22 17:35 ` Andy Shevchenko
2022-11-22 18:14 ` Uwe Kleine-König
2022-11-22 18:32 ` Andy Shevchenko
2022-11-22 20:21 ` Uwe Kleine-König
2022-11-17 11:08 ` [PATCH v5 7/7] pinctrl: intel: Enumerate PWM device when community has a capability Andy Shevchenko
2022-11-22 13:00 ` [PATCH v5 0/7] pinctrl: intel: Enable PWM optional feature Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3zd7be5LJZWkSjl@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.