From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 790EFC4332F for ; Tue, 22 Nov 2022 15:23:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 98F4F10E409; Tue, 22 Nov 2022 15:23:54 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id F157910E409; Tue, 22 Nov 2022 15:23:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669130632; x=1700666632; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rMOdI3P7VdfIy2nfD0+wdUsYo7XnmOvFsyP8v8HsR3g=; b=NSCJ4iaADUD9kg16U3d9Tolz9n7sX2VzYInlfHn5wINYIJfoTaCxN2mK SrKGYFobjH49e6LNuObd7j2OO7e/5rGKBJvg+dCwoVfoeI5+y1Nh/nKpi k8uUfN1kOQxF/6jguVbuV/9IvM91Hmajd4ban33QWrbLyIqSc9I4uTDbB 6Z8oC6oJ6R2dbKYXrqnxkurUA/WkqlVEiD5RV76QcdjpT/ayROfGXXnFY cAMSveZrngQ7OSH2RJMI0o/mx8GXwECFcsvLr3CQr0KXCaWdbut/fOu/+ mSvjoPg/wz6puqFSywlv1jmMFMNqpLXH518J5CZTYUkmIs8YpBp1WK4Xh Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="400129238" X-IronPort-AV: E=Sophos;i="5.96,184,1665471600"; d="scan'208";a="400129238" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2022 07:23:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="705004007" X-IronPort-AV: E=Sophos;i="5.96,184,1665471600"; d="scan'208";a="705004007" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 22 Nov 2022 07:23:47 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oxV7h-00FsxN-2Q; Tue, 22 Nov 2022 17:23:45 +0200 Date: Tue, 22 Nov 2022 17:23:45 +0200 From: Andy Shevchenko To: Jani Nikula Message-ID: References: <20221114162207.62559-1-andriy.shevchenko@linux.intel.com> <87leoc2pbf.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87leoc2pbf.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Subject: Re: [Intel-gfx] [PATCH v2 1/4] i915: Move list_count() to list.h for broader use X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathias Nyman , Mathias Nyman , Kevin Cernekee , Greg Kroah-Hartman , intel-gfx@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jakob Koschel , Daniel Vetter , Rodrigo Vivi , Andrew Morton , David Airlie Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Nov 15, 2022 at 05:46:28PM +0200, Jani Nikula wrote: > On Mon, 14 Nov 2022, Andy Shevchenko wrote: > > Some of the existing users, and definitely will be new ones, want to > > count existing nodes in the list. Provide a generic API for that by > > moving code from i915 to list.h. > > I think I'd find list_length() a much more natural name for this. i915 suggests my variant :-) > *shrug* > > Acked-by: Jani Nikula > > regardless of what you decide to do with name or static inline etc. Thanks! I will check which one looks and feels better and update for v3. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BB83C4332F for ; Tue, 22 Nov 2022 15:24:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233700AbiKVPYO (ORCPT ); Tue, 22 Nov 2022 10:24:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232632AbiKVPYN (ORCPT ); Tue, 22 Nov 2022 10:24:13 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB93520F42; Tue, 22 Nov 2022 07:24:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669130652; x=1700666652; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rMOdI3P7VdfIy2nfD0+wdUsYo7XnmOvFsyP8v8HsR3g=; b=IODGBlFEXnxIhF+/GPzCoB/MwSfEt5Bt+qRJrcxRMG6ydNVpAPhBXrv7 19QiuU++fFlefpkCoFFnfpsG03eA2NAL80SGY2IvR7mNoMHtRsj3nAcMy LbRBIRko6Mg+4rgKW0JMjubwls3zEPjwHC5dmE7IZShVa3WYMOgHFfZsu GYXkhendRYc+NxuaDf4arlon6U8sYOBfhJeLebnMLDn/R+6SufoLLN/Eh 7vQB4R9FjODYw5UaYD+Rwl/Dk5ugcH5AOUAljfLhVOnRy+Wd46uc0Pk6L QErhHOuAxd6ZUcuidBLJ5wZMQFvc/A/fhJ7m9Klfc1zXmYVaIw+0b6b6o w==; X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="301389399" X-IronPort-AV: E=Sophos;i="5.96,184,1665471600"; d="scan'208";a="301389399" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2022 07:23:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="705004007" X-IronPort-AV: E=Sophos;i="5.96,184,1665471600"; d="scan'208";a="705004007" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 22 Nov 2022 07:23:47 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oxV7h-00FsxN-2Q; Tue, 22 Nov 2022 17:23:45 +0200 Date: Tue, 22 Nov 2022 17:23:45 +0200 From: Andy Shevchenko To: Jani Nikula Cc: Jakob Koschel , Greg Kroah-Hartman , Mathias Nyman , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Kevin Cernekee , Mathias Nyman , Andrew Morton Subject: Re: [PATCH v2 1/4] i915: Move list_count() to list.h for broader use Message-ID: References: <20221114162207.62559-1-andriy.shevchenko@linux.intel.com> <87leoc2pbf.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87leoc2pbf.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Nov 15, 2022 at 05:46:28PM +0200, Jani Nikula wrote: > On Mon, 14 Nov 2022, Andy Shevchenko wrote: > > Some of the existing users, and definitely will be new ones, want to > > count existing nodes in the list. Provide a generic API for that by > > moving code from i915 to list.h. > > I think I'd find list_length() a much more natural name for this. i915 suggests my variant :-) > *shrug* > > Acked-by: Jani Nikula > > regardless of what you decide to do with name or static inline etc. Thanks! I will check which one looks and feels better and update for v3. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C16C5C4332F for ; Tue, 22 Nov 2022 15:23:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E88810E40A; Tue, 22 Nov 2022 15:23:58 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id F157910E409; Tue, 22 Nov 2022 15:23:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669130632; x=1700666632; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rMOdI3P7VdfIy2nfD0+wdUsYo7XnmOvFsyP8v8HsR3g=; b=NSCJ4iaADUD9kg16U3d9Tolz9n7sX2VzYInlfHn5wINYIJfoTaCxN2mK SrKGYFobjH49e6LNuObd7j2OO7e/5rGKBJvg+dCwoVfoeI5+y1Nh/nKpi k8uUfN1kOQxF/6jguVbuV/9IvM91Hmajd4ban33QWrbLyIqSc9I4uTDbB 6Z8oC6oJ6R2dbKYXrqnxkurUA/WkqlVEiD5RV76QcdjpT/ayROfGXXnFY cAMSveZrngQ7OSH2RJMI0o/mx8GXwECFcsvLr3CQr0KXCaWdbut/fOu/+ mSvjoPg/wz6puqFSywlv1jmMFMNqpLXH518J5CZTYUkmIs8YpBp1WK4Xh Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="400129238" X-IronPort-AV: E=Sophos;i="5.96,184,1665471600"; d="scan'208";a="400129238" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2022 07:23:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="705004007" X-IronPort-AV: E=Sophos;i="5.96,184,1665471600"; d="scan'208";a="705004007" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 22 Nov 2022 07:23:47 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oxV7h-00FsxN-2Q; Tue, 22 Nov 2022 17:23:45 +0200 Date: Tue, 22 Nov 2022 17:23:45 +0200 From: Andy Shevchenko To: Jani Nikula Subject: Re: [PATCH v2 1/4] i915: Move list_count() to list.h for broader use Message-ID: References: <20221114162207.62559-1-andriy.shevchenko@linux.intel.com> <87leoc2pbf.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87leoc2pbf.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin , Mathias Nyman , Mathias Nyman , Kevin Cernekee , Greg Kroah-Hartman , intel-gfx@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jakob Koschel , Rodrigo Vivi , Andrew Morton Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Nov 15, 2022 at 05:46:28PM +0200, Jani Nikula wrote: > On Mon, 14 Nov 2022, Andy Shevchenko wrote: > > Some of the existing users, and definitely will be new ones, want to > > count existing nodes in the list. Provide a generic API for that by > > moving code from i915 to list.h. > > I think I'd find list_length() a much more natural name for this. i915 suggests my variant :-) > *shrug* > > Acked-by: Jani Nikula > > regardless of what you decide to do with name or static inline etc. Thanks! I will check which one looks and feels better and update for v3. -- With Best Regards, Andy Shevchenko