From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org,
Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: Re: [PATCH kms++ v2 2/4] kms++: PixelFormats: Add Y21x formats
Date: Mon, 5 Dec 2022 10:18:06 +0200 [thread overview]
Message-ID: <Y42pPQ83uEI9gw+b@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20221205080339.12801-3-tomi.valkeinen+renesas@ideasonboard.com>
Hi Tomi,
Thank you for the patch.
On Mon, Dec 05, 2022 at 10:03:37AM +0200, Tomi Valkeinen wrote:
> Add Y210, Y212, Y216 pixel formats.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> kms++/inc/kms++/pixelformats.h | 4 ++++
> kms++/src/pixelformats.cpp | 16 ++++++++++++++++
> 2 files changed, 20 insertions(+)
>
> diff --git a/kms++/inc/kms++/pixelformats.h b/kms++/inc/kms++/pixelformats.h
> index 8ebb76b..e334ee6 100644
> --- a/kms++/inc/kms++/pixelformats.h
> +++ b/kms++/inc/kms++/pixelformats.h
> @@ -31,6 +31,10 @@ enum class PixelFormat : uint32_t {
> YVYU = MakeFourCC("YVYU"),
> VYUY = MakeFourCC("VYUY"),
>
> + Y210 = MakeFourCC("Y210"),
> + Y212 = MakeFourCC("Y212"),
> + Y216 = MakeFourCC("Y216"),
> +
> XRGB8888 = MakeFourCC("XR24"),
> XBGR8888 = MakeFourCC("XB24"),
> RGBX8888 = MakeFourCC("RX24"),
> diff --git a/kms++/src/pixelformats.cpp b/kms++/src/pixelformats.cpp
> index 1f10f3a..5f13ef4 100644
> --- a/kms++/src/pixelformats.cpp
> +++ b/kms++/src/pixelformats.cpp
> @@ -28,6 +28,22 @@ static const map<PixelFormat, PixelFormatInfo> format_info_array = {
> 1,
> { { 16, 2, 1 } },
> } },
> + { PixelFormat::Y210, {
> + PixelColorType::YUV,
> + 1,
> + { { 32, 2, 1 } },
> + } },
> + { PixelFormat::Y212, {
> + PixelColorType::YUV,
> + 1,
> + { { 32, 2, 1 } },
> + } },
> + { PixelFormat::Y216, {
> + PixelColorType::YUV,
> + 1,
> + { { 32, 2, 1 } },
> + } },
> +
> /* YUV semi-planar */
> { PixelFormat::NV12, {
> PixelColorType::YUV,
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-12-05 8:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 8:03 [PATCH kms++ v2 0/4] Support Y210, Y212, Y216 Tomi Valkeinen
2022-12-05 8:03 ` [PATCH kms++ v2 1/4] kms++: PixelFormats: Fix formatting Tomi Valkeinen
2022-12-05 8:03 ` [PATCH kms++ v2 2/4] kms++: PixelFormats: Add Y21x formats Tomi Valkeinen
2022-12-05 8:18 ` Laurent Pinchart [this message]
2022-12-05 8:03 ` [PATCH kms++ v2 3/4] kms++util: Add endian.h Tomi Valkeinen
2022-12-05 8:17 ` Laurent Pinchart
2022-12-05 8:03 ` [PATCH kms++ v2 4/4] kms++util: Add Y21x drawing support Tomi Valkeinen
2022-12-05 8:17 ` Laurent Pinchart
2022-12-05 8:24 ` Tomi Valkeinen
2022-12-05 8:34 ` Geert Uytterhoeven
2022-12-05 8:43 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y42pPQ83uEI9gw+b@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=tomi.valkeinen+renesas@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.