From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57ECBC4321E for ; Mon, 5 Dec 2022 09:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231243AbiLEJ6w (ORCPT ); Mon, 5 Dec 2022 04:58:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbiLEJ6u (ORCPT ); Mon, 5 Dec 2022 04:58:50 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9440DECF; Mon, 5 Dec 2022 01:58:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670234329; x=1701770329; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=upaZo6fjhhnh+UlqOySD7G2L3bnZ7lNoi+82BMImAOo=; b=dSJeMiAGkGorsrAERzEFqSLlzQUYuCuSOScynW0cx7VA+odqBmgUYdLJ FbQjN4VIEHhGUkJ+CYw4iY5I3U2sEXZASXWlwRFsI7thpbL1xE5JzVtUk ZJ3BWksm5KsKuywHrL8A6WlDOZiZkvdDXfk1bQntEWn54o5ZnItIpyREH RHvI7Jl3oknoGXU60SGDbqjSdBO5vLM0oT6JzVMrQZ6K7FwvlLQ4facQZ upo5yO+0sNxBRwEcq8a4dQT8pazGCa5WA5+ugHXg/zd4doacvByb0b9cU 3mP1xc5apgIrPtmm9QVhkpAuc9quFHt9Zzev9Upl1NSkbH56jF4bedQBZ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10551"; a="296009088" X-IronPort-AV: E=Sophos;i="5.96,219,1665471600"; d="scan'208";a="296009088" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2022 01:58:49 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10551"; a="820137760" X-IronPort-AV: E=Sophos;i="5.96,219,1665471600"; d="scan'208";a="820137760" Received: from punajuuri.fi.intel.com (HELO paasikivi.fi.intel.com) ([10.237.72.43]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2022 01:58:47 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 13E962033F; Mon, 5 Dec 2022 11:58:45 +0200 (EET) Date: Mon, 5 Dec 2022 09:58:45 +0000 From: Sakari Ailus To: Ricardo Ribalda Cc: Pavel Machek , Mauro Carvalho Chehab , Pali Rohar , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v2] media: i2c: ad5820: Fix error path Message-ID: References: <20220921-ad5820-v2-0-3e5cabb04786@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220921-ad5820-v2-0-3e5cabb04786@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Ricardo, On Fri, Dec 02, 2022 at 05:35:59PM +0100, Ricardo Ribalda wrote: > Error path seems to be swaped. Fix the order and provide some meaningful > names. > > Fixes: bee3d5115611 ("[media] ad5820: Add driver for auto-focus coil") > Signed-off-by: Ricardo Ribalda I'm afraid v1 has already been merged. But I understand patch content wasn't really different so that should be fine. -- Kind regards, Sakari Ailus