From: Greg KH <gregkh@linuxfoundation.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: stable@vger.kernel.org, vkoul@kernel.org,
Sjoerd Simons <sjoerd@collabora.com>,
Chao Song <chao.song@intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>
Subject: Re: [PATCH] soundwire: intel: Initialize clock stop timeout
Date: Mon, 5 Dec 2022 19:33:06 +0100 [thread overview]
Message-ID: <Y445YurEQGO0tQqJ@kroah.com> (raw)
In-Reply-To: <20221205170600.15002-1-pierre-louis.bossart@linux.intel.com>
On Mon, Dec 05, 2022 at 11:06:00AM -0600, Pierre-Louis Bossart wrote:
> From: Sjoerd Simons <sjoerd@collabora.com>
>
> commit 13c30a755847c7e804e1bf755e66e3ff7b7f9367 upstream
>
> The bus->clk_stop_timeout member is only initialized to a non-zero value
> during the codec driver probe. This can lead to corner cases where this
> value remains pegged at zero when the bus suspends, which results in an
> endless loop in sdw_bus_wait_for_clk_prep_deprep().
>
> Corner cases include configurations with no codecs described in the
> firmware, or delays in probing codec drivers.
>
> Initializing the default timeout to the smallest non-zero value avoid this
> problem and allows for the existing logic to be preserved: the
> bus->clk_stop_timeout is set as the maximum required by all codecs
> connected on the bus.
>
> Fixes: 1f2dcf3a154ac ("soundwire: intel: set dev_num_ida_min")
This commit is is only in 6.1-rc1, so why does it need to go to any
older kernels? Is this tag not correct?
thanks,
greg k-h
next prev parent reply other threads:[~2022-12-05 18:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 17:06 [PATCH] soundwire: intel: Initialize clock stop timeout Pierre-Louis Bossart
2022-12-05 18:33 ` Greg KH [this message]
2022-12-05 19:33 ` Pierre-Louis Bossart
2022-12-08 20:32 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2022-10-20 1:56 Bard Liao
2022-10-20 1:56 ` Bard Liao
2022-10-20 1:54 ` kernel test robot
2022-10-21 16:37 ` Pierre-Louis Bossart
2022-10-21 16:37 ` Pierre-Louis Bossart
2022-10-28 11:28 ` Vinod Koul
2022-10-28 11:28 ` Vinod Koul
2022-11-09 16:05 ` Pierre-Louis Bossart
2022-11-09 16:05 ` Pierre-Louis Bossart
2022-11-11 4:11 ` Vinod Koul
2022-11-11 4:11 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y445YurEQGO0tQqJ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chao.song@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sjoerd@collabora.com \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.