From: Greg KH <gregkh@linuxfoundation.org>
To: Daniel Scally <dan.scally@ideasonboard.com>
Cc: linux-usb@vger.kernel.org, laurent.pinchart@ideasonboard.com,
mgr@pengutronix.de, kieran.bingham@ideasonboard.com
Subject: Re: [PATCH] usb: gadget: uvc: Rename bmInterfaceFlags -> bmInterlaceFlags
Date: Mon, 5 Dec 2022 16:02:02 +0100 [thread overview]
Message-ID: <Y44H6ggXd6CNQ268@kroah.com> (raw)
In-Reply-To: <20221205145807.1099062-1-dan.scally@ideasonboard.com>
On Mon, Dec 05, 2022 at 02:58:07PM +0000, Daniel Scally wrote:
> In the specification documents for the Uncompressed and MJPEG USB
> Video Payloads, the field name is bmInterlaceFlags - it has been
> misnamed within the kernel.
>
> Although renaming the field does break the kernel's interface to
> userspace it should be low-risk in this instance. The field is read
> only and hardcoded to 0, so there was never any value in anyone
> reading it. A search of our uvc-gadget application and all the major
> forks that I could find for it did not reveal any users either.
>
> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
What commit id does this fix?
next prev parent reply other threads:[~2022-12-05 15:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 14:58 [PATCH] usb: gadget: uvc: Rename bmInterfaceFlags -> bmInterlaceFlags Daniel Scally
2022-12-05 15:01 ` Greg KH
2022-12-05 15:15 ` Dan Scally
2022-12-05 15:02 ` Greg KH [this message]
2022-12-05 22:34 ` kernel test robot
2022-12-05 23:45 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y44H6ggXd6CNQ268@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.scally@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-usb@vger.kernel.org \
--cc=mgr@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.