From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF970C4332F for ; Mon, 5 Dec 2022 16:04:37 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id ED2C9175E; Mon, 5 Dec 2022 17:03:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz ED2C9175E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1670256276; bh=mqFOwbVppYAcW5Cn5xUKN/wnrwuAAExaAVEWq0H9axM=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=THl8rFxTE28hwFrfTBqYApLieR6C1jm1d2rlc3PaHSxHiyZR4HOhqJ9AFVKA0Gm8Q 0yDxFcfsRuqWbVJNpGaVy68YjzPLhLjS3pgKVZ7vakc7FneksMRBz5BmnYpVilV/RW RMJFijXiZtb8ngcSApNo63O6a4tG441eFbqBmQMM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AFA5CF80171; Mon, 5 Dec 2022 17:03:45 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 77470F80236; Mon, 5 Dec 2022 17:03:44 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 35B6DF800BD for ; Mon, 5 Dec 2022 17:03:42 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 35B6DF800BD Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ANi23Bga" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B5497B81134; Mon, 5 Dec 2022 16:03:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8930C433D6; Mon, 5 Dec 2022 16:03:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1670256220; bh=mqFOwbVppYAcW5Cn5xUKN/wnrwuAAExaAVEWq0H9axM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ANi23BgakNxd3FkjR7VfG4ohH47l8+R8mpEFenDtWCftg3MQQ6IopoRzje2nL+HiQ W/V3GUTObsYx+ERHGuN5QFLT8PU+TPVzYsCpUcCRWon3OTurNp0CBC//sQKoJd8wn0 kpdJ4IXJQ8tNES9c4Tr4Ag8Zvf352rtyo6Fh3oJ0= Date: Mon, 5 Dec 2022 17:03:37 +0100 From: Greg KH To: Dawei Li Subject: Re: [PATCH 5/6] ac97: make remove callback of ac97 driver void returned Message-ID: References: <20221205153644.60909-1-set_pte_at@outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: jgross@suse.com, wei.liu@kernel.org, sstabellini@kernel.org, linux-hyperv@vger.kernel.org, mpe@ellerman.id.au, haiyangz@microsoft.com, linuxppc-dev@lists.ozlabs.org, decui@microsoft.com, alsa-devel@alsa-project.org, npiggin@gmail.com, linux-kernel@vger.kernel.org, oleksandr_tyshchenko@epam.com, srinivas.kandagatla@linaro.org, christophe.leroy@csgroup.eu, bgoswami@quicinc.com, xen-devel@lists.xenproject.org, johannes@sipsolutions.net, kys@microsoft.com, robert.jarzmik@free.fr, roger.pau@citrix.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Dec 05, 2022 at 11:36:43PM +0800, Dawei Li wrote: > Since commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. > > This change is for ac97 bus based drivers. > > Signed-off-by: Dawei Li > --- > drivers/mfd/wm97xx-core.c | 4 +--- > include/sound/ac97/codec.h | 6 +++--- > sound/ac97/bus.c | 5 ++--- > 3 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/mfd/wm97xx-core.c b/drivers/mfd/wm97xx-core.c > index 9a2331eb1bfa..663acbb1854c 100644 > --- a/drivers/mfd/wm97xx-core.c > +++ b/drivers/mfd/wm97xx-core.c > @@ -319,13 +319,11 @@ static int wm97xx_ac97_probe(struct ac97_codec_device *adev) > return ret; > } > > -static int wm97xx_ac97_remove(struct ac97_codec_device *adev) > +static void wm97xx_ac97_remove(struct ac97_codec_device *adev) > { > struct wm97xx_priv *wm97xx = ac97_get_drvdata(adev); > > snd_ac97_compat_release(wm97xx->ac97); > - > - return 0; > } > > static const struct ac97_id wm97xx_ac97_ids[] = { > diff --git a/include/sound/ac97/codec.h b/include/sound/ac97/codec.h > index 9792d25fa369..a26e9e0082f6 100644 > --- a/include/sound/ac97/codec.h > +++ b/include/sound/ac97/codec.h > @@ -62,9 +62,9 @@ struct ac97_codec_device { > */ > struct ac97_codec_driver { > struct device_driver driver; > - int (*probe)(struct ac97_codec_device *); > - int (*remove)(struct ac97_codec_device *); > - void (*shutdown)(struct ac97_codec_device *); > + int (*probe)(struct ac97_codec_device *dev); Why did you change this line? > + void (*remove)(struct ac97_codec_device *dev); > + void (*shutdown)(struct ac97_codec_device *dev); And this line? Don't change things that you don't describe in your changelog and that are not needed for your change. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93A4AC4332F for ; Mon, 5 Dec 2022 16:03:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230154AbiLEQDn (ORCPT ); Mon, 5 Dec 2022 11:03:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230050AbiLEQDm (ORCPT ); Mon, 5 Dec 2022 11:03:42 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 751B013FA4; Mon, 5 Dec 2022 08:03:41 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 13988611CA; Mon, 5 Dec 2022 16:03:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8930C433D6; Mon, 5 Dec 2022 16:03:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1670256220; bh=mqFOwbVppYAcW5Cn5xUKN/wnrwuAAExaAVEWq0H9axM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ANi23BgakNxd3FkjR7VfG4ohH47l8+R8mpEFenDtWCftg3MQQ6IopoRzje2nL+HiQ W/V3GUTObsYx+ERHGuN5QFLT8PU+TPVzYsCpUcCRWon3OTurNp0CBC//sQKoJd8wn0 kpdJ4IXJQ8tNES9c4Tr4Ag8Zvf352rtyo6Fh3oJ0= Date: Mon, 5 Dec 2022 17:03:37 +0100 From: Greg KH To: Dawei Li Cc: johannes@sipsolutions.net, robert.jarzmik@free.fr, jgross@suse.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, roger.pau@citrix.com, srinivas.kandagatla@linaro.org, bgoswami@quicinc.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] ac97: make remove callback of ac97 driver void returned Message-ID: References: <20221205153644.60909-1-set_pte_at@outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Mon, Dec 05, 2022 at 11:36:43PM +0800, Dawei Li wrote: > Since commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. > > This change is for ac97 bus based drivers. > > Signed-off-by: Dawei Li > --- > drivers/mfd/wm97xx-core.c | 4 +--- > include/sound/ac97/codec.h | 6 +++--- > sound/ac97/bus.c | 5 ++--- > 3 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/mfd/wm97xx-core.c b/drivers/mfd/wm97xx-core.c > index 9a2331eb1bfa..663acbb1854c 100644 > --- a/drivers/mfd/wm97xx-core.c > +++ b/drivers/mfd/wm97xx-core.c > @@ -319,13 +319,11 @@ static int wm97xx_ac97_probe(struct ac97_codec_device *adev) > return ret; > } > > -static int wm97xx_ac97_remove(struct ac97_codec_device *adev) > +static void wm97xx_ac97_remove(struct ac97_codec_device *adev) > { > struct wm97xx_priv *wm97xx = ac97_get_drvdata(adev); > > snd_ac97_compat_release(wm97xx->ac97); > - > - return 0; > } > > static const struct ac97_id wm97xx_ac97_ids[] = { > diff --git a/include/sound/ac97/codec.h b/include/sound/ac97/codec.h > index 9792d25fa369..a26e9e0082f6 100644 > --- a/include/sound/ac97/codec.h > +++ b/include/sound/ac97/codec.h > @@ -62,9 +62,9 @@ struct ac97_codec_device { > */ > struct ac97_codec_driver { > struct device_driver driver; > - int (*probe)(struct ac97_codec_device *); > - int (*remove)(struct ac97_codec_device *); > - void (*shutdown)(struct ac97_codec_device *); > + int (*probe)(struct ac97_codec_device *dev); Why did you change this line? > + void (*remove)(struct ac97_codec_device *dev); > + void (*shutdown)(struct ac97_codec_device *dev); And this line? Don't change things that you don't describe in your changelog and that are not needed for your change. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8155C4321E for ; Mon, 5 Dec 2022 16:04:37 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NQpK00rVgz3c5D for ; Tue, 6 Dec 2022 03:04:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ANi23Bga; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=145.40.68.75; helo=ams.source.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ANi23Bga; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NQpJ01Fr1z3bZ7 for ; Tue, 6 Dec 2022 03:03:44 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B5497B81134; Mon, 5 Dec 2022 16:03:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8930C433D6; Mon, 5 Dec 2022 16:03:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1670256220; bh=mqFOwbVppYAcW5Cn5xUKN/wnrwuAAExaAVEWq0H9axM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ANi23BgakNxd3FkjR7VfG4ohH47l8+R8mpEFenDtWCftg3MQQ6IopoRzje2nL+HiQ W/V3GUTObsYx+ERHGuN5QFLT8PU+TPVzYsCpUcCRWon3OTurNp0CBC//sQKoJd8wn0 kpdJ4IXJQ8tNES9c4Tr4Ag8Zvf352rtyo6Fh3oJ0= Date: Mon, 5 Dec 2022 17:03:37 +0100 From: Greg KH To: Dawei Li Subject: Re: [PATCH 5/6] ac97: make remove callback of ac97 driver void returned Message-ID: References: <20221205153644.60909-1-set_pte_at@outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jgross@suse.com, wei.liu@kernel.org, sstabellini@kernel.org, linux-hyperv@vger.kernel.org, haiyangz@microsoft.com, linuxppc-dev@lists.ozlabs.org, decui@microsoft.com, alsa-devel@alsa-project.org, npiggin@gmail.com, linux-kernel@vger.kernel.org, oleksandr_tyshchenko@epam.com, srinivas.kandagatla@linaro.org, bgoswami@quicinc.com, xen-devel@lists.xenproject.org, johannes@sipsolutions.net, kys@microsoft.com, robert.jarzmik@free.fr, roger.pau@citrix.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Dec 05, 2022 at 11:36:43PM +0800, Dawei Li wrote: > Since commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. > > This change is for ac97 bus based drivers. > > Signed-off-by: Dawei Li > --- > drivers/mfd/wm97xx-core.c | 4 +--- > include/sound/ac97/codec.h | 6 +++--- > sound/ac97/bus.c | 5 ++--- > 3 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/mfd/wm97xx-core.c b/drivers/mfd/wm97xx-core.c > index 9a2331eb1bfa..663acbb1854c 100644 > --- a/drivers/mfd/wm97xx-core.c > +++ b/drivers/mfd/wm97xx-core.c > @@ -319,13 +319,11 @@ static int wm97xx_ac97_probe(struct ac97_codec_device *adev) > return ret; > } > > -static int wm97xx_ac97_remove(struct ac97_codec_device *adev) > +static void wm97xx_ac97_remove(struct ac97_codec_device *adev) > { > struct wm97xx_priv *wm97xx = ac97_get_drvdata(adev); > > snd_ac97_compat_release(wm97xx->ac97); > - > - return 0; > } > > static const struct ac97_id wm97xx_ac97_ids[] = { > diff --git a/include/sound/ac97/codec.h b/include/sound/ac97/codec.h > index 9792d25fa369..a26e9e0082f6 100644 > --- a/include/sound/ac97/codec.h > +++ b/include/sound/ac97/codec.h > @@ -62,9 +62,9 @@ struct ac97_codec_device { > */ > struct ac97_codec_driver { > struct device_driver driver; > - int (*probe)(struct ac97_codec_device *); > - int (*remove)(struct ac97_codec_device *); > - void (*shutdown)(struct ac97_codec_device *); > + int (*probe)(struct ac97_codec_device *dev); Why did you change this line? > + void (*remove)(struct ac97_codec_device *dev); > + void (*shutdown)(struct ac97_codec_device *dev); And this line? Don't change things that you don't describe in your changelog and that are not needed for your change. thanks, greg k-h