From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76EE8C4321E for ; Mon, 5 Dec 2022 16:08:55 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2D8FD17D6; Mon, 5 Dec 2022 17:08:03 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2D8FD17D6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1670256533; bh=Eu6yRxptwIjp+jobzTRehJVPk3s3l2rtPAWW3JDKriU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CYuG8fUpYRYCHuU+HltJc/wKcEgiNpZc07QmnSRKNDKhbp3MGkdroNHeYDBbQVYD8 +/8j1kH/KR3VbJW8Wtho1cI7XuORVY6c88ToSh1f2gMIjYkZ/g6MwHdsk2NUTRQ6be pX1bVB9z6XBSX58Sk0VFOw7aNK7BL3eNvF17we14= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BCA9EF8014C; Mon, 5 Dec 2022 17:08:02 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D5D3EF80236; Mon, 5 Dec 2022 17:08:00 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9318BF8014C for ; Mon, 5 Dec 2022 17:07:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9318BF8014C Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tGQk9MFX" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 02AC9611B3; Mon, 5 Dec 2022 16:07:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA843C433D6; Mon, 5 Dec 2022 16:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1670256475; bh=Eu6yRxptwIjp+jobzTRehJVPk3s3l2rtPAWW3JDKriU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tGQk9MFX4LB7qvP2B2anJGqE6Z6d0L46ICiQtdTZRCj2bbx+sL1Qj6lDYAd796T73 krThdNV5BAuOVBcjlWHfKp1kVWotWO8++wS4g8SLIq/MBzEqMQLv0PWpHmDlNEYi2z li2DvIFUErFDJ0iS5DzLus0ZVrozvfh9M06QC2jc= Date: Mon, 5 Dec 2022 17:07:52 +0100 From: Greg KH To: Dawei Li Subject: Re: [PATCH 6/6] soundbus: make remove callback of soundbus driver void returned Message-ID: References: <20221205153644.60909-1-set_pte_at@outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: jgross@suse.com, wei.liu@kernel.org, sstabellini@kernel.org, linux-hyperv@vger.kernel.org, mpe@ellerman.id.au, haiyangz@microsoft.com, linuxppc-dev@lists.ozlabs.org, decui@microsoft.com, alsa-devel@alsa-project.org, npiggin@gmail.com, linux-kernel@vger.kernel.org, oleksandr_tyshchenko@epam.com, srinivas.kandagatla@linaro.org, christophe.leroy@csgroup.eu, bgoswami@quicinc.com, xen-devel@lists.xenproject.org, johannes@sipsolutions.net, kys@microsoft.com, robert.jarzmik@free.fr, roger.pau@citrix.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Dec 05, 2022 at 11:36:44PM +0800, Dawei Li wrote: > Since commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. > > This change is for soundbus based drivers. > > Signed-off-by: Dawei Li > --- > sound/aoa/fabrics/layout.c | 3 +-- > sound/aoa/soundbus/soundbus.h | 6 +++--- > 2 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/sound/aoa/fabrics/layout.c b/sound/aoa/fabrics/layout.c > index ec4ef18555bc..850dc8c53e9b 100644 > --- a/sound/aoa/fabrics/layout.c > +++ b/sound/aoa/fabrics/layout.c > @@ -1094,7 +1094,7 @@ static int aoa_fabric_layout_probe(struct soundbus_dev *sdev) > return -ENODEV; > } > > -static int aoa_fabric_layout_remove(struct soundbus_dev *sdev) > +static void aoa_fabric_layout_remove(struct soundbus_dev *sdev) > { > struct layout_dev *ldev = dev_get_drvdata(&sdev->ofdev.dev); > int i; > @@ -1123,7 +1123,6 @@ static int aoa_fabric_layout_remove(struct soundbus_dev *sdev) > kfree(ldev); > sdev->pcmid = -1; > sdev->pcmname = NULL; > - return 0; > } > > #ifdef CONFIG_PM_SLEEP > diff --git a/sound/aoa/soundbus/soundbus.h b/sound/aoa/soundbus/soundbus.h > index 3a99c1f1a3ca..230dfa1ba270 100644 > --- a/sound/aoa/soundbus/soundbus.h > +++ b/sound/aoa/soundbus/soundbus.h > @@ -184,10 +184,10 @@ struct soundbus_driver { > > /* we don't implement any matching at all */ > > - int (*probe)(struct soundbus_dev* dev); > - int (*remove)(struct soundbus_dev* dev); > + int (*probe)(struct soundbus_dev *dev); Why change this line too? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02B64C4332F for ; Mon, 5 Dec 2022 16:08:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230246AbiLEQIA (ORCPT ); Mon, 5 Dec 2022 11:08:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229999AbiLEQH7 (ORCPT ); Mon, 5 Dec 2022 11:07:59 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16C381B1C5; Mon, 5 Dec 2022 08:07:58 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BBF59B8111D; Mon, 5 Dec 2022 16:07:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA843C433D6; Mon, 5 Dec 2022 16:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1670256475; bh=Eu6yRxptwIjp+jobzTRehJVPk3s3l2rtPAWW3JDKriU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tGQk9MFX4LB7qvP2B2anJGqE6Z6d0L46ICiQtdTZRCj2bbx+sL1Qj6lDYAd796T73 krThdNV5BAuOVBcjlWHfKp1kVWotWO8++wS4g8SLIq/MBzEqMQLv0PWpHmDlNEYi2z li2DvIFUErFDJ0iS5DzLus0ZVrozvfh9M06QC2jc= Date: Mon, 5 Dec 2022 17:07:52 +0100 From: Greg KH To: Dawei Li Cc: johannes@sipsolutions.net, robert.jarzmik@free.fr, jgross@suse.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, roger.pau@citrix.com, srinivas.kandagatla@linaro.org, bgoswami@quicinc.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] soundbus: make remove callback of soundbus driver void returned Message-ID: References: <20221205153644.60909-1-set_pte_at@outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Mon, Dec 05, 2022 at 11:36:44PM +0800, Dawei Li wrote: > Since commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. > > This change is for soundbus based drivers. > > Signed-off-by: Dawei Li > --- > sound/aoa/fabrics/layout.c | 3 +-- > sound/aoa/soundbus/soundbus.h | 6 +++--- > 2 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/sound/aoa/fabrics/layout.c b/sound/aoa/fabrics/layout.c > index ec4ef18555bc..850dc8c53e9b 100644 > --- a/sound/aoa/fabrics/layout.c > +++ b/sound/aoa/fabrics/layout.c > @@ -1094,7 +1094,7 @@ static int aoa_fabric_layout_probe(struct soundbus_dev *sdev) > return -ENODEV; > } > > -static int aoa_fabric_layout_remove(struct soundbus_dev *sdev) > +static void aoa_fabric_layout_remove(struct soundbus_dev *sdev) > { > struct layout_dev *ldev = dev_get_drvdata(&sdev->ofdev.dev); > int i; > @@ -1123,7 +1123,6 @@ static int aoa_fabric_layout_remove(struct soundbus_dev *sdev) > kfree(ldev); > sdev->pcmid = -1; > sdev->pcmname = NULL; > - return 0; > } > > #ifdef CONFIG_PM_SLEEP > diff --git a/sound/aoa/soundbus/soundbus.h b/sound/aoa/soundbus/soundbus.h > index 3a99c1f1a3ca..230dfa1ba270 100644 > --- a/sound/aoa/soundbus/soundbus.h > +++ b/sound/aoa/soundbus/soundbus.h > @@ -184,10 +184,10 @@ struct soundbus_driver { > > /* we don't implement any matching at all */ > > - int (*probe)(struct soundbus_dev* dev); > - int (*remove)(struct soundbus_dev* dev); > + int (*probe)(struct soundbus_dev *dev); Why change this line too? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3128FC4332F for ; Mon, 5 Dec 2022 16:08:55 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NQpPx5yvTz3bbX for ; Tue, 6 Dec 2022 03:08:53 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=tGQk9MFX; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=tGQk9MFX; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NQpNx1GHCz2x9C for ; Tue, 6 Dec 2022 03:07:59 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 02AC9611B3; Mon, 5 Dec 2022 16:07:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA843C433D6; Mon, 5 Dec 2022 16:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1670256475; bh=Eu6yRxptwIjp+jobzTRehJVPk3s3l2rtPAWW3JDKriU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tGQk9MFX4LB7qvP2B2anJGqE6Z6d0L46ICiQtdTZRCj2bbx+sL1Qj6lDYAd796T73 krThdNV5BAuOVBcjlWHfKp1kVWotWO8++wS4g8SLIq/MBzEqMQLv0PWpHmDlNEYi2z li2DvIFUErFDJ0iS5DzLus0ZVrozvfh9M06QC2jc= Date: Mon, 5 Dec 2022 17:07:52 +0100 From: Greg KH To: Dawei Li Subject: Re: [PATCH 6/6] soundbus: make remove callback of soundbus driver void returned Message-ID: References: <20221205153644.60909-1-set_pte_at@outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jgross@suse.com, wei.liu@kernel.org, sstabellini@kernel.org, linux-hyperv@vger.kernel.org, haiyangz@microsoft.com, linuxppc-dev@lists.ozlabs.org, decui@microsoft.com, alsa-devel@alsa-project.org, npiggin@gmail.com, linux-kernel@vger.kernel.org, oleksandr_tyshchenko@epam.com, srinivas.kandagatla@linaro.org, bgoswami@quicinc.com, xen-devel@lists.xenproject.org, johannes@sipsolutions.net, kys@microsoft.com, robert.jarzmik@free.fr, roger.pau@citrix.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Dec 05, 2022 at 11:36:44PM +0800, Dawei Li wrote: > Since commit fc7a6209d571 ("bus: Make remove callback return > void") forces bus_type::remove be void-returned, it doesn't > make much sense for any bus based driver implementing remove > callbalk to return non-void to its caller. > > This change is for soundbus based drivers. > > Signed-off-by: Dawei Li > --- > sound/aoa/fabrics/layout.c | 3 +-- > sound/aoa/soundbus/soundbus.h | 6 +++--- > 2 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/sound/aoa/fabrics/layout.c b/sound/aoa/fabrics/layout.c > index ec4ef18555bc..850dc8c53e9b 100644 > --- a/sound/aoa/fabrics/layout.c > +++ b/sound/aoa/fabrics/layout.c > @@ -1094,7 +1094,7 @@ static int aoa_fabric_layout_probe(struct soundbus_dev *sdev) > return -ENODEV; > } > > -static int aoa_fabric_layout_remove(struct soundbus_dev *sdev) > +static void aoa_fabric_layout_remove(struct soundbus_dev *sdev) > { > struct layout_dev *ldev = dev_get_drvdata(&sdev->ofdev.dev); > int i; > @@ -1123,7 +1123,6 @@ static int aoa_fabric_layout_remove(struct soundbus_dev *sdev) > kfree(ldev); > sdev->pcmid = -1; > sdev->pcmname = NULL; > - return 0; > } > > #ifdef CONFIG_PM_SLEEP > diff --git a/sound/aoa/soundbus/soundbus.h b/sound/aoa/soundbus/soundbus.h > index 3a99c1f1a3ca..230dfa1ba270 100644 > --- a/sound/aoa/soundbus/soundbus.h > +++ b/sound/aoa/soundbus/soundbus.h > @@ -184,10 +184,10 @@ struct soundbus_driver { > > /* we don't implement any matching at all */ > > - int (*probe)(struct soundbus_dev* dev); > - int (*remove)(struct soundbus_dev* dev); > + int (*probe)(struct soundbus_dev *dev); Why change this line too? thanks, greg k-h