From: Andrew Lunn <andrew@lunn.ch>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: netdev <netdev@vger.kernel.org>,
Sean Anderson <sean.anderson@seco.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next] net: phy: swphy: Support all normal speeds when link down
Date: Mon, 5 Dec 2022 17:44:19 +0100 [thread overview]
Message-ID: <Y44f4/volEMs+0Uo@lunn.ch> (raw)
In-Reply-To: <Y44WhXU+Lq+MEM7A@shell.armlinux.org.uk>
On Mon, Dec 05, 2022 at 04:04:21PM +0000, Russell King (Oracle) wrote:
> On Sun, Dec 04, 2022 at 06:41:03PM +0100, Andrew Lunn wrote:
> > The software PHY emulator validation function is happy to accept any
> > link speed if the link is down. swphy_read_reg() however triggers a
> > WARN_ON(). Change this to report all the standard 1G link speeds are
> > supported. Once the speed is known the supported link modes will
> > change, which is a bit odd, but for emulation is probably O.K.
> >
> > Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk>
>
> This isn't what I suggested. I suggested restoring the old behaviour of
> fixed_phy before commit 5ae68b0ce134 ("phy: move fixed_phy MII register
> generation to a library") which did _not_ report all speeds, but
> reported no supported speeds in BMSR.
O.K.
Which is better. No speeds, or all speeds? I think all speeds is more
like what a real PHY does.
Andrew
next prev parent reply other threads:[~2022-12-05 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 17:41 [PATCH net-next] net: phy: swphy: Support all normal speeds when link down Andrew Lunn
2022-12-05 15:28 ` Sean Anderson
2022-12-05 16:04 ` Russell King (Oracle)
2022-12-05 16:44 ` Andrew Lunn [this message]
2022-12-05 16:50 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y44f4/volEMs+0Uo@lunn.ch \
--to=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=sean.anderson@seco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.