Re: [PATCH net-next 0/2] devlink: add params FW_BANK and ENABLE_MIGRATION

[Leon Romanovsky <leon@kernel.org>]

On Mon, Dec 05, 2022 at 10:55:16AM -0800, Shannon Nelson wrote:
> On 12/5/22 10:22 AM, Leon Romanovsky wrote:
> > On Mon, Dec 05, 2022 at 09:26:25AM -0800, Shannon Nelson wrote:
> > > Some discussions of a recent new driver RFC [1] suggested that these
> > > new parameters would be a good addition to the generic devlink list.
> > > If accepted, they will be used in the next version of the discussed
> > > driver patchset.
> > > 
> > > [1] https://lore.kernel.org/netdev/20221118225656.48309-1-snelson@pensando.io/
> > > 
> > > Shannon Nelson (2):
> > >    devlink: add fw bank select parameter
> > >    devlink: add enable_migration parameter
> > 
> > You was CCed on this more mature version, but didn't express any opinion.
> > https://lore.kernel.org/netdev/20221204141632.201932-8-shayd@nvidia.com/
> 
> Yes, and thank you for that Cc.  I wanted to get my follow-up work done and
> sent before I finished thinking about that patch.  I expect to have a chance
> later today.
> 
> Basically, this follows the existing example for enabling a feature in the
> primary device, whether or not additional ports are involved, while Shay's
> patch enables a feature for a specific port.  I think there's room for both
> answers.

I suggest to continue this discussion in Shay's series.

Thanks

> 
> sln