All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Richard Palethorpe <rpalethorpe@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] fill_fs: Ensure written data is not easily compressed
Date: Tue, 6 Dec 2022 14:33:02 +0100	[thread overview]
Message-ID: <Y49EjvZHd1npsXS7@rei> (raw)
In-Reply-To: <20221206115329.17760-2-rpalethorpe@suse.com>

Hi!
> --- a/lib/tst_fill_fs.c
> +++ b/lib/tst_fill_fs.c
> @@ -16,13 +16,20 @@ void tst_fill_fs(const char *path, int verbose)
>  {
>  	int i = 0;
>  	char file[PATH_MAX];
> -	char buf[4096];
> +	static char buf[4096];

I'm not sure if caching the random data is worth here, I bet that
reading the random data would be neglectible to the rest of the write
operations we do.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-12-06 13:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 11:53 [LTP] [PATCH 1/2] fs_fill: Add max_runtime = 60 Richard Palethorpe via ltp
2022-12-06 11:53 ` [LTP] [PATCH 2/2] fill_fs: Ensure written data is not easily compressed Richard Palethorpe via ltp
2022-12-06 13:33   ` Cyril Hrubis [this message]
2022-12-06 15:22     ` Richard Palethorpe
2022-12-06 16:15       ` Cyril Hrubis
2022-12-06 16:30         ` Richard Palethorpe
2022-12-06 18:02           ` Cyril Hrubis
2022-12-08  8:57             ` Richard Palethorpe
2022-12-09 15:28               ` Cyril Hrubis
2022-12-06 15:33 ` [LTP] [PATCH 1/2] fs_fill: Add max_runtime = 60 Petr Vorel
2022-12-08  2:39   ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y49EjvZHd1npsXS7@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=rpalethorpe@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.