From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A054FC47090 for ; Tue, 6 Dec 2022 15:55:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ACEA510E0F1; Tue, 6 Dec 2022 15:55:23 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 17F9610E0F1 for ; Tue, 6 Dec 2022 15:55:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670342120; x=1701878120; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=J3NYwLu91EjPQ96UY02h+ARHsQfFo3tfOpX+MUpAGfQ=; b=O5zsIq/a95wblcevcbnw+ooILlNmOMR+MEWu+8hMMZ1Yet4zzxv9L6FY dO1QGoaaO5xQFjGklIpRkPQvGbN6rEhP08AUUQ2g6TxXr52IUpgs2Rr4Z jLIvzbOiEnU4ig2y7tcwoZ6JL6XPWDUq2PT3YxGfxYqTDXWjZ89TnafIb p32RPV6x8fyGCjsS3l3X+PL+wKBSojou3e6P+WTzuriaLAFqByXPesM5Q BtWXPR3xepoWh8jaQ+/OujRAfpGvKg07SIE6xEAheWMEhpIpLIDLybuGX xcZBe/HDZouGf31CZa7xMm2rO/k0+qstLDJbnSaxTRUQ+aA6IwK/JlU8A A==; X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="314297631" X-IronPort-AV: E=Sophos;i="5.96,222,1665471600"; d="scan'208";a="314297631" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2022 07:55:18 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="820623538" X-IronPort-AV: E=Sophos;i="5.96,222,1665471600"; d="scan'208";a="820623538" Received: from jhaapako-mobl1.ger.corp.intel.com (HELO intel.com) ([10.251.214.21]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2022 07:55:16 -0800 Date: Tue, 6 Dec 2022 16:55:12 +0100 From: Andi Shyti To: Matthew Auld Message-ID: References: <20221202122844.428006-1-matthew.auld@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221202122844.428006-1-matthew.auld@intel.com> Subject: Re: [Intel-gfx] [PATCH v6 1/3] drm/i915/migrate: Account for the reserved_space X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Chris Wilson , Andrzej Hajda , Nirmoy Das Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Matt, On Fri, Dec 02, 2022 at 12:28:42PM +0000, Matthew Auld wrote: > From: Chris Wilson > > If the ring is nearly full when calling into emit_pte(), we might > incorrectly trample the reserved_space when constructing the packet to > emit the PTEs. This then triggers the GEM_BUG_ON(rq->reserved_space > > ring->space) when later submitting the request, since the request itself > doesn't have enough space left in the ring to emit things like > workarounds, breadcrumbs etc. > > v2: Fix the whitespace errors > > Testcase: igt@i915_selftests@live_emit_pte_full_ring > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/7535 > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6889 > Fixes: cf586021642d ("drm/i915/gt: Pipelined page migration") > Signed-off-by: Chris Wilson > Signed-off-by: Matthew Auld > Cc: Andrzej Hajda > Cc: Andi Shyti > Cc: Nirmoy Das > Cc: # v5.15+ > Tested-by: Nirmoy Das > Reviewed-by: Nirmoy Das Reviewed-by: Andi Shyti Thanks, Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1AE5C352A1 for ; Tue, 6 Dec 2022 15:55:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232733AbiLFPzV (ORCPT ); Tue, 6 Dec 2022 10:55:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229780AbiLFPzU (ORCPT ); Tue, 6 Dec 2022 10:55:20 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A6FE389F for ; Tue, 6 Dec 2022 07:55:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670342119; x=1701878119; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=J3NYwLu91EjPQ96UY02h+ARHsQfFo3tfOpX+MUpAGfQ=; b=iyLZUt3tQW1zMp8hjHE6hTDzT9zV/f2ETXy8ODLUuMzGHVn71Vk1YjnE 5ZoEzZ+scJiVqrxPql/u5f89N7Tgv4b29tmc3InD0cwmNIgObEHxNKCGr L6IDb4BeDNv95R9t5bTkAA93ejhguQU3V+K0IreRIKNWFqXILwVCwgh+z U3051Rdru1TK5fEb0lw5Uv+yqt1qtvbqJHpQr+32t69Vt4tercU+/6kW1 1aMWwr1QwV3jaoFb3xx2prqSsTRPvte5H++WaNLxtj5T1VVrGjfwUrFbL Tl3EPjTKXwVmJM63MoVyQDlXi7+3LMlNE6GJoegG4HuuPrxQR/FRCy/G2 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="314297630" X-IronPort-AV: E=Sophos;i="5.96,222,1665471600"; d="scan'208";a="314297630" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2022 07:55:18 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="820623538" X-IronPort-AV: E=Sophos;i="5.96,222,1665471600"; d="scan'208";a="820623538" Received: from jhaapako-mobl1.ger.corp.intel.com (HELO intel.com) ([10.251.214.21]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2022 07:55:16 -0800 Date: Tue, 6 Dec 2022 16:55:12 +0100 From: Andi Shyti To: Matthew Auld Cc: intel-gfx@lists.freedesktop.org, Chris Wilson , Andrzej Hajda , Andi Shyti , Nirmoy Das , stable@vger.kernel.org Subject: Re: [PATCH v6 1/3] drm/i915/migrate: Account for the reserved_space Message-ID: References: <20221202122844.428006-1-matthew.auld@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221202122844.428006-1-matthew.auld@intel.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Matt, On Fri, Dec 02, 2022 at 12:28:42PM +0000, Matthew Auld wrote: > From: Chris Wilson > > If the ring is nearly full when calling into emit_pte(), we might > incorrectly trample the reserved_space when constructing the packet to > emit the PTEs. This then triggers the GEM_BUG_ON(rq->reserved_space > > ring->space) when later submitting the request, since the request itself > doesn't have enough space left in the ring to emit things like > workarounds, breadcrumbs etc. > > v2: Fix the whitespace errors > > Testcase: igt@i915_selftests@live_emit_pte_full_ring > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/7535 > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6889 > Fixes: cf586021642d ("drm/i915/gt: Pipelined page migration") > Signed-off-by: Chris Wilson > Signed-off-by: Matthew Auld > Cc: Andrzej Hajda > Cc: Andi Shyti > Cc: Nirmoy Das > Cc: # v5.15+ > Tested-by: Nirmoy Das > Reviewed-by: Nirmoy Das Reviewed-by: Andi Shyti Thanks, Andi