All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Liang, Kan" <kan.liang@linux.intel.com>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>,
	irogers@google.com, jolsa@redhat.com, namhyung@kernel.org,
	peterz@infradead.org, mark.rutland@arm.com,
	adrian.hunter@intel.com, alexander.shishkin@linux.intel.com,
	carsten.haitzler@arm.com, leo.yan@linaro.org,
	maddy@linux.ibm.com, kjain@linux.ibm.com,
	atrajeev@linux.vnet.ibm.com, tmricht@linux.ibm.com,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	sandipan.das@amd.com, ananth.narayan@amd.com,
	santosh.shukla@amd.com
Subject: Re: [PATCH v3 0/2] perf test: Add event group test
Date: Tue, 6 Dec 2022 13:03:18 -0300	[thread overview]
Message-ID: <Y49nxv41VMtqUSNk@kernel.org> (raw)
In-Reply-To: <529367b6-e96a-d030-b8a2-bb4ad3d37d90@linux.intel.com>

Em Tue, Dec 06, 2022 at 09:47:57AM -0500, Liang, Kan escreveu:
> On 2022-12-05 11:32 p.m., Ravi Bangoria wrote:
> > Multiple events in a group can belong to one or more pmus, however
> > there are some limitations to it. One of the limitation is, perf
> > doesn't allow creating a group of events from different hw pmus.
> > Write a simple test to create various combinations of hw, sw and
> > uncore pmu events and verify group creation succeeds or fails as
> > expected.
> > 
> > v2: https://lore.kernel.org/r/20221129111946.409-1-ravi.bangoria@amd.com
> > v2->v3:
> >  - Define a set of uncore pmus that supports more than 3 events. This
> >    will prevent false negative results by not picking random uncore
> >    pmu. Test will be skipped if no uncore pmu found.
> > 
> > Ravi Bangoria (2):
> >   perf tool: Move pmus list variable to new a file
> 
> a new file
> 
> Other than the above typo, the patch series looks good to me.
> 
> Acked-by: Kan Liang <kan.liang@linux.intel.com>

Fixed that up, added your Acked-by, thanks.

- Arnaldo

      reply	other threads:[~2022-12-06 16:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06  4:32 [PATCH v3 0/2] perf test: Add event group test Ravi Bangoria
2022-12-06  4:32 ` [PATCH v3 1/2] perf tool: Move pmus list variable to new a file Ravi Bangoria
2022-12-06  4:32 ` [PATCH v3 2/2] perf test: Add event group test Ravi Bangoria
2022-12-06  6:17   ` Madhavan Srinivasan
2022-12-06 17:27   ` Athira Rajeev
2022-12-07  4:26     ` Ravi Bangoria
2022-12-07  5:31       ` Madhavan Srinivasan
2022-12-07  5:54         ` Ravi Bangoria
2022-12-06  5:02 ` [PATCH v3 0/2] " Ian Rogers
2022-12-06 14:47 ` Liang, Kan
2022-12-06 16:03   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y49nxv41VMtqUSNk@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ananth.narayan@amd.com \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=carsten.haitzler@arm.com \
    --cc=irogers@google.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@linux.intel.com \
    --cc=kjain@linux.ibm.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=maddy@linux.ibm.com \
    --cc=mark.rutland@arm.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@amd.com \
    --cc=sandipan.das@amd.com \
    --cc=santosh.shukla@amd.com \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.