From: Al Viro <viro@zeniv.linux.org.uk>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-fsdevel@vger.kernel.org, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] fs: clear a UBSAN shift-out-of-bounds warning
Date: Fri, 25 Nov 2022 06:43:49 +0000 [thread overview]
Message-ID: <Y4BkJd3Jy6MY3cdu@ZenIV> (raw)
In-Reply-To: <20221121024418.1800-1-thunder.leizhen@huawei.com>
On Mon, Nov 21, 2022 at 10:44:16AM +0800, Zhen Lei wrote:
> v1 -- > v2:
> 1. Replace INT_LIMIT(loff_t) with OFFSET_MAX in btrfs.
> 2. Replace INT_LIMIT() with type_max().
Looks fine, except that I'd rather go for commit message
along the lines of "INT_LIMIT tries to do what type_max does,
except that type_max doesn't rely upon undefined behaviour;
might as well use type_max() instead"
If you want to credit UBSAN - sure, no problem, just don't
clutter the commit message with that. As it is, it reads
as "make $TOOL STFU"...
next prev parent reply other threads:[~2022-11-25 6:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 2:44 [PATCH v2 0/2] fs: clear a UBSAN shift-out-of-bounds warning Zhen Lei
2022-11-21 2:44 ` [PATCH v2 1/2] btrfs: replace INT_LIMIT(loff_t) with OFFSET_MAX Zhen Lei
2022-11-21 17:30 ` David Sterba
2022-11-21 19:57 ` Eric Biggers
2022-11-21 2:44 ` [PATCH v2 2/2] fs: clear a UBSAN shift-out-of-bounds warning Zhen Lei
2022-11-21 19:57 ` Eric Biggers
2022-11-25 6:43 ` Al Viro [this message]
2022-11-25 8:33 ` [PATCH v2 0/2] " Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4BkJd3Jy6MY3cdu@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=ebiggers@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.