From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Gerald Loacker <gerald.loacker@wolfvision.net>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jakob Hauser <jahau@rocketmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Michael Riesch <michael.riesch@wolfvision.net>
Subject: Re: [PATCH v3 1/3] iio: add struct declarations for iio types
Date: Fri, 25 Nov 2022 13:01:28 +0200 [thread overview]
Message-ID: <Y4CgiMd4XQMV4KFV@smile.fi.intel.com> (raw)
In-Reply-To: <Y4CcspD1xkmhmWbh@smile.fi.intel.com>
On Fri, Nov 25, 2022 at 12:45:06PM +0200, Andy Shevchenko wrote:
> On Fri, Nov 25, 2022 at 09:35:24AM +0100, Gerald Loacker wrote:
...
> > +struct iio_val_int_plus_micro {
> > + int val_int;
> > + int val_micro;
> > +};
Thinking more about naming, why not drop val_ completely?
int integer;
int micro;
?
> > +struct iio_val_int_plus_nano {
> > + int val_int;
> > + int val_nano;
> > +};
> > +
> > +struct iio_val_int_plus_micro_db {
> > + int val_int;
>
> int val_int_db; ?
>
> > + int val_micro_db;
> > +};
>
> Actually why can't we simply do
>
> typedef iio_val_int_plus_micro_db iio_val_int_plus_micro;
>
> ?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-25 11:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 8:35 [PATCH v2 0/3] add ti tmag5273 driver Gerald Loacker
2022-11-25 8:35 ` [PATCH v3 1/3] iio: add struct declarations for iio types Gerald Loacker
2022-11-25 10:45 ` Andy Shevchenko
2022-11-25 11:01 ` Andy Shevchenko [this message]
2022-11-28 12:18 ` Gerald Loacker
2022-11-28 13:27 ` Andy Shevchenko
2022-11-28 13:48 ` Michael Riesch
2022-11-28 14:05 ` Andy Shevchenko
2022-11-28 14:26 ` Michael Riesch
2022-12-03 17:11 ` Jonathan Cameron
2022-11-25 8:35 ` [PATCH v3 2/3] dt-bindings: iio: magnetometer: add ti tmag5273 documentation file Gerald Loacker
2022-11-25 8:35 ` [PATCH v3 3/3] iio: magnetometer: add ti tmag5273 driver Gerald Loacker
2022-11-25 10:59 ` Andy Shevchenko
2022-11-25 11:00 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4CgiMd4XQMV4KFV@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gerald.loacker@wolfvision.net \
--cc=jahau@rocketmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.riesch@wolfvision.net \
--cc=nikita.yoush@cogentembedded.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.