From: Petr Vorel <pvorel@suse.cz>
To: David Hildenbrand <david@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] security/dirtyc0w_shmem: Add new test for CVE-2022-2590
Date: Fri, 25 Nov 2022 13:02:18 +0100 [thread overview]
Message-ID: <Y4CuyodvMln8/3N1@pevik> (raw)
In-Reply-To: <70e7f5af-d0a8-6f08-0b18-36f71e44443f@redhat.com>
> > > +static void cleanup(void)
> > > +{
> > > + SAFE_UMOUNT(TMP_DIR);
> > > +}
> > > +
> > > +static struct tst_test test = {
> > > + .needs_checkpoints = 1,
> > > + .forks_child = 1,
> > > + .needs_root = 1,
> > We are missing .needs_tmpdir flag here, otherwise the test will create
> > the the TMPDIR in PWD which may fail in certain setups.
> I just noticed that compilation now says:
> testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c: useless tag:
> needs_tmpdir
Good catch.
> So is "needs_tmpdir" indeed usless or are we missing something else?
Although not printing which tags implying .needs_tmpdir is a bit confusing,
the warning is correct - .needs_checkpoints implies .needs_tmpdir
https://github.com/linux-test-project/ltp/blob/e814430fad2e976e4a40c9d2de9e39401456d8eb/metadata/metaparse.c#L797-L806
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-11-25 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 12:14 [LTP] [PATCH v1] security/dirtyc0w_shmem: Add new test for CVE-2022-2590 David Hildenbrand
2022-11-18 13:29 ` Cyril Hrubis
2022-11-21 14:59 ` David Hildenbrand
2022-11-21 15:03 ` David Hildenbrand
2022-11-25 11:37 ` David Hildenbrand
2022-11-25 12:02 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4CuyodvMln8/3N1@pevik \
--to=pvorel@suse.cz \
--cc=david@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.