* [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433
@ 2022-11-25 11:21 ` Krzysztof Kozlowski
0 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 11:21 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: Krzysztof Kozlowski, Sriranjani P, Chanho Park, Sam Protsenko
Exynos5433 has several different SYSREGs, so use dedicated compatibles
for them.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Sriranjani P <sriranjani.p@samsung.com>
Cc: Chanho Park <chanho61.park@samsung.com>
Cc: Sam Protsenko <semen.protsenko@linaro.org>
---
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index bd6a354b9cb5..6976e45aa769 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -1118,22 +1118,26 @@ hdmiphy: hdmiphy@13af0000 {
};
syscon_disp: syscon@13b80000 {
- compatible = "samsung,exynos5433-sysreg", "syscon";
+ compatible = "samsung,exynos5433-disp-sysreg",
+ "samsung,exynos5433-sysreg", "syscon";
reg = <0x13b80000 0x1010>;
};
syscon_cam0: syscon@120f0000 {
- compatible = "samsung,exynos5433-sysreg", "syscon";
+ compatible = "samsung,exynos5433-cam0-sysreg",
+ "samsung,exynos5433-sysreg", "syscon";
reg = <0x120f0000 0x1020>;
};
syscon_cam1: syscon@145f0000 {
- compatible = "samsung,exynos5433-sysreg", "syscon";
+ compatible = "samsung,exynos5433-cam1-sysreg",
+ "samsung,exynos5433-sysreg", "syscon";
reg = <0x145f0000 0x1038>;
};
syscon_fsys: syscon@156f0000 {
- compatible = "samsung,exynos5433-sysreg", "syscon";
+ compatible = "samsung,exynos5433-fsys-sysreg",
+ "samsung,exynos5433-sysreg", "syscon";
reg = <0x156f0000 0x1044>;
};
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon
2022-11-25 11:21 ` Krzysztof Kozlowski
@ 2022-11-25 11:21 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 11:21 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: Krzysztof Kozlowski, Sriranjani P, Chanho Park, Sam Protsenko
Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
bindings and do not allow other parts of syscon.yaml. This allows
further customization of Samsung SoC bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Sriranjani P <sriranjani.p@samsung.com>
Cc: Chanho Park <chanho61.park@samsung.com>
Cc: Sam Protsenko <semen.protsenko@linaro.org>
---
.../devicetree/bindings/mfd/syscon.yaml | 6 ---
.../soc/samsung/samsung,exynos-sysreg.yaml | 39 +++++++++++++++++++
2 files changed, 39 insertions(+), 6 deletions(-)
create mode 100644 Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 1b01bd010431..b73ba1ea08f7 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -64,12 +64,6 @@ properties:
- rockchip,rk3568-qos
- rockchip,rk3588-qos
- rockchip,rv1126-qos
- - samsung,exynos3-sysreg
- - samsung,exynos4-sysreg
- - samsung,exynos5-sysreg
- - samsung,exynos5433-sysreg
- - samsung,exynos850-sysreg
- - samsung,exynosautov9-sysreg
- const: syscon
diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
new file mode 100644
index 000000000000..68064a5e339c
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -0,0 +1,39 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/samsung/samsung,exynos-sysreg.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung Exynos SoC series System Registers (SYSREG)
+
+maintainers:
+ - Krzysztof Kozlowski <krzk@kernel.org>
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - samsung,exynos3-sysreg
+ - samsung,exynos4-sysreg
+ - samsung,exynos5-sysreg
+ - samsung,exynos5433-sysreg
+ - samsung,exynos850-sysreg
+ - samsung,exynosautov9-sysreg
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ system-controller@10010000 {
+ compatible = "samsung,exynos4-sysreg", "syscon";
+ reg = <0x10010000 0x400>;
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon
@ 2022-11-25 11:21 ` Krzysztof Kozlowski
0 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 11:21 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: Krzysztof Kozlowski, Sriranjani P, Chanho Park, Sam Protsenko
Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
bindings and do not allow other parts of syscon.yaml. This allows
further customization of Samsung SoC bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Sriranjani P <sriranjani.p@samsung.com>
Cc: Chanho Park <chanho61.park@samsung.com>
Cc: Sam Protsenko <semen.protsenko@linaro.org>
---
.../devicetree/bindings/mfd/syscon.yaml | 6 ---
.../soc/samsung/samsung,exynos-sysreg.yaml | 39 +++++++++++++++++++
2 files changed, 39 insertions(+), 6 deletions(-)
create mode 100644 Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 1b01bd010431..b73ba1ea08f7 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -64,12 +64,6 @@ properties:
- rockchip,rk3568-qos
- rockchip,rk3588-qos
- rockchip,rv1126-qos
- - samsung,exynos3-sysreg
- - samsung,exynos4-sysreg
- - samsung,exynos5-sysreg
- - samsung,exynos5433-sysreg
- - samsung,exynos850-sysreg
- - samsung,exynosautov9-sysreg
- const: syscon
diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
new file mode 100644
index 000000000000..68064a5e339c
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -0,0 +1,39 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/samsung/samsung,exynos-sysreg.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung Exynos SoC series System Registers (SYSREG)
+
+maintainers:
+ - Krzysztof Kozlowski <krzk@kernel.org>
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - samsung,exynos3-sysreg
+ - samsung,exynos4-sysreg
+ - samsung,exynos5-sysreg
+ - samsung,exynos5433-sysreg
+ - samsung,exynos850-sysreg
+ - samsung,exynosautov9-sysreg
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ system-controller@10010000 {
+ compatible = "samsung,exynos4-sysreg", "syscon";
+ reg = <0x10010000 0x400>;
+ };
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon
2022-11-25 11:21 ` Krzysztof Kozlowski
@ 2022-11-25 14:05 ` Lee Jones
-1 siblings, 0 replies; 48+ messages in thread
From: Lee Jones @ 2022-11-25 14:05 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc, Sriranjani P,
Chanho Park, Sam Protsenko
On Fri, 25 Nov 2022, Krzysztof Kozlowski wrote:
> Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
> bindings and do not allow other parts of syscon.yaml. This allows
> further customization of Samsung SoC bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> .../devicetree/bindings/mfd/syscon.yaml | 6 ---
Acked-by: Lee Jones <lee@kernel.org>
> .../soc/samsung/samsung,exynos-sysreg.yaml | 39 +++++++++++++++++++
> 2 files changed, 39 insertions(+), 6 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon
@ 2022-11-25 14:05 ` Lee Jones
0 siblings, 0 replies; 48+ messages in thread
From: Lee Jones @ 2022-11-25 14:05 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc, Sriranjani P,
Chanho Park, Sam Protsenko
On Fri, 25 Nov 2022, Krzysztof Kozlowski wrote:
> Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
> bindings and do not allow other parts of syscon.yaml. This allows
> further customization of Samsung SoC bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> .../devicetree/bindings/mfd/syscon.yaml | 6 ---
Acked-by: Lee Jones <lee@kernel.org>
> .../soc/samsung/samsung,exynos-sysreg.yaml | 39 +++++++++++++++++++
> 2 files changed, 39 insertions(+), 6 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon
2022-11-25 11:21 ` Krzysztof Kozlowski
@ 2022-11-25 14:15 ` Sam Protsenko
-1 siblings, 0 replies; 48+ messages in thread
From: Sam Protsenko @ 2022-11-25 14:15 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
> bindings and do not allow other parts of syscon.yaml. This allows
> further customization of Samsung SoC bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> .../devicetree/bindings/mfd/syscon.yaml | 6 ---
> .../soc/samsung/samsung,exynos-sysreg.yaml | 39 +++++++++++++++++++
> 2 files changed, 39 insertions(+), 6 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 1b01bd010431..b73ba1ea08f7 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -64,12 +64,6 @@ properties:
> - rockchip,rk3568-qos
> - rockchip,rk3588-qos
> - rockchip,rv1126-qos
> - - samsung,exynos3-sysreg
> - - samsung,exynos4-sysreg
> - - samsung,exynos5-sysreg
> - - samsung,exynos5433-sysreg
> - - samsung,exynos850-sysreg
> - - samsung,exynosautov9-sysreg
>
> - const: syscon
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> new file mode 100644
> index 000000000000..68064a5e339c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/samsung/samsung,exynos-sysreg.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung Exynos SoC series System Registers (SYSREG)
> +
> +maintainers:
> + - Krzysztof Kozlowski <krzk@kernel.org>
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - samsung,exynos3-sysreg
> + - samsung,exynos4-sysreg
> + - samsung,exynos5-sysreg
> + - samsung,exynos5433-sysreg
> + - samsung,exynos850-sysreg
> + - samsung,exynosautov9-sysreg
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + system-controller@10010000 {
> + compatible = "samsung,exynos4-sysreg", "syscon";
> + reg = <0x10010000 0x400>;
> + };
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 48+ messages in thread* Re: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon
@ 2022-11-25 14:15 ` Sam Protsenko
0 siblings, 0 replies; 48+ messages in thread
From: Sam Protsenko @ 2022-11-25 14:15 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
> bindings and do not allow other parts of syscon.yaml. This allows
> further customization of Samsung SoC bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> .../devicetree/bindings/mfd/syscon.yaml | 6 ---
> .../soc/samsung/samsung,exynos-sysreg.yaml | 39 +++++++++++++++++++
> 2 files changed, 39 insertions(+), 6 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 1b01bd010431..b73ba1ea08f7 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -64,12 +64,6 @@ properties:
> - rockchip,rk3568-qos
> - rockchip,rk3588-qos
> - rockchip,rv1126-qos
> - - samsung,exynos3-sysreg
> - - samsung,exynos4-sysreg
> - - samsung,exynos5-sysreg
> - - samsung,exynos5433-sysreg
> - - samsung,exynos850-sysreg
> - - samsung,exynosautov9-sysreg
>
> - const: syscon
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> new file mode 100644
> index 000000000000..68064a5e339c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/samsung/samsung,exynos-sysreg.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung Exynos SoC series System Registers (SYSREG)
> +
> +maintainers:
> + - Krzysztof Kozlowski <krzk@kernel.org>
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - samsung,exynos3-sysreg
> + - samsung,exynos4-sysreg
> + - samsung,exynos5-sysreg
> + - samsung,exynos5433-sysreg
> + - samsung,exynos850-sysreg
> + - samsung,exynosautov9-sysreg
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + system-controller@10010000 {
> + compatible = "samsung,exynos4-sysreg", "syscon";
> + reg = <0x10010000 0x400>;
> + };
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread
* RE: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon
2022-11-25 11:21 ` Krzysztof Kozlowski
@ 2022-11-25 14:32 ` Sriranjani P
-1 siblings, 0 replies; 48+ messages in thread
From: Sriranjani P @ 2022-11-25 14:32 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Krzysztof Kozlowski',
'Alim Akhtar', devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
Cc: 'Chanho Park', 'Sam Protsenko'
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 25 November 2022 16:52
> To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
linux-samsung-
> soc@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
> <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
> Sam Protsenko <semen.protsenko@linaro.org>
> Subject: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from
> syscon
>
> Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
bindings
> and do not allow other parts of syscon.yaml. This allows further
customization
> of Samsung SoC bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
We agree for add separate YAML for Samsung Exynos and hence I think we can
go ahead and add separate yaml for Tesla FSD.
Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>
> .../devicetree/bindings/mfd/syscon.yaml | 6 ---
> .../soc/samsung/samsung,exynos-sysreg.yaml | 39 +++++++++++++++++++
> 2 files changed, 39 insertions(+), 6 deletions(-) create mode 100644
> Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
> b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 1b01bd010431..b73ba1ea08f7 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -64,12 +64,6 @@ properties:
> - rockchip,rk3568-qos
> - rockchip,rk3588-qos
> - rockchip,rv1126-qos
> - - samsung,exynos3-sysreg
> - - samsung,exynos4-sysreg
> - - samsung,exynos5-sysreg
> - - samsung,exynos5433-sysreg
> - - samsung,exynos850-sysreg
> - - samsung,exynosautov9-sysreg
>
> - const: syscon
>
> diff --git
> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> new file mode 100644
> index 000000000000..68064a5e339c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysre
> +++ g.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
> +---
> +$id:
> +https://protect2.fireeye.com/v1/url?k=83e9bb90-e2921107-83e830df-
> 74fe48
> +60001d-5ef78ea8b86e70d7&q=1&e=8db037ae-b28c-44df-a71b-
> 6e7c367bb9d6&u=ht
> +tp%3A%2F%2Fdevicetree.org%2Fschemas%2Fsoc%2Fsamsung%2Fsamsung%
> 2Cexynos-
> +sysreg.yaml%23
> +$schema:
> +https://protect2.fireeye.com/v1/url?k=84a37bbf-e5d8d128-84a2f0f0-74fe48
> +60001d-bf5bdaa08b35d382&q=1&e=8db037ae-b28c-44df-a71b-
> 6e7c367bb9d6&u=ht
> +tp%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23
> +
> +title: Samsung Exynos SoC series System Registers (SYSREG)
> +
> +maintainers:
> + - Krzysztof Kozlowski <krzk@kernel.org>
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - samsung,exynos3-sysreg
> + - samsung,exynos4-sysreg
> + - samsung,exynos5-sysreg
> + - samsung,exynos5433-sysreg
> + - samsung,exynos850-sysreg
> + - samsung,exynosautov9-sysreg
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + system-controller@10010000 {
> + compatible = "samsung,exynos4-sysreg", "syscon";
> + reg = <0x10010000 0x400>;
> + };
> --
> 2.34.1
^ permalink raw reply [flat|nested] 48+ messages in thread* RE: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon
@ 2022-11-25 14:32 ` Sriranjani P
0 siblings, 0 replies; 48+ messages in thread
From: Sriranjani P @ 2022-11-25 14:32 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Krzysztof Kozlowski',
'Alim Akhtar', devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
Cc: 'Chanho Park', 'Sam Protsenko'
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 25 November 2022 16:52
> To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
linux-samsung-
> soc@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
> <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
> Sam Protsenko <semen.protsenko@linaro.org>
> Subject: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from
> syscon
>
> Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
bindings
> and do not allow other parts of syscon.yaml. This allows further
customization
> of Samsung SoC bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
We agree for add separate YAML for Samsung Exynos and hence I think we can
go ahead and add separate yaml for Tesla FSD.
Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>
> .../devicetree/bindings/mfd/syscon.yaml | 6 ---
> .../soc/samsung/samsung,exynos-sysreg.yaml | 39 +++++++++++++++++++
> 2 files changed, 39 insertions(+), 6 deletions(-) create mode 100644
> Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
> b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 1b01bd010431..b73ba1ea08f7 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -64,12 +64,6 @@ properties:
> - rockchip,rk3568-qos
> - rockchip,rk3588-qos
> - rockchip,rv1126-qos
> - - samsung,exynos3-sysreg
> - - samsung,exynos4-sysreg
> - - samsung,exynos5-sysreg
> - - samsung,exynos5433-sysreg
> - - samsung,exynos850-sysreg
> - - samsung,exynosautov9-sysreg
>
> - const: syscon
>
> diff --git
> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> new file mode 100644
> index 000000000000..68064a5e339c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysre
> +++ g.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
> +---
> +$id:
> +https://protect2.fireeye.com/v1/url?k=83e9bb90-e2921107-83e830df-
> 74fe48
> +60001d-5ef78ea8b86e70d7&q=1&e=8db037ae-b28c-44df-a71b-
> 6e7c367bb9d6&u=ht
> +tp%3A%2F%2Fdevicetree.org%2Fschemas%2Fsoc%2Fsamsung%2Fsamsung%
> 2Cexynos-
> +sysreg.yaml%23
> +$schema:
> +https://protect2.fireeye.com/v1/url?k=84a37bbf-e5d8d128-84a2f0f0-74fe48
> +60001d-bf5bdaa08b35d382&q=1&e=8db037ae-b28c-44df-a71b-
> 6e7c367bb9d6&u=ht
> +tp%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23
> +
> +title: Samsung Exynos SoC series System Registers (SYSREG)
> +
> +maintainers:
> + - Krzysztof Kozlowski <krzk@kernel.org>
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - samsung,exynos3-sysreg
> + - samsung,exynos4-sysreg
> + - samsung,exynos5-sysreg
> + - samsung,exynos5433-sysreg
> + - samsung,exynos850-sysreg
> + - samsung,exynosautov9-sysreg
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + system-controller@10010000 {
> + compatible = "samsung,exynos4-sysreg", "syscon";
> + reg = <0x10010000 0x400>;
> + };
> --
> 2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread* Re: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon
2022-11-25 14:32 ` Sriranjani P
@ 2022-11-26 13:07 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-26 13:07 UTC (permalink / raw)
To: Sriranjani P, 'Lee Jones', 'Rob Herring',
'Krzysztof Kozlowski', 'Alim Akhtar', devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: 'Chanho Park', 'Sam Protsenko'
On 25/11/2022 15:32, Sriranjani P wrote:
>
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>> Sent: 25 November 2022 16:52
>> To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
> Krzysztof
>> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
>> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-samsung-
>> soc@vger.kernel.org
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
>> <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
>> Sam Protsenko <semen.protsenko@linaro.org>
>> Subject: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from
>> syscon
>>
>> Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
> bindings
>> and do not allow other parts of syscon.yaml. This allows further
> customization
>> of Samsung SoC bindings.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Cc: Sriranjani P <sriranjani.p@samsung.com>
>> Cc: Chanho Park <chanho61.park@samsung.com>
>> Cc: Sam Protsenko <semen.protsenko@linaro.org>
>> ---
>
> We agree for add separate YAML for Samsung Exynos and hence I think we can
> go ahead and add separate yaml for Tesla FSD.
> Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>
Tesla FSD should go to the same file. No need for another binding for
same design...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon
@ 2022-11-26 13:07 ` Krzysztof Kozlowski
0 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-26 13:07 UTC (permalink / raw)
To: Sriranjani P, 'Lee Jones', 'Rob Herring',
'Krzysztof Kozlowski', 'Alim Akhtar', devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: 'Chanho Park', 'Sam Protsenko'
On 25/11/2022 15:32, Sriranjani P wrote:
>
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>> Sent: 25 November 2022 16:52
>> To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
> Krzysztof
>> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
>> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-samsung-
>> soc@vger.kernel.org
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
>> <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
>> Sam Protsenko <semen.protsenko@linaro.org>
>> Subject: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from
>> syscon
>>
>> Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
> bindings
>> and do not allow other parts of syscon.yaml. This allows further
> customization
>> of Samsung SoC bindings.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Cc: Sriranjani P <sriranjani.p@samsung.com>
>> Cc: Chanho Park <chanho61.park@samsung.com>
>> Cc: Sam Protsenko <semen.protsenko@linaro.org>
>> ---
>
> We agree for add separate YAML for Samsung Exynos and hence I think we can
> go ahead and add separate yaml for Tesla FSD.
> Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>
Tesla FSD should go to the same file. No need for another binding for
same design...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread
* RE: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon
2022-11-25 11:21 ` Krzysztof Kozlowski
@ 2022-11-25 16:56 ` Alim Akhtar
-1 siblings, 0 replies; 48+ messages in thread
From: Alim Akhtar @ 2022-11-25 16:56 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Krzysztof Kozlowski', devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: 'Sriranjani P', 'Chanho Park',
'Sam Protsenko'
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Friday, November 25, 2022 4:52 PM
>To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
><sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
>Sam Protsenko <semen.protsenko@linaro.org>
>Subject: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from
>syscon
>
>Split Samsung Exynos SoC SYSREG bindings to own file to narrow the bindings
>and do not allow other parts of syscon.yaml. This allows further
customization
>of Samsung SoC bindings.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
>---
>
>Cc: Sriranjani P <sriranjani.p@samsung.com>
>Cc: Chanho Park <chanho61.park@samsung.com>
>Cc: Sam Protsenko <semen.protsenko@linaro.org>
>---
> .../devicetree/bindings/mfd/syscon.yaml | 6 ---
> .../soc/samsung/samsung,exynos-sysreg.yaml | 39
>+++++++++++++++++++
> 2 files changed, 39 insertions(+), 6 deletions(-) create mode 100644
>Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>
>diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
>b/Documentation/devicetree/bindings/mfd/syscon.yaml
>index 1b01bd010431..b73ba1ea08f7 100644
>--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>@@ -64,12 +64,6 @@ properties:
> - rockchip,rk3568-qos
> - rockchip,rk3588-qos
> - rockchip,rv1126-qos
>- - samsung,exynos3-sysreg
>- - samsung,exynos4-sysreg
>- - samsung,exynos5-sysreg
>- - samsung,exynos5433-sysreg
>- - samsung,exynos850-sysreg
>- - samsung,exynosautov9-sysreg
>
> - const: syscon
>
>diff --git
>a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>new file mode 100644
>index 000000000000..68064a5e339c
>--- /dev/null
>+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysre
>+++ g.yaml
>@@ -0,0 +1,39 @@
>+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
>+---
>+$id:
>+https://protect2.fireeye.com/v1/url?k=66a4ea1d-393fd378-66a56152-
>000bab
>+ff32e3-46dd8d7834263379&q=1&e=0e7cbbb5-e02f-4452-b6ad-
>5f17f37da091&u=ht
>+tp%3A%2F%2Fdevicetree.org%2Fschemas%2Fsoc%2Fsamsung%2Fsamsung
>%2Cexynos-
>+sysreg.yaml%23
>+$schema:
>+https://protect2.fireeye.com/v1/url?k=0bf71500-546c2c65-0bf69e4f-000bab
>+ff32e3-2ad7163b19d3c132&q=1&e=0e7cbbb5-e02f-4452-b6ad-
>5f17f37da091&u=ht
>+tp%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23
>+
>+title: Samsung Exynos SoC series System Registers (SYSREG)
>+
>+maintainers:
>+ - Krzysztof Kozlowski <krzk@kernel.org>
>+
>+properties:
>+ compatible:
>+ oneOf:
>+ - items:
>+ - enum:
>+ - samsung,exynos3-sysreg
>+ - samsung,exynos4-sysreg
>+ - samsung,exynos5-sysreg
>+ - samsung,exynos5433-sysreg
>+ - samsung,exynos850-sysreg
>+ - samsung,exynosautov9-sysreg
>+ - const: syscon
>+
>+ reg:
>+ maxItems: 1
>+
>+required:
>+ - compatible
>+ - reg
>+
>+additionalProperties: false
>+
>+examples:
>+ - |
>+ system-controller@10010000 {
>+ compatible = "samsung,exynos4-sysreg", "syscon";
>+ reg = <0x10010000 0x400>;
>+ };
>--
>2.34.1
^ permalink raw reply [flat|nested] 48+ messages in thread* RE: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon
@ 2022-11-25 16:56 ` Alim Akhtar
0 siblings, 0 replies; 48+ messages in thread
From: Alim Akhtar @ 2022-11-25 16:56 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Krzysztof Kozlowski', devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: 'Sriranjani P', 'Chanho Park',
'Sam Protsenko'
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Friday, November 25, 2022 4:52 PM
>To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
><sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
>Sam Protsenko <semen.protsenko@linaro.org>
>Subject: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from
>syscon
>
>Split Samsung Exynos SoC SYSREG bindings to own file to narrow the bindings
>and do not allow other parts of syscon.yaml. This allows further
customization
>of Samsung SoC bindings.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
>---
>
>Cc: Sriranjani P <sriranjani.p@samsung.com>
>Cc: Chanho Park <chanho61.park@samsung.com>
>Cc: Sam Protsenko <semen.protsenko@linaro.org>
>---
> .../devicetree/bindings/mfd/syscon.yaml | 6 ---
> .../soc/samsung/samsung,exynos-sysreg.yaml | 39
>+++++++++++++++++++
> 2 files changed, 39 insertions(+), 6 deletions(-) create mode 100644
>Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>
>diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
>b/Documentation/devicetree/bindings/mfd/syscon.yaml
>index 1b01bd010431..b73ba1ea08f7 100644
>--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>@@ -64,12 +64,6 @@ properties:
> - rockchip,rk3568-qos
> - rockchip,rk3588-qos
> - rockchip,rv1126-qos
>- - samsung,exynos3-sysreg
>- - samsung,exynos4-sysreg
>- - samsung,exynos5-sysreg
>- - samsung,exynos5433-sysreg
>- - samsung,exynos850-sysreg
>- - samsung,exynosautov9-sysreg
>
> - const: syscon
>
>diff --git
>a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>new file mode 100644
>index 000000000000..68064a5e339c
>--- /dev/null
>+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysre
>+++ g.yaml
>@@ -0,0 +1,39 @@
>+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
>+---
>+$id:
>+https://protect2.fireeye.com/v1/url?k=66a4ea1d-393fd378-66a56152-
>000bab
>+ff32e3-46dd8d7834263379&q=1&e=0e7cbbb5-e02f-4452-b6ad-
>5f17f37da091&u=ht
>+tp%3A%2F%2Fdevicetree.org%2Fschemas%2Fsoc%2Fsamsung%2Fsamsung
>%2Cexynos-
>+sysreg.yaml%23
>+$schema:
>+https://protect2.fireeye.com/v1/url?k=0bf71500-546c2c65-0bf69e4f-000bab
>+ff32e3-2ad7163b19d3c132&q=1&e=0e7cbbb5-e02f-4452-b6ad-
>5f17f37da091&u=ht
>+tp%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23
>+
>+title: Samsung Exynos SoC series System Registers (SYSREG)
>+
>+maintainers:
>+ - Krzysztof Kozlowski <krzk@kernel.org>
>+
>+properties:
>+ compatible:
>+ oneOf:
>+ - items:
>+ - enum:
>+ - samsung,exynos3-sysreg
>+ - samsung,exynos4-sysreg
>+ - samsung,exynos5-sysreg
>+ - samsung,exynos5433-sysreg
>+ - samsung,exynos850-sysreg
>+ - samsung,exynosautov9-sysreg
>+ - const: syscon
>+
>+ reg:
>+ maxItems: 1
>+
>+required:
>+ - compatible
>+ - reg
>+
>+additionalProperties: false
>+
>+examples:
>+ - |
>+ system-controller@10010000 {
>+ compatible = "samsung,exynos4-sysreg", "syscon";
>+ reg = <0x10010000 0x400>;
>+ };
>--
>2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
2022-11-25 11:21 ` Krzysztof Kozlowski
@ 2022-11-25 11:22 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 11:22 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: Krzysztof Kozlowski, Sriranjani P, Chanho Park, Sam Protsenko
Exynos5433 has several different SYSREGs, so use dedicated compatibles
for them.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Sriranjani P <sriranjani.p@samsung.com>
Cc: Chanho Park <chanho61.park@samsung.com>
Cc: Sam Protsenko <semen.protsenko@linaro.org>
---
.../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
index 68064a5e339c..42357466005e 100644
--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -17,10 +17,21 @@ properties:
- samsung,exynos3-sysreg
- samsung,exynos4-sysreg
- samsung,exynos5-sysreg
- - samsung,exynos5433-sysreg
- samsung,exynos850-sysreg
- samsung,exynosautov9-sysreg
- const: syscon
+ - items:
+ - enum:
+ - samsung,exynos5433-cam0-sysreg
+ - samsung,exynos5433-cam1-sysreg
+ - samsung,exynos5433-disp-sysreg
+ - samsung,exynos5433-fsys-sysreg
+ - const: samsung,exynos5433-sysreg
+ - const: syscon
+ - items:
+ - const: samsung,exynos5433-sysreg
+ - const: syscon
+ deprecated: true
reg:
maxItems: 1
--
2.34.1
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
@ 2022-11-25 11:22 ` Krzysztof Kozlowski
0 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 11:22 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: Krzysztof Kozlowski, Sriranjani P, Chanho Park, Sam Protsenko
Exynos5433 has several different SYSREGs, so use dedicated compatibles
for them.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Sriranjani P <sriranjani.p@samsung.com>
Cc: Chanho Park <chanho61.park@samsung.com>
Cc: Sam Protsenko <semen.protsenko@linaro.org>
---
.../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
index 68064a5e339c..42357466005e 100644
--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -17,10 +17,21 @@ properties:
- samsung,exynos3-sysreg
- samsung,exynos4-sysreg
- samsung,exynos5-sysreg
- - samsung,exynos5433-sysreg
- samsung,exynos850-sysreg
- samsung,exynosautov9-sysreg
- const: syscon
+ - items:
+ - enum:
+ - samsung,exynos5433-cam0-sysreg
+ - samsung,exynos5433-cam1-sysreg
+ - samsung,exynos5433-disp-sysreg
+ - samsung,exynos5433-fsys-sysreg
+ - const: samsung,exynos5433-sysreg
+ - const: syscon
+ - items:
+ - const: samsung,exynos5433-sysreg
+ - const: syscon
+ deprecated: true
reg:
maxItems: 1
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
2022-11-25 11:22 ` Krzysztof Kozlowski
@ 2022-11-25 14:22 ` Sam Protsenko
-1 siblings, 0 replies; 48+ messages in thread
From: Sam Protsenko @ 2022-11-25 14:22 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Exynos5433 has several different SYSREGs, so use dedicated compatibles
> for them.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
Hi Krzysztof,
Just curious: what is the rationale for adding those more specific
sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
pretty much the same register layout.
Other than that:
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> index 68064a5e339c..42357466005e 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -17,10 +17,21 @@ properties:
> - samsung,exynos3-sysreg
> - samsung,exynos4-sysreg
> - samsung,exynos5-sysreg
> - - samsung,exynos5433-sysreg
> - samsung,exynos850-sysreg
> - samsung,exynosautov9-sysreg
> - const: syscon
> + - items:
> + - enum:
> + - samsung,exynos5433-cam0-sysreg
> + - samsung,exynos5433-cam1-sysreg
> + - samsung,exynos5433-disp-sysreg
> + - samsung,exynos5433-fsys-sysreg
> + - const: samsung,exynos5433-sysreg
> + - const: syscon
> + - items:
> + - const: samsung,exynos5433-sysreg
> + - const: syscon
> + deprecated: true
>
> reg:
> maxItems: 1
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
@ 2022-11-25 14:22 ` Sam Protsenko
0 siblings, 0 replies; 48+ messages in thread
From: Sam Protsenko @ 2022-11-25 14:22 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Exynos5433 has several different SYSREGs, so use dedicated compatibles
> for them.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
Hi Krzysztof,
Just curious: what is the rationale for adding those more specific
sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
pretty much the same register layout.
Other than that:
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> index 68064a5e339c..42357466005e 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -17,10 +17,21 @@ properties:
> - samsung,exynos3-sysreg
> - samsung,exynos4-sysreg
> - samsung,exynos5-sysreg
> - - samsung,exynos5433-sysreg
> - samsung,exynos850-sysreg
> - samsung,exynosautov9-sysreg
> - const: syscon
> + - items:
> + - enum:
> + - samsung,exynos5433-cam0-sysreg
> + - samsung,exynos5433-cam1-sysreg
> + - samsung,exynos5433-disp-sysreg
> + - samsung,exynos5433-fsys-sysreg
> + - const: samsung,exynos5433-sysreg
> + - const: syscon
> + - items:
> + - const: samsung,exynos5433-sysreg
> + - const: syscon
> + deprecated: true
>
> reg:
> maxItems: 1
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
2022-11-25 14:22 ` Sam Protsenko
@ 2022-11-25 14:47 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 14:47 UTC (permalink / raw)
To: Sam Protsenko
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On 25/11/2022 15:22, Sam Protsenko wrote:
> On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> Exynos5433 has several different SYSREGs, so use dedicated compatibles
>> for them.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Cc: Sriranjani P <sriranjani.p@samsung.com>
>> Cc: Chanho Park <chanho61.park@samsung.com>
>> Cc: Sam Protsenko <semen.protsenko@linaro.org>
>> ---
>
> Hi Krzysztof,
>
> Just curious: what is the rationale for adding those more specific
> sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
> pretty much the same register layout.
>
On Exynos5433 all these blocks have different registers. Are you saying
that Exynos850 has four (or more) sysregs which are exactly the same?
Same registers? Why would they duplicate it?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
@ 2022-11-25 14:47 ` Krzysztof Kozlowski
0 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 14:47 UTC (permalink / raw)
To: Sam Protsenko
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On 25/11/2022 15:22, Sam Protsenko wrote:
> On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> Exynos5433 has several different SYSREGs, so use dedicated compatibles
>> for them.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Cc: Sriranjani P <sriranjani.p@samsung.com>
>> Cc: Chanho Park <chanho61.park@samsung.com>
>> Cc: Sam Protsenko <semen.protsenko@linaro.org>
>> ---
>
> Hi Krzysztof,
>
> Just curious: what is the rationale for adding those more specific
> sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
> pretty much the same register layout.
>
On Exynos5433 all these blocks have different registers. Are you saying
that Exynos850 has four (or more) sysregs which are exactly the same?
Same registers? Why would they duplicate it?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
2022-11-25 14:47 ` Krzysztof Kozlowski
@ 2022-11-25 14:57 ` Sam Protsenko
-1 siblings, 0 replies; 48+ messages in thread
From: Sam Protsenko @ 2022-11-25 14:57 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On Fri, 25 Nov 2022 at 08:47, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 25/11/2022 15:22, Sam Protsenko wrote:
> > On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> Exynos5433 has several different SYSREGs, so use dedicated compatibles
> >> for them.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>
> >> ---
> >>
> >> Cc: Sriranjani P <sriranjani.p@samsung.com>
> >> Cc: Chanho Park <chanho61.park@samsung.com>
> >> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> >> ---
> >
> > Hi Krzysztof,
> >
> > Just curious: what is the rationale for adding those more specific
> > sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
> > pretty much the same register layout.
> >
>
> On Exynos5433 all these blocks have different registers. Are you saying
> that Exynos850 has four (or more) sysregs which are exactly the same?
> Same registers? Why would they duplicate it?
>
Ah, no, you are right. Just checked it, they are different. Just first
couple of registers are similar between blocks, that's why I memorized
it wrong.
So as I understand, adding those new compatibles follows "describe HW,
not a driver" rule? Because AFAIU, right now it'll fallback to
"syscon" compatible anyway.
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
@ 2022-11-25 14:57 ` Sam Protsenko
0 siblings, 0 replies; 48+ messages in thread
From: Sam Protsenko @ 2022-11-25 14:57 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On Fri, 25 Nov 2022 at 08:47, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 25/11/2022 15:22, Sam Protsenko wrote:
> > On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> Exynos5433 has several different SYSREGs, so use dedicated compatibles
> >> for them.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>
> >> ---
> >>
> >> Cc: Sriranjani P <sriranjani.p@samsung.com>
> >> Cc: Chanho Park <chanho61.park@samsung.com>
> >> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> >> ---
> >
> > Hi Krzysztof,
> >
> > Just curious: what is the rationale for adding those more specific
> > sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
> > pretty much the same register layout.
> >
>
> On Exynos5433 all these blocks have different registers. Are you saying
> that Exynos850 has four (or more) sysregs which are exactly the same?
> Same registers? Why would they duplicate it?
>
Ah, no, you are right. Just checked it, they are different. Just first
couple of registers are similar between blocks, that's why I memorized
it wrong.
So as I understand, adding those new compatibles follows "describe HW,
not a driver" rule? Because AFAIU, right now it'll fallback to
"syscon" compatible anyway.
> Best regards,
> Krzysztof
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
2022-11-25 14:57 ` Sam Protsenko
@ 2022-11-25 15:01 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 15:01 UTC (permalink / raw)
To: Sam Protsenko
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On 25/11/2022 15:57, Sam Protsenko wrote:
> On Fri, 25 Nov 2022 at 08:47, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 25/11/2022 15:22, Sam Protsenko wrote:
>>> On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
>>> <krzysztof.kozlowski@linaro.org> wrote:
>>>>
>>>> Exynos5433 has several different SYSREGs, so use dedicated compatibles
>>>> for them.
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>
>>>> ---
>>>>
>>>> Cc: Sriranjani P <sriranjani.p@samsung.com>
>>>> Cc: Chanho Park <chanho61.park@samsung.com>
>>>> Cc: Sam Protsenko <semen.protsenko@linaro.org>
>>>> ---
>>>
>>> Hi Krzysztof,
>>>
>>> Just curious: what is the rationale for adding those more specific
>>> sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
>>> pretty much the same register layout.
>>>
>>
>> On Exynos5433 all these blocks have different registers. Are you saying
>> that Exynos850 has four (or more) sysregs which are exactly the same?
>> Same registers? Why would they duplicate it?
>>
>
> Ah, no, you are right. Just checked it, they are different. Just first
> couple of registers are similar between blocks, that's why I memorized
> it wrong.
>
> So as I understand, adding those new compatibles follows "describe HW,
> not a driver" rule? Because AFAIU, right now it'll fallback to
> "syscon" compatible anyway.
Yes, they describe hardware. Of course all of these sysregs are similar
as they are just bunch of SFR/MMIO-region, but they have different
roles/features. For example some other devices (users) of syscon/sysreg
should reference specific device, not any sysreg.
On several other architectures we use specific compatibles, so I think
for Samsung we should do the same.
Different case was for Exynos 3/4/5 where there was only one SYSREG.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
@ 2022-11-25 15:01 ` Krzysztof Kozlowski
0 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 15:01 UTC (permalink / raw)
To: Sam Protsenko
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On 25/11/2022 15:57, Sam Protsenko wrote:
> On Fri, 25 Nov 2022 at 08:47, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 25/11/2022 15:22, Sam Protsenko wrote:
>>> On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
>>> <krzysztof.kozlowski@linaro.org> wrote:
>>>>
>>>> Exynos5433 has several different SYSREGs, so use dedicated compatibles
>>>> for them.
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>
>>>> ---
>>>>
>>>> Cc: Sriranjani P <sriranjani.p@samsung.com>
>>>> Cc: Chanho Park <chanho61.park@samsung.com>
>>>> Cc: Sam Protsenko <semen.protsenko@linaro.org>
>>>> ---
>>>
>>> Hi Krzysztof,
>>>
>>> Just curious: what is the rationale for adding those more specific
>>> sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
>>> pretty much the same register layout.
>>>
>>
>> On Exynos5433 all these blocks have different registers. Are you saying
>> that Exynos850 has four (or more) sysregs which are exactly the same?
>> Same registers? Why would they duplicate it?
>>
>
> Ah, no, you are right. Just checked it, they are different. Just first
> couple of registers are similar between blocks, that's why I memorized
> it wrong.
>
> So as I understand, adding those new compatibles follows "describe HW,
> not a driver" rule? Because AFAIU, right now it'll fallback to
> "syscon" compatible anyway.
Yes, they describe hardware. Of course all of these sysregs are similar
as they are just bunch of SFR/MMIO-region, but they have different
roles/features. For example some other devices (users) of syscon/sysreg
should reference specific device, not any sysreg.
On several other architectures we use specific compatibles, so I think
for Samsung we should do the same.
Different case was for Exynos 3/4/5 where there was only one SYSREG.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread
* RE: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
2022-11-25 15:01 ` Krzysztof Kozlowski
@ 2022-11-25 16:40 ` Alim Akhtar
-1 siblings, 0 replies; 48+ messages in thread
From: Alim Akhtar @ 2022-11-25 16:40 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Sam Protsenko'
Cc: 'Lee Jones', 'Rob Herring',
'Krzysztof Kozlowski', devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, 'Sriranjani P',
'Chanho Park'
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Friday, November 25, 2022 8:31 PM
>To: Sam Protsenko <semen.protsenko@linaro.org>
>Cc: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org; Sriranjani P <sriranjani.p@samsung.com>;
>Chanho Park <chanho61.park@samsung.com>
>Subject: Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add
>dedicated SYSREG compatibles to Exynos5433
>
>On 25/11/2022 15:57, Sam Protsenko wrote:
>> On Fri, 25 Nov 2022 at 08:47, Krzysztof Kozlowski
>> <krzysztof.kozlowski@linaro.org> wrote:
>>>
>>> On 25/11/2022 15:22, Sam Protsenko wrote:
>>>> On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
>>>> <krzysztof.kozlowski@linaro.org> wrote:
>>>>>
>>>>> Exynos5433 has several different SYSREGs, so use dedicated
>>>>> compatibles for them.
>>>>>
>>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>>
>>>>> ---
>>>>>
>>>>> Cc: Sriranjani P <sriranjani.p@samsung.com>
>>>>> Cc: Chanho Park <chanho61.park@samsung.com>
>>>>> Cc: Sam Protsenko <semen.protsenko@linaro.org>
>>>>> ---
>>>>
>>>> Hi Krzysztof,
>>>>
>>>> Just curious: what is the rationale for adding those more specific
>>>> sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
>>>> pretty much the same register layout.
>>>>
>>>
>>> On Exynos5433 all these blocks have different registers. Are you
>>> saying that Exynos850 has four (or more) sysregs which are exactly the
>same?
>>> Same registers? Why would they duplicate it?
>>>
>>
>> Ah, no, you are right. Just checked it, they are different. Just first
>> couple of registers are similar between blocks, that's why I memorized
>> it wrong.
>>
>> So as I understand, adding those new compatibles follows "describe HW,
>> not a driver" rule? Because AFAIU, right now it'll fallback to
>> "syscon" compatible anyway.
>
>Yes, they describe hardware. Of course all of these sysregs are similar as they
>are just bunch of SFR/MMIO-region, but they have different roles/features.
>For example some other devices (users) of syscon/sysreg should reference
>specific device, not any sysreg.
>
Yes, these are dedicated / extended SFR region to provide IP/Block specific side-band signals / configurations.
>On several other architectures we use specific compatibles, so I think for
>Samsung we should do the same.
>
Yes, most of the SoC's sysreg are dedicated/included in the IP block itself now a day, so make sense to have a dedicated compatible.
>Different case was for Exynos 3/4/5 where there was only one SYSREG.
>
AFAIR, this is correct.
>Best regards,
>Krzysztof
^ permalink raw reply [flat|nested] 48+ messages in thread
* RE: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
@ 2022-11-25 16:40 ` Alim Akhtar
0 siblings, 0 replies; 48+ messages in thread
From: Alim Akhtar @ 2022-11-25 16:40 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Sam Protsenko'
Cc: 'Lee Jones', 'Rob Herring',
'Krzysztof Kozlowski', devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, 'Sriranjani P',
'Chanho Park'
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Friday, November 25, 2022 8:31 PM
>To: Sam Protsenko <semen.protsenko@linaro.org>
>Cc: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org; Sriranjani P <sriranjani.p@samsung.com>;
>Chanho Park <chanho61.park@samsung.com>
>Subject: Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add
>dedicated SYSREG compatibles to Exynos5433
>
>On 25/11/2022 15:57, Sam Protsenko wrote:
>> On Fri, 25 Nov 2022 at 08:47, Krzysztof Kozlowski
>> <krzysztof.kozlowski@linaro.org> wrote:
>>>
>>> On 25/11/2022 15:22, Sam Protsenko wrote:
>>>> On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
>>>> <krzysztof.kozlowski@linaro.org> wrote:
>>>>>
>>>>> Exynos5433 has several different SYSREGs, so use dedicated
>>>>> compatibles for them.
>>>>>
>>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>>
>>>>> ---
>>>>>
>>>>> Cc: Sriranjani P <sriranjani.p@samsung.com>
>>>>> Cc: Chanho Park <chanho61.park@samsung.com>
>>>>> Cc: Sam Protsenko <semen.protsenko@linaro.org>
>>>>> ---
>>>>
>>>> Hi Krzysztof,
>>>>
>>>> Just curious: what is the rationale for adding those more specific
>>>> sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
>>>> pretty much the same register layout.
>>>>
>>>
>>> On Exynos5433 all these blocks have different registers. Are you
>>> saying that Exynos850 has four (or more) sysregs which are exactly the
>same?
>>> Same registers? Why would they duplicate it?
>>>
>>
>> Ah, no, you are right. Just checked it, they are different. Just first
>> couple of registers are similar between blocks, that's why I memorized
>> it wrong.
>>
>> So as I understand, adding those new compatibles follows "describe HW,
>> not a driver" rule? Because AFAIU, right now it'll fallback to
>> "syscon" compatible anyway.
>
>Yes, they describe hardware. Of course all of these sysregs are similar as they
>are just bunch of SFR/MMIO-region, but they have different roles/features.
>For example some other devices (users) of syscon/sysreg should reference
>specific device, not any sysreg.
>
Yes, these are dedicated / extended SFR region to provide IP/Block specific side-band signals / configurations.
>On several other architectures we use specific compatibles, so I think for
>Samsung we should do the same.
>
Yes, most of the SoC's sysreg are dedicated/included in the IP block itself now a day, so make sense to have a dedicated compatible.
>Different case was for Exynos 3/4/5 where there was only one SYSREG.
>
AFAIR, this is correct.
>Best regards,
>Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread
* RE: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
2022-11-25 11:22 ` Krzysztof Kozlowski
@ 2022-11-25 14:33 ` Sriranjani P
-1 siblings, 0 replies; 48+ messages in thread
From: Sriranjani P @ 2022-11-25 14:33 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Krzysztof Kozlowski',
'Alim Akhtar', devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
Cc: 'Chanho Park', 'Sam Protsenko'
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 25 November 2022 16:52
> To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
linux-samsung-
> soc@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
> <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
> Sam Protsenko <semen.protsenko@linaro.org>
> Subject: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add
dedicated
> SYSREG compatibles to Exynos5433
>
> Exynos5433 has several different SYSREGs, so use dedicated compatibles for
> them.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>
> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git
> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> index 68064a5e339c..42357466005e 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysre
> +++ g.yaml
> @@ -17,10 +17,21 @@ properties:
> - samsung,exynos3-sysreg
> - samsung,exynos4-sysreg
> - samsung,exynos5-sysreg
> - - samsung,exynos5433-sysreg
> - samsung,exynos850-sysreg
> - samsung,exynosautov9-sysreg
> - const: syscon
> + - items:
> + - enum:
> + - samsung,exynos5433-cam0-sysreg
> + - samsung,exynos5433-cam1-sysreg
> + - samsung,exynos5433-disp-sysreg
> + - samsung,exynos5433-fsys-sysreg
> + - const: samsung,exynos5433-sysreg
> + - const: syscon
> + - items:
> + - const: samsung,exynos5433-sysreg
> + - const: syscon
> + deprecated: true
>
> reg:
> maxItems: 1
> --
> 2.34.1
^ permalink raw reply [flat|nested] 48+ messages in thread
* RE: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
@ 2022-11-25 14:33 ` Sriranjani P
0 siblings, 0 replies; 48+ messages in thread
From: Sriranjani P @ 2022-11-25 14:33 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Krzysztof Kozlowski',
'Alim Akhtar', devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
Cc: 'Chanho Park', 'Sam Protsenko'
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 25 November 2022 16:52
> To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
linux-samsung-
> soc@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
> <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
> Sam Protsenko <semen.protsenko@linaro.org>
> Subject: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add
dedicated
> SYSREG compatibles to Exynos5433
>
> Exynos5433 has several different SYSREGs, so use dedicated compatibles for
> them.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>
> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git
> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> index 68064a5e339c..42357466005e 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysre
> +++ g.yaml
> @@ -17,10 +17,21 @@ properties:
> - samsung,exynos3-sysreg
> - samsung,exynos4-sysreg
> - samsung,exynos5-sysreg
> - - samsung,exynos5433-sysreg
> - samsung,exynos850-sysreg
> - samsung,exynosautov9-sysreg
> - const: syscon
> + - items:
> + - enum:
> + - samsung,exynos5433-cam0-sysreg
> + - samsung,exynos5433-cam1-sysreg
> + - samsung,exynos5433-disp-sysreg
> + - samsung,exynos5433-fsys-sysreg
> + - const: samsung,exynos5433-sysreg
> + - const: syscon
> + - items:
> + - const: samsung,exynos5433-sysreg
> + - const: syscon
> + deprecated: true
>
> reg:
> maxItems: 1
> --
> 2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread
* RE: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
2022-11-25 11:22 ` Krzysztof Kozlowski
@ 2022-11-25 17:06 ` Alim Akhtar
-1 siblings, 0 replies; 48+ messages in thread
From: Alim Akhtar @ 2022-11-25 17:06 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Krzysztof Kozlowski', devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: 'Sriranjani P', 'Chanho Park',
'Sam Protsenko'
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Friday, November 25, 2022 4:52 PM
>To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
><sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
>Sam Protsenko <semen.protsenko@linaro.org>
>Subject: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add
dedicated
>SYSREG compatibles to Exynos5433
>
>Exynos5433 has several different SYSREGs, so use dedicated compatibles for
>them.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>---
>
>Cc: Sriranjani P <sriranjani.p@samsung.com>
>Cc: Chanho Park <chanho61.park@samsung.com>
>Cc: Sam Protsenko <semen.protsenko@linaro.org>
>---
> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
>diff --git
>a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>index 68064a5e339c..42357466005e 100644
>--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysre
>+++ g.yaml
>@@ -17,10 +17,21 @@ properties:
> - samsung,exynos3-sysreg
> - samsung,exynos4-sysreg
> - samsung,exynos5-sysreg
>- - samsung,exynos5433-sysreg
> - samsung,exynos850-sysreg
> - samsung,exynosautov9-sysreg
> - const: syscon
>+ - items:
>+ - enum:
>+ - samsung,exynos5433-cam0-sysreg
>+ - samsung,exynos5433-cam1-sysreg
>+ - samsung,exynos5433-disp-sysreg
>+ - samsung,exynos5433-fsys-sysreg
>+ - const: samsung,exynos5433-sysreg
>+ - const: syscon
>+ - items:
>+ - const: samsung,exynos5433-sysreg
>+ - const: syscon
>+ deprecated: true
Any reason to add "deprecated: true" here for above compatible?
>
> reg:
> maxItems: 1
>--
>2.34.1
^ permalink raw reply [flat|nested] 48+ messages in thread
* RE: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
@ 2022-11-25 17:06 ` Alim Akhtar
0 siblings, 0 replies; 48+ messages in thread
From: Alim Akhtar @ 2022-11-25 17:06 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Krzysztof Kozlowski', devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: 'Sriranjani P', 'Chanho Park',
'Sam Protsenko'
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Friday, November 25, 2022 4:52 PM
>To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
><sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
>Sam Protsenko <semen.protsenko@linaro.org>
>Subject: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add
dedicated
>SYSREG compatibles to Exynos5433
>
>Exynos5433 has several different SYSREGs, so use dedicated compatibles for
>them.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>---
>
>Cc: Sriranjani P <sriranjani.p@samsung.com>
>Cc: Chanho Park <chanho61.park@samsung.com>
>Cc: Sam Protsenko <semen.protsenko@linaro.org>
>---
> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
>diff --git
>a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>index 68064a5e339c..42357466005e 100644
>--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysre
>+++ g.yaml
>@@ -17,10 +17,21 @@ properties:
> - samsung,exynos3-sysreg
> - samsung,exynos4-sysreg
> - samsung,exynos5-sysreg
>- - samsung,exynos5433-sysreg
> - samsung,exynos850-sysreg
> - samsung,exynosautov9-sysreg
> - const: syscon
>+ - items:
>+ - enum:
>+ - samsung,exynos5433-cam0-sysreg
>+ - samsung,exynos5433-cam1-sysreg
>+ - samsung,exynos5433-disp-sysreg
>+ - samsung,exynos5433-fsys-sysreg
>+ - const: samsung,exynos5433-sysreg
>+ - const: syscon
>+ - items:
>+ - const: samsung,exynos5433-sysreg
>+ - const: syscon
>+ deprecated: true
Any reason to add "deprecated: true" here for above compatible?
>
> reg:
> maxItems: 1
>--
>2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
2022-11-25 17:06 ` Alim Akhtar
@ 2022-11-26 13:08 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-26 13:08 UTC (permalink / raw)
To: Alim Akhtar, 'Lee Jones', 'Rob Herring',
'Krzysztof Kozlowski', devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc
Cc: 'Sriranjani P', 'Chanho Park',
'Sam Protsenko'
On 25/11/2022 18:06, Alim Akhtar wrote:
>
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>> Sent: Friday, November 25, 2022 4:52 PM
>> To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
>> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
>> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>> samsung-soc@vger.kernel.org
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
>> <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
>> Sam Protsenko <semen.protsenko@linaro.org>
>> Subject: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add
> dedicated
>> SYSREG compatibles to Exynos5433
>>
>> Exynos5433 has several different SYSREGs, so use dedicated compatibles for
>> them.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Cc: Sriranjani P <sriranjani.p@samsung.com>
>> Cc: Chanho Park <chanho61.park@samsung.com>
>> Cc: Sam Protsenko <semen.protsenko@linaro.org>
>> ---
>> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysreg.yaml
>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysreg.yaml
>> index 68064a5e339c..42357466005e 100644
>> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysreg.yaml
>> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysre
>> +++ g.yaml
>> @@ -17,10 +17,21 @@ properties:
>> - samsung,exynos3-sysreg
>> - samsung,exynos4-sysreg
>> - samsung,exynos5-sysreg
>> - - samsung,exynos5433-sysreg
>> - samsung,exynos850-sysreg
>> - samsung,exynosautov9-sysreg
>> - const: syscon
>> + - items:
>> + - enum:
>> + - samsung,exynos5433-cam0-sysreg
>> + - samsung,exynos5433-cam1-sysreg
>> + - samsung,exynos5433-disp-sysreg
>> + - samsung,exynos5433-fsys-sysreg
>> + - const: samsung,exynos5433-sysreg
>> + - const: syscon
>> + - items:
>> + - const: samsung,exynos5433-sysreg
>> + - const: syscon
>> + deprecated: true
> Any reason to add "deprecated: true" here for above compatible?
Because it should be used alone as unspecific.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
@ 2022-11-26 13:08 ` Krzysztof Kozlowski
0 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-26 13:08 UTC (permalink / raw)
To: Alim Akhtar, 'Lee Jones', 'Rob Herring',
'Krzysztof Kozlowski', devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc
Cc: 'Sriranjani P', 'Chanho Park',
'Sam Protsenko'
On 25/11/2022 18:06, Alim Akhtar wrote:
>
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>> Sent: Friday, November 25, 2022 4:52 PM
>> To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
>> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
>> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>> samsung-soc@vger.kernel.org
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
>> <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
>> Sam Protsenko <semen.protsenko@linaro.org>
>> Subject: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add
> dedicated
>> SYSREG compatibles to Exynos5433
>>
>> Exynos5433 has several different SYSREGs, so use dedicated compatibles for
>> them.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Cc: Sriranjani P <sriranjani.p@samsung.com>
>> Cc: Chanho Park <chanho61.park@samsung.com>
>> Cc: Sam Protsenko <semen.protsenko@linaro.org>
>> ---
>> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysreg.yaml
>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysreg.yaml
>> index 68064a5e339c..42357466005e 100644
>> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysreg.yaml
>> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysre
>> +++ g.yaml
>> @@ -17,10 +17,21 @@ properties:
>> - samsung,exynos3-sysreg
>> - samsung,exynos4-sysreg
>> - samsung,exynos5-sysreg
>> - - samsung,exynos5433-sysreg
>> - samsung,exynos850-sysreg
>> - samsung,exynosautov9-sysreg
>> - const: syscon
>> + - items:
>> + - enum:
>> + - samsung,exynos5433-cam0-sysreg
>> + - samsung,exynos5433-cam1-sysreg
>> + - samsung,exynos5433-disp-sysreg
>> + - samsung,exynos5433-fsys-sysreg
>> + - const: samsung,exynos5433-sysreg
>> + - const: syscon
>> + - items:
>> + - const: samsung,exynos5433-sysreg
>> + - const: syscon
>> + deprecated: true
> Any reason to add "deprecated: true" here for above compatible?
Because it should be used alone as unspecific.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850
2022-11-25 11:21 ` Krzysztof Kozlowski
@ 2022-11-25 11:22 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 11:22 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: Krzysztof Kozlowski, Sriranjani P, Chanho Park, Sam Protsenko
Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even
though Linux currently does not enable them and relies on bootloader.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Sriranjani P <sriranjani.p@samsung.com>
Cc: Chanho Park <chanho61.park@samsung.com>
Cc: Sam Protsenko <semen.protsenko@linaro.org>
---
.../soc/samsung/samsung,exynos-sysreg.yaml | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
index 42357466005e..27cea934a286 100644
--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -36,10 +36,25 @@ properties:
reg:
maxItems: 1
+ clocks:
+ maxItems: 1
+
required:
- compatible
- reg
+allOf:
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - samsung,exynos850-sysreg
+ then:
+ properties:
+ clocks: false
+
additionalProperties: false
examples:
--
2.34.1
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850
@ 2022-11-25 11:22 ` Krzysztof Kozlowski
0 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 11:22 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: Krzysztof Kozlowski, Sriranjani P, Chanho Park, Sam Protsenko
Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even
though Linux currently does not enable them and relies on bootloader.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Sriranjani P <sriranjani.p@samsung.com>
Cc: Chanho Park <chanho61.park@samsung.com>
Cc: Sam Protsenko <semen.protsenko@linaro.org>
---
.../soc/samsung/samsung,exynos-sysreg.yaml | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
index 42357466005e..27cea934a286 100644
--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -36,10 +36,25 @@ properties:
reg:
maxItems: 1
+ clocks:
+ maxItems: 1
+
required:
- compatible
- reg
+allOf:
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - samsung,exynos850-sysreg
+ then:
+ properties:
+ clocks: false
+
additionalProperties: false
examples:
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 48+ messages in thread* RE: [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850
2022-11-25 11:22 ` Krzysztof Kozlowski
@ 2022-11-25 14:33 ` Sriranjani P
-1 siblings, 0 replies; 48+ messages in thread
From: Sriranjani P @ 2022-11-25 14:33 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Krzysztof Kozlowski',
'Alim Akhtar', devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
Cc: 'Chanho Park', 'Sam Protsenko'
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 25 November 2022 16:52
> To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
linux-samsung-
> soc@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
> <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
> Sam Protsenko <semen.protsenko@linaro.org>
> Subject: [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks
for
> Exynos850
>
> Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even
though
> Linux currently does not enable them and relies on bootloader.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>
> .../soc/samsung/samsung,exynos-sysreg.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> index 42357466005e..27cea934a286 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysre
> +++ g.yaml
> @@ -36,10 +36,25 @@ properties:
> reg:
> maxItems: 1
>
> + clocks:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
>
> +allOf:
> + - if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - samsung,exynos850-sysreg
> + then:
> + properties:
> + clocks: false
> +
> additionalProperties: false
>
> examples:
> --
> 2.34.1
^ permalink raw reply [flat|nested] 48+ messages in thread
* RE: [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850
@ 2022-11-25 14:33 ` Sriranjani P
0 siblings, 0 replies; 48+ messages in thread
From: Sriranjani P @ 2022-11-25 14:33 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Krzysztof Kozlowski',
'Alim Akhtar', devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
Cc: 'Chanho Park', 'Sam Protsenko'
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 25 November 2022 16:52
> To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
linux-samsung-
> soc@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
> <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
> Sam Protsenko <semen.protsenko@linaro.org>
> Subject: [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks
for
> Exynos850
>
> Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even
though
> Linux currently does not enable them and relies on bootloader.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>
> .../soc/samsung/samsung,exynos-sysreg.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> index 42357466005e..27cea934a286 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysre
> +++ g.yaml
> @@ -36,10 +36,25 @@ properties:
> reg:
> maxItems: 1
>
> + clocks:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
>
> +allOf:
> + - if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - samsung,exynos850-sysreg
> + then:
> + properties:
> + clocks: false
> +
> additionalProperties: false
>
> examples:
> --
> 2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850
2022-11-25 11:22 ` Krzysztof Kozlowski
@ 2022-11-25 14:38 ` Sam Protsenko
-1 siblings, 0 replies; 48+ messages in thread
From: Sam Protsenko @ 2022-11-25 14:38 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even
> though Linux currently does not enable them and relies on bootloader.
>
Not sure if this description is correct. Of course, there is no driver
for "samsung,exynos850-sysreg" compatible at the moment, so the next
compatible from the list ("syscon") is used for Exynos850. And
"syscon" driver (drivers/mfd/syscon.c) actually does control the
clocks. I remember adding "clocks" property to Exynos850 dts to fix
actual problem. Also, the "clocks" property is not described in
Documentation/devicetree/bindings/mfd/syscon.yaml, didn't really check
if it's ok or it's just missing.
Other than that comment:
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> .../soc/samsung/samsung,exynos-sysreg.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> index 42357466005e..27cea934a286 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -36,10 +36,25 @@ properties:
> reg:
> maxItems: 1
>
> + clocks:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
>
> +allOf:
> + - if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - samsung,exynos850-sysreg
> + then:
> + properties:
> + clocks: false
> +
> additionalProperties: false
>
> examples:
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 48+ messages in thread* Re: [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850
@ 2022-11-25 14:38 ` Sam Protsenko
0 siblings, 0 replies; 48+ messages in thread
From: Sam Protsenko @ 2022-11-25 14:38 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even
> though Linux currently does not enable them and relies on bootloader.
>
Not sure if this description is correct. Of course, there is no driver
for "samsung,exynos850-sysreg" compatible at the moment, so the next
compatible from the list ("syscon") is used for Exynos850. And
"syscon" driver (drivers/mfd/syscon.c) actually does control the
clocks. I remember adding "clocks" property to Exynos850 dts to fix
actual problem. Also, the "clocks" property is not described in
Documentation/devicetree/bindings/mfd/syscon.yaml, didn't really check
if it's ok or it's just missing.
Other than that comment:
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> .../soc/samsung/samsung,exynos-sysreg.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> index 42357466005e..27cea934a286 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -36,10 +36,25 @@ properties:
> reg:
> maxItems: 1
>
> + clocks:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
>
> +allOf:
> + - if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - samsung,exynos850-sysreg
> + then:
> + properties:
> + clocks: false
> +
> additionalProperties: false
>
> examples:
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread* Re: [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850
2022-11-25 14:38 ` Sam Protsenko
@ 2022-11-25 14:49 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 14:49 UTC (permalink / raw)
To: Sam Protsenko
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On 25/11/2022 15:38, Sam Protsenko wrote:
> On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even
>> though Linux currently does not enable them and relies on bootloader.
>>
>
> Not sure if this description is correct. Of course, there is no driver
> for "samsung,exynos850-sysreg" compatible at the moment, so the next
> compatible from the list ("syscon") is used for Exynos850. And
> "syscon" driver (drivers/mfd/syscon.c) actually does control the
> clocks. I remember adding "clocks" property to Exynos850 dts to fix
> actual problem. Also, the "clocks" property is not described in
> Documentation/devicetree/bindings/mfd/syscon.yaml, didn't really check
> if it's ok or it's just missing.
>
> Other than that comment:
>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Ah, then commit msg is not good. I'll update it and maybe the clocks
should be required for Exynos850?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 48+ messages in thread* Re: [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850
@ 2022-11-25 14:49 ` Krzysztof Kozlowski
0 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 14:49 UTC (permalink / raw)
To: Sam Protsenko
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On 25/11/2022 15:38, Sam Protsenko wrote:
> On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even
>> though Linux currently does not enable them and relies on bootloader.
>>
>
> Not sure if this description is correct. Of course, there is no driver
> for "samsung,exynos850-sysreg" compatible at the moment, so the next
> compatible from the list ("syscon") is used for Exynos850. And
> "syscon" driver (drivers/mfd/syscon.c) actually does control the
> clocks. I remember adding "clocks" property to Exynos850 dts to fix
> actual problem. Also, the "clocks" property is not described in
> Documentation/devicetree/bindings/mfd/syscon.yaml, didn't really check
> if it's ok or it's just missing.
>
> Other than that comment:
>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Ah, then commit msg is not good. I'll update it and maybe the clocks
should be required for Exynos850?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread* Re: [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850
2022-11-25 14:49 ` Krzysztof Kozlowski
@ 2022-11-25 15:01 ` Sam Protsenko
-1 siblings, 0 replies; 48+ messages in thread
From: Sam Protsenko @ 2022-11-25 15:01 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On Fri, 25 Nov 2022 at 08:49, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 25/11/2022 15:38, Sam Protsenko wrote:
> > On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even
> >> though Linux currently does not enable them and relies on bootloader.
> >>
> >
> > Not sure if this description is correct. Of course, there is no driver
> > for "samsung,exynos850-sysreg" compatible at the moment, so the next
> > compatible from the list ("syscon") is used for Exynos850. And
> > "syscon" driver (drivers/mfd/syscon.c) actually does control the
> > clocks. I remember adding "clocks" property to Exynos850 dts to fix
> > actual problem. Also, the "clocks" property is not described in
> > Documentation/devicetree/bindings/mfd/syscon.yaml, didn't really check
> > if it's ok or it's just missing.
> >
> > Other than that comment:
> >
> > Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> >
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Ah, then commit msg is not good. I'll update it and maybe the clocks
> should be required for Exynos850?
>
Yeah, looks like all Exynos850 sysreg blocks have dedicated clock.
Please make it required. And thanks for working on that! :)
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 48+ messages in thread* Re: [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850
@ 2022-11-25 15:01 ` Sam Protsenko
0 siblings, 0 replies; 48+ messages in thread
From: Sam Protsenko @ 2022-11-25 15:01 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On Fri, 25 Nov 2022 at 08:49, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 25/11/2022 15:38, Sam Protsenko wrote:
> > On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even
> >> though Linux currently does not enable them and relies on bootloader.
> >>
> >
> > Not sure if this description is correct. Of course, there is no driver
> > for "samsung,exynos850-sysreg" compatible at the moment, so the next
> > compatible from the list ("syscon") is used for Exynos850. And
> > "syscon" driver (drivers/mfd/syscon.c) actually does control the
> > clocks. I remember adding "clocks" property to Exynos850 dts to fix
> > actual problem. Also, the "clocks" property is not described in
> > Documentation/devicetree/bindings/mfd/syscon.yaml, didn't really check
> > if it's ok or it's just missing.
> >
> > Other than that comment:
> >
> > Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> >
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Ah, then commit msg is not good. I'll update it and maybe the clocks
> should be required for Exynos850?
>
Yeah, looks like all Exynos850 sysreg blocks have dedicated clock.
Please make it required. And thanks for working on that! :)
> Best regards,
> Krzysztof
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433
2022-11-25 11:21 ` Krzysztof Kozlowski
@ 2022-11-25 14:22 ` Sam Protsenko
-1 siblings, 0 replies; 48+ messages in thread
From: Sam Protsenko @ 2022-11-25 14:22 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Exynos5433 has several different SYSREGs, so use dedicated compatibles
> for them.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index bd6a354b9cb5..6976e45aa769 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -1118,22 +1118,26 @@ hdmiphy: hdmiphy@13af0000 {
> };
>
> syscon_disp: syscon@13b80000 {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-disp-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x13b80000 0x1010>;
> };
>
> syscon_cam0: syscon@120f0000 {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-cam0-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x120f0000 0x1020>;
> };
>
> syscon_cam1: syscon@145f0000 {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-cam1-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x145f0000 0x1038>;
> };
>
> syscon_fsys: syscon@156f0000 {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-fsys-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x156f0000 0x1044>;
> };
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 48+ messages in thread* Re: [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433
@ 2022-11-25 14:22 ` Sam Protsenko
0 siblings, 0 replies; 48+ messages in thread
From: Sam Protsenko @ 2022-11-25 14:22 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Exynos5433 has several different SYSREGs, so use dedicated compatibles
> for them.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index bd6a354b9cb5..6976e45aa769 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -1118,22 +1118,26 @@ hdmiphy: hdmiphy@13af0000 {
> };
>
> syscon_disp: syscon@13b80000 {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-disp-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x13b80000 0x1010>;
> };
>
> syscon_cam0: syscon@120f0000 {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-cam0-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x120f0000 0x1020>;
> };
>
> syscon_cam1: syscon@145f0000 {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-cam1-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x145f0000 0x1038>;
> };
>
> syscon_fsys: syscon@156f0000 {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-fsys-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x156f0000 0x1044>;
> };
>
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread
* RE: [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433
2022-11-25 11:21 ` Krzysztof Kozlowski
@ 2022-11-25 14:29 ` Sriranjani P
-1 siblings, 0 replies; 48+ messages in thread
From: Sriranjani P @ 2022-11-25 14:29 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Krzysztof Kozlowski',
'Alim Akhtar', devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
Cc: 'Chanho Park', 'Sam Protsenko'
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 25 November 2022 16:52
> To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
linux-samsung-
> soc@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
> <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
> Sam Protsenko <semen.protsenko@linaro.org>
> Subject: [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles
> to Exynos5433
>
> Exynos5433 has several different SYSREGs, so use dedicated compatibles for
> them.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index bd6a354b9cb5..6976e45aa769 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -1118,22 +1118,26 @@ hdmiphy: hdmiphy@13af0000 {
> };
>
> syscon_disp: syscon@13b80000 {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-disp-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x13b80000 0x1010>;
> };
>
> syscon_cam0: syscon@120f0000 {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-cam0-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x120f0000 0x1020>;
> };
>
> syscon_cam1: syscon@145f0000 {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-cam1-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x145f0000 0x1038>;
> };
>
> syscon_fsys: syscon@156f0000 {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-fsys-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x156f0000 0x1044>;
> };
>
> --
> 2.34.1
^ permalink raw reply [flat|nested] 48+ messages in thread* RE: [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433
@ 2022-11-25 14:29 ` Sriranjani P
0 siblings, 0 replies; 48+ messages in thread
From: Sriranjani P @ 2022-11-25 14:29 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Krzysztof Kozlowski',
'Alim Akhtar', devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc
Cc: 'Chanho Park', 'Sam Protsenko'
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 25 November 2022 16:52
> To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
linux-samsung-
> soc@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
> <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
> Sam Protsenko <semen.protsenko@linaro.org>
> Subject: [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles
> to Exynos5433
>
> Exynos5433 has several different SYSREGs, so use dedicated compatibles for
> them.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index bd6a354b9cb5..6976e45aa769 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -1118,22 +1118,26 @@ hdmiphy: hdmiphy@13af0000 {
> };
>
> syscon_disp: syscon@13b80000 {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-disp-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x13b80000 0x1010>;
> };
>
> syscon_cam0: syscon@120f0000 {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-cam0-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x120f0000 0x1020>;
> };
>
> syscon_cam1: syscon@145f0000 {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-cam1-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x145f0000 0x1038>;
> };
>
> syscon_fsys: syscon@156f0000 {
> - compatible = "samsung,exynos5433-sysreg", "syscon";
> + compatible = "samsung,exynos5433-fsys-sysreg",
> + "samsung,exynos5433-sysreg", "syscon";
> reg = <0x156f0000 0x1044>;
> };
>
> --
> 2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread
* RE: [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433
2022-11-25 11:21 ` Krzysztof Kozlowski
@ 2022-11-25 16:51 ` Alim Akhtar
-1 siblings, 0 replies; 48+ messages in thread
From: Alim Akhtar @ 2022-11-25 16:51 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Krzysztof Kozlowski', devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: 'Sriranjani P', 'Chanho Park',
'Sam Protsenko'
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Friday, November 25, 2022 4:52 PM
>To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
><sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
>Sam Protsenko <semen.protsenko@linaro.org>
>Subject: [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles
>to Exynos5433
>
>Exynos5433 has several different SYSREGs, so use dedicated compatibles for
>them.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
>---
>
>Cc: Sriranjani P <sriranjani.p@samsung.com>
>Cc: Chanho Park <chanho61.park@samsung.com>
>Cc: Sam Protsenko <semen.protsenko@linaro.org>
>---
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>index bd6a354b9cb5..6976e45aa769 100644
>--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>@@ -1118,22 +1118,26 @@ hdmiphy: hdmiphy@13af0000 {
> };
>
> syscon_disp: syscon@13b80000 {
>- compatible = "samsung,exynos5433-sysreg", "syscon";
>+ compatible = "samsung,exynos5433-disp-sysreg",
>+ "samsung,exynos5433-sysreg", "syscon";
> reg = <0x13b80000 0x1010>;
> };
>
> syscon_cam0: syscon@120f0000 {
>- compatible = "samsung,exynos5433-sysreg", "syscon";
>+ compatible = "samsung,exynos5433-cam0-sysreg",
>+ "samsung,exynos5433-sysreg", "syscon";
> reg = <0x120f0000 0x1020>;
> };
>
> syscon_cam1: syscon@145f0000 {
>- compatible = "samsung,exynos5433-sysreg", "syscon";
>+ compatible = "samsung,exynos5433-cam1-sysreg",
>+ "samsung,exynos5433-sysreg", "syscon";
> reg = <0x145f0000 0x1038>;
> };
>
> syscon_fsys: syscon@156f0000 {
>- compatible = "samsung,exynos5433-sysreg", "syscon";
>+ compatible = "samsung,exynos5433-fsys-sysreg",
>+ "samsung,exynos5433-sysreg", "syscon";
> reg = <0x156f0000 0x1044>;
> };
>
>--
>2.34.1
^ permalink raw reply [flat|nested] 48+ messages in thread* RE: [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433
@ 2022-11-25 16:51 ` Alim Akhtar
0 siblings, 0 replies; 48+ messages in thread
From: Alim Akhtar @ 2022-11-25 16:51 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Krzysztof Kozlowski', devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: 'Sriranjani P', 'Chanho Park',
'Sam Protsenko'
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Friday, November 25, 2022 4:52 PM
>To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
><sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
>Sam Protsenko <semen.protsenko@linaro.org>
>Subject: [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles
>to Exynos5433
>
>Exynos5433 has several different SYSREGs, so use dedicated compatibles for
>them.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
>---
>
>Cc: Sriranjani P <sriranjani.p@samsung.com>
>Cc: Chanho Park <chanho61.park@samsung.com>
>Cc: Sam Protsenko <semen.protsenko@linaro.org>
>---
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>index bd6a354b9cb5..6976e45aa769 100644
>--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>@@ -1118,22 +1118,26 @@ hdmiphy: hdmiphy@13af0000 {
> };
>
> syscon_disp: syscon@13b80000 {
>- compatible = "samsung,exynos5433-sysreg", "syscon";
>+ compatible = "samsung,exynos5433-disp-sysreg",
>+ "samsung,exynos5433-sysreg", "syscon";
> reg = <0x13b80000 0x1010>;
> };
>
> syscon_cam0: syscon@120f0000 {
>- compatible = "samsung,exynos5433-sysreg", "syscon";
>+ compatible = "samsung,exynos5433-cam0-sysreg",
>+ "samsung,exynos5433-sysreg", "syscon";
> reg = <0x120f0000 0x1020>;
> };
>
> syscon_cam1: syscon@145f0000 {
>- compatible = "samsung,exynos5433-sysreg", "syscon";
>+ compatible = "samsung,exynos5433-cam1-sysreg",
>+ "samsung,exynos5433-sysreg", "syscon";
> reg = <0x145f0000 0x1038>;
> };
>
> syscon_fsys: syscon@156f0000 {
>- compatible = "samsung,exynos5433-sysreg", "syscon";
>+ compatible = "samsung,exynos5433-fsys-sysreg",
>+ "samsung,exynos5433-sysreg", "syscon";
> reg = <0x156f0000 0x1044>;
> };
>
>--
>2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 48+ messages in thread