From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C442C4332F for ; Fri, 25 Nov 2022 15:09:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229642AbiKYPJe (ORCPT ); Fri, 25 Nov 2022 10:09:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbiKYPJd (ORCPT ); Fri, 25 Nov 2022 10:09:33 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D956110FCB for ; Fri, 25 Nov 2022 07:09:32 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id z18so6739724edb.9 for ; Fri, 25 Nov 2022 07:09:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=melexis.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ozh3pwg86FVwgjieqWWpm1hzWQIk7mfvK3o0wWrBzu4=; b=jCg5C9UU92OwRrZbUzXLpweCXUn90+JxHOUG0YPUi7eYPcNXQUVqWpUuAAmkDZOwKY BkookJ0P/6KnyWPgtqzzcdOKqGpAcz0fCyinhZOiF1iWCrL9KJUC1cGP2kCWjyr2rIVe R0IS7cf5PIX4qgxQSJW1Bb5axWNbmqdxjOz56WZobvoughqVFQAXHVvVawtM/iD0nxVg QuzR8CX1zP0lcPMLtASAZAIWVpzm9kgl63/QeWQfgdjwSH/vEQ77tMxfpB7E5yvlGlqP 6m3FmmvRM4f/maVLML5lPBhPkT4HWRguJgCh917x+8nylGyw+PVcvlaBlqamoTUaUZSC ALgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ozh3pwg86FVwgjieqWWpm1hzWQIk7mfvK3o0wWrBzu4=; b=pEFKbY1OIC6lgvHLI4fUI8Au0uot1LV444k86NgMQPh+ZI4mImlDSqSAJ+jY43pOxf LxDazqfOrOQtUxOzzfD/R76VjsDQTN3c5V1q5MLGU+iL9FD6YaL8Zyh3RsH4UNkGtXbr AIlCJDgmxHpNos4qKNmrjQFjlNhXvzANh97EcVt/GkWdnd1mXuQTwLfKkOMRRLZwWNKe W46JtpA9plkttAN4+QatdzuQZkzM2EBlo5Mf5IAoe/5ErTGn6CuXvp1C5Ak0D5vzdnI/ qWGlI273xFhB9jzijaDjag0Yl0Y5Nw2/j6uG6wuj0ZQvyPiJfmf8nV/InGxJ7i4BaoFD 1jwA== X-Gm-Message-State: ANoB5pnXeCvgz6MKiCfsxD43tHpitVxwPoU8xKvL7adHr/7H71rbYQ1b 5U9hGrytaraDBCLeLCiVWlC5yA== X-Google-Smtp-Source: AA0mqf5mgk8Kt1q+JGS5dt/N9C+KQrjEOfVAiuaNKlxvG4q8gENyrcpPKSZUrty4+UVGHedqXGrfIw== X-Received: by 2002:a05:6402:2421:b0:461:524f:a8f4 with SMTP id t33-20020a056402242100b00461524fa8f4mr34645374eda.260.1669388971310; Fri, 25 Nov 2022 07:09:31 -0800 (PST) Received: from melexis.com ([2a02:2378:1085:b41d:bec4:93fd:8998:6d7a]) by smtp.gmail.com with ESMTPSA id 26-20020a170906329a00b0078d4ee47c82sm1642718ejw.129.2022.11.25.07.09.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Nov 2022 07:09:30 -0800 (PST) Date: Fri, 25 Nov 2022 17:09:27 +0200 From: Volodymyr Kharuk To: Hans Verkuil Cc: linux-media@vger.kernel.org, Andrii Kyselov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Laurent Pinchart , devicetree@vger.kernel.org, Sakari Ailus , Benjamin Mugnier Subject: Re: [PATCH v3 6/8] media: uapi: Add mlx7502x header file Message-ID: References: <06d4c93d-3f94-cc95-f123-751e7bb2ab3b@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <06d4c93d-3f94-cc95-f123-751e7bb2ab3b@xs4all.nl> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Nov 25, 2022 at 03:39:16PM +0100, Hans Verkuil wrote: > On 25/11/2022 14:34, Volodymyr Kharuk wrote: > > Define user controls for mlx7502x driver, add its documentation and > > update MAINTAINERS > > > > Signed-off-by: Volodymyr Kharuk > > --- > > .../userspace-api/media/drivers/index.rst | 1 + > > .../userspace-api/media/drivers/mlx7502x.rst | 28 +++++++++++++++++++ > > MAINTAINERS | 2 ++ > > include/uapi/linux/mlx7502x.h | 20 +++++++++++++ > > 4 files changed, 51 insertions(+) > > create mode 100644 Documentation/userspace-api/media/drivers/mlx7502x.rst > > create mode 100644 include/uapi/linux/mlx7502x.h > > > > diff --git a/Documentation/userspace-api/media/drivers/index.rst b/Documentation/userspace-api/media/drivers/index.rst > > index 32f82aed47d9..f49e1b64c256 100644 > > --- a/Documentation/userspace-api/media/drivers/index.rst > > +++ b/Documentation/userspace-api/media/drivers/index.rst > > @@ -37,5 +37,6 @@ For more details see the file COPYING in the source distribution of Linux. > > imx-uapi > > max2175 > > meye-uapi > > + mlx7502x > > omap3isp-uapi > > uvcvideo > > diff --git a/Documentation/userspace-api/media/drivers/mlx7502x.rst b/Documentation/userspace-api/media/drivers/mlx7502x.rst > > new file mode 100644 > > index 000000000000..6f4874ec010d > > --- /dev/null > > +++ b/Documentation/userspace-api/media/drivers/mlx7502x.rst > > @@ -0,0 +1,28 @@ > > +.. SPDX-License-Identifier: GPL-2.0 > > + > > +Melexis mlx7502x ToF camera sensor driver > > +========================================= > > + > > +The mlx7502x driver implements the following driver-specific controls: > > + > > +``V4L2_CID_MLX7502X_OUTPUT_MODE (menu)`` > > +---------------------------------------- > > + The sensor has two taps, which gather reflected light: A and B. > > + The control sets the way data should be put in a buffer. The most > > + common output mode is A-B which provides the best sunlight robustness. > > + > > +.. flat-table:: > > + :header-rows: 0 > > + :stub-columns: 0 > > + :widths: 1 4 > > + > > + * - ``(0)`` > > + - A minus B > > + * - ``(1)`` > > + - A plus B > > + * - ``(2)`` > > + - only A > > + * - ``(3)`` > > + - only B > > + * - ``(4)`` > > + - A and B (this config will change PAD format) > > diff --git a/MAINTAINERS b/MAINTAINERS > > index a2bc2ce53056..0a6dda8da6bc 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -13116,7 +13116,9 @@ M: Volodymyr Kharuk > > L: linux-media@vger.kernel.org > > S: Supported > > W: http://www.melexis.com > > +F: Documentation/userspace-api/media/drivers/mlx7502x.rst > > F: Documentation/userspace-api/media/v4l/ext-ctrls-tof.rst > > +F: include/uapi/linux/mlx7502x.h > > > > MELFAS MIP4 TOUCHSCREEN DRIVER > > M: Sangwon Jee > > diff --git a/include/uapi/linux/mlx7502x.h b/include/uapi/linux/mlx7502x.h > > new file mode 100644 > > index 000000000000..68014f550ed2 > > --- /dev/null > > +++ b/include/uapi/linux/mlx7502x.h > > @@ -0,0 +1,20 @@ > > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > > +/* > > + * Melexis 7502x ToF cameras driver. > > + * > > + * Copyright (C) 2021 Melexis N.V. > > + * > > + */ > > + > > +#ifndef __UAPI_MLX7502X_H_ > > +#define __UAPI_MLX7502X_H_ > > + > > +#include > > + > > +/* > > + * this is related to the taps in ToF cameras, > > + * usually A minus B is the best option > > + */ > > +#define V4L2_CID_MLX7502X_OUTPUT_MODE (V4L2_CID_USER_MLX7502X_BASE + 0) > > You need to add an enum with the mode settings. E.g.: > > enum v4l2_mlx7502x_output_mode { > V4L2_MLX7502X_OUTPUT_MODE_A_MINUS_B = 0, > ... > }; > > And you can use those enum defines in the documentation. Ok, thanks. That is is interesting. Will fix in next version. > > Regards, > > Hans > > > + > > +#endif /* __UAPI_MLX7502X_H_ */ > -- -- BR, Volodymyr Kharuk