From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] Implement tst_setup_netns() helper function
Date: Fri, 25 Nov 2022 17:43:13 +0100 [thread overview]
Message-ID: <Y4DwocwY/SQnVPY0@pevik> (raw)
In-Reply-To: <20221125153453.19323-1-mdoucha@suse.cz>
Hi Martin,
> Namespace setup boilerplate for network tests is getting more complicated
> with the need to check or modify some sysfiles. Move it into LTP library.
+1
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> #define TST_NO_DEFAULT_MAIN
> #include "tst_test.h"
> #include "tst_net.h"
> #include "tst_private.h"
> +#include "lapi/namespaces_constants.h"
WDYT about adding <sched.h> to lapi/namespaces_constants.h?
(not related to this patchset at all).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-11-25 16:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 15:34 [LTP] [PATCH 1/2] Implement tst_setup_netns() helper function Martin Doucha
2022-11-25 15:34 ` [LTP] [PATCH 2/2] syscalls: Replace namespace setup boilerplate with tst_setup_netns() Martin Doucha
2022-11-25 16:43 ` Petr Vorel [this message]
2022-11-25 17:01 ` [LTP] [PATCH 1/2] Implement tst_setup_netns() helper function Petr Vorel
2022-11-25 17:09 ` Martin Doucha
2022-11-25 17:17 ` Petr Vorel
2022-11-25 17:20 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4DwocwY/SQnVPY0@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.