From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Petr Vorel <petr.vorel@gmail.com>
Cc: "Petr Vorel" <pevik@seznam.cz>,
openembedded-core@lists.openembedded.org,
"Richard Purdie" <richard.purdie@linuxfoundation.org>,
"Daniel Díaz" <daniel.diaz@linaro.org>,
"Khem Raj" <raj.khem@gmail.com>,
"Changhyeok Bae" <changhyeok.bae@gmail.com>,
"Alexander Kanavin" <alex.kanavin@gmail.com>
Subject: Re: [OE-core] [PATCH v2 1/1] iputils: update to 20221126
Date: Sun, 27 Nov 2022 23:13:36 +0100 [thread overview]
Message-ID: <Y4PhEOd5RUZ97Bff@mail.local> (raw)
In-Reply-To: <CAB1t1Cym1x5-k7yG3QCB+br+J-d0AouFJMBHObywPb7-F-PO7Q@mail.gmail.com>
On 27/11/2022 22:55:31+0100, Petr Vorel wrote:
> On Sun, 27 Nov 2022 at 19:42, Alexandre Belloni
> <alexandre.belloni@bootlin.com> wrote:
> >
> > Hello,
> >
> > You should at least build test your patches
>
> OK, I'll do. What always discourages me is that unlike Buildroot
> build, openembedded takes so long.
>
> What I usually do:
> cd ..; git clone git://git.openembedded.org/bitbake.git; cd -
> . oe-init-build-env
> bitbake iputils
>
> If there is anything I can speedup a build (e.g. using some of host
> utils to build really just the target) please let me know.
Not really, you'd have to keep your sstate-cache but my guess is that
your builds are infrequent enough that everything will rebuild anyway.
This made me try to understand why you didn't test your patches and I
didn't realize you are maintaining iputils. Thanks for the help!
>
> >
> > On 27/11/2022 16:17:08+0100, Petr Vorel wrote:
> > > -PACKAGECONFIG ??= "libcap rarpd \
> > > - ${@bb.utils.contains('DISTRO_FEATURES', 'ipv6', 'ninfod', '', d)} \
> > > +PACKAGECONFIG ??= "libcap \
> > > + ${@bb.utils.contains('DISTRO_FEATURES', 'ipv6', '', d)} \
> >
> > This probably doesn't work either
> Not sure what's wrong on this, but maybe build shows that out.
The whole bb.utils.contains call can be removed because it doesn't do
anything once you remove the 'ninfod' argument.
I'll send the patch to our CI with the line removed
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2022-11-27 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 15:17 [PATCH v2 1/1] iputils: update to 20221126 Petr Vorel
2022-11-27 18:42 ` [OE-core] " Alexandre Belloni
2022-11-27 21:55 ` Petr Vorel
2022-11-27 22:13 ` Alexandre Belloni [this message]
2022-11-27 22:22 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4PhEOd5RUZ97Bff@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=alex.kanavin@gmail.com \
--cc=changhyeok.bae@gmail.com \
--cc=daniel.diaz@linaro.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=petr.vorel@gmail.com \
--cc=pevik@seznam.cz \
--cc=raj.khem@gmail.com \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.