From: Yu-Chien Peter Lin <peterlin@andestech.com>
To: opensbi@lists.infradead.org
Subject: [PATCH v2 5/7] platform: Add Renesas RZ/Five initial support
Date: Mon, 28 Nov 2022 09:23:04 +0000 [thread overview]
Message-ID: <Y4R9+NxyafIbka8Q@APC323> (raw)
In-Reply-To: <20221111182105.614094-6-prabhakar.mahadev-lad.rj@bp.renesas.com>
Hi Prabhakar,
> > The fact that you have to compile ae350/cache.c as part of this platform
> > shows we need to improve code re-use.
> >
> > Further, the platform.c added by this patch is very similar to platform.c
> > of andes/ae350. Both platform.c files are subset of what is already there
> > in generic/platform.c.
> >
> > I suggest you do the following:
> > 1) Move andes/ae350 as a platform override under generic/platform/andes/ae350
> > 2) Add rzfive as platform override under generic/platform/renesas/rzfive
> > 3) The common Andes cache operations will be a library under
> > generic/platform/andes/ae350 which can be selected by renesas/rzfive
> > 4) The common Andes header can be under generic/include/andes/ae350
> > 5) Enable drivers required by andes/ae350 and renesas/rzfive platform
> > overrides in generic/configs/defconfig
> >
> - The reason for not using generic is because the FW_TEXT_START is different.
> - I came across the thread where because the generic FW uses FW_PIC
> it doesn matter about the FW_TEXT_START, is this correct?
We will use generic platform as Anup suggested. I'll send our patch soon.
When FW_PIC=y (default), set CONFIG_SPL_OPENSBI_LOAD_ADDR to 0x44000000
in U-boot should be able to run OpenSBI.
> - Moving forward I built rz/five as part of generic override successfully
> - But when I try and build the u-boot with fw_dynamic.bin I get the
> below errors:
> - Image 'main-section' is missing external blobs and is
> non-functional: opensbi
> - Image 'main-section' has faked external blobs and is
> non-functional: fw_dynamic.bin
> - Ignoring the warning and still flashing the image I dont get any
> output from opensbi.
The error message looks like the fw_dynamic.bin is not copied to top
directory of U-boot, so a dummy one is created.
The load/entry addresses and binary of OpenSBI can be observed by using
`dtc u-boot.itb`.
> Am I missing something here?
>
> Cheers,
> Prabhakar
>
Best regards,
Peter Lin
next prev parent reply other threads:[~2022-11-28 9:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 18:20 [PATCH v2 0/7] Add support for Renesas RZ/Five SoC Prabhakar
2022-11-11 18:20 ` [PATCH v2 1/7] lib: utils: serial: Add Renesas SCIF driver Prabhakar
2022-11-15 7:30 ` Bin Meng
2022-11-15 17:33 ` Lad, Prabhakar
2022-11-17 7:52 ` Bin Meng
2022-11-18 13:07 ` Lad, Prabhakar
2022-11-20 11:59 ` Bin Meng
2022-11-29 12:13 ` Lad, Prabhakar
2022-11-11 18:21 ` [PATCH v2 2/7] lib: utils: serial: Add FDT driver for Renesas SCIF Prabhakar
2022-11-11 18:21 ` [PATCH v2 3/7] platform: andes/ae350: Split platform.h header file Prabhakar
2022-11-11 18:21 ` [PATCH v2 4/7] lib: utils/irqchip: Add compatible string for Andestech NCEPLIC100 Prabhakar
2022-11-15 11:30 ` Anup Patel
2022-11-15 14:06 ` Bin Meng
2022-11-11 18:21 ` [PATCH v2 5/7] platform: Add Renesas RZ/Five initial support Prabhakar
2022-11-15 11:44 ` Anup Patel
2022-11-16 15:53 ` Lad, Prabhakar
2022-11-28 9:23 ` Yu-Chien Peter Lin [this message]
2022-11-28 3:37 ` Anup Patel
2022-11-11 18:21 ` [PATCH v2 6/7] scripts: Add Renesas RZ/Five to platform list in the binary archive script Prabhakar
2022-11-11 18:21 ` [PATCH v2 7/7] docs: platform: Add documentation for Renesas RZ/Five SoC Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4R9+NxyafIbka8Q@APC323 \
--to=peterlin@andestech.com \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.