All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: Hangbin Liu <liuhangbin@gmail.com>, stephen@networkplumber.org
Cc: netdev@vger.kernel.org, Guillaume Nault <gnault@redhat.com>,
	David Ahern <dsahern@kernel.org>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2] ip: fix return value for rtnl_talk failures
Date: Mon, 28 Nov 2022 09:40:45 +0200	[thread overview]
Message-ID: <Y4Rl/fhdhgWwccwv@shredder> (raw)
In-Reply-To: <20221108124344.192326-1-liuhangbin@gmail.com>

On Tue, Nov 08, 2022 at 08:43:44PM +0800, Hangbin Liu wrote:
> Since my last commit "rtnetlink: add new function rtnl_echo_talk()" we
> return the kernel rtnl exit code directly, which breaks some kernel
> selftest checking. As there are still a lot of tests checking -2 as the
> error return value, to keep backward compatibility, let's keep using
> -2 for all the rtnl return values.
> 
> Reported-by: Ido Schimmel <idosch@idosch.org>
> Fixes: 6c09257f1bf6 ("rtnetlink: add new function rtnl_echo_talk()")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

Stephen, I believe this patch was missed. It appears as "New, archived"
in patchwork:
https://patchwork.kernel.org/project/netdevbpf/patch/20221108124344.192326-1-liuhangbin@gmail.com/

Can you please apply it? It fixes regressions in kernel selftests that
use iproute2 with blamed commit. See:

https://lore.kernel.org/netdev/Y2oWDRIIR6gjkM4a@shredder/

Thanks

      parent reply	other threads:[~2022-11-28  7:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 12:43 [PATCH iproute2] ip: fix return value for rtnl_talk failures Hangbin Liu
2022-11-09  8:17 ` Ido Schimmel
2022-11-28  7:40 ` Ido Schimmel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4Rl/fhdhgWwccwv@shredder \
    --to=idosch@idosch.org \
    --cc=dsahern@kernel.org \
    --cc=gnault@redhat.com \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.