All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Alexander Lobakin <alexandr.lobakin@intel.com>
Cc: Coco Li <lixiaoyan@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	David Ahern <dsahern@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Michael Chan <michael.chan@broadcom.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] bnxt: Use generic HBH removal helper in tx path
Date: Mon, 28 Nov 2022 11:54:50 +0200	[thread overview]
Message-ID: <Y4SFaovDiiKp1Bw/@unreal> (raw)
In-Reply-To: <20221123164159.485728-1-alexandr.lobakin@intel.com>

On Wed, Nov 23, 2022 at 05:41:59PM +0100, Alexander Lobakin wrote:
> From: Coco Li <lixiaoyan@google.com>
> Date: Tue, 22 Nov 2022 15:27:40 -0800
> 
> > Eric Dumazet implemented Big TCP that allowed bigger TSO/GRO packet sizes
> > for IPv6 traffic. See patch series:
> > 'commit 89527be8d8d6 ("net: add IFLA_TSO_{MAX_SIZE|SEGS} attributes")'
> > 
> > This reduces the number of packets traversing the networking stack and
> > should usually improves performance. However, it also inserts a
> > temporary Hop-by-hop IPv6 extension header.
> > 
> > Using the HBH header removal method in the previous path, the extra header
> > be removed in bnxt drivers to allow it to send big TCP packets (bigger
> > TSO packets) as well.
> > 
> > If bnxt folks could help with testing this patch on the driver (as I
> > don't have access to one) that would be wonderful. Thank you!
> > 
> > Tested:
> > Compiled locally
> 
> Please mark "potential" patches with 'RFC'. Then, if/when you get a
> 'Tested-by:', you can spin a "true" v1.

We are getting ton of patches which are "compiled-only".
I won't be such strict with them as long as they stated clearly about it.

Thanks

  reply	other threads:[~2022-11-28  9:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22 23:27 [PATCH net-next 1/2] IPv6/GRO: generic helper to remove temporary HBH/jumbo header in driver Coco Li
2022-11-22 23:27 ` [PATCH net-next 2/2] bnxt: Use generic HBH removal helper in tx path Coco Li
2022-11-23 16:41   ` Alexander Lobakin
2022-11-28  9:54     ` Leon Romanovsky [this message]
2022-11-23 16:38 ` [PATCH net-next 1/2] IPv6/GRO: generic helper to remove temporary HBH/jumbo header in driver Alexander Lobakin
2022-11-23 18:44   ` Alexander Lobakin
  -- strict thread matches above, loose matches on Subject: below --
2022-11-22 19:32 Coco Li
2022-11-22 19:32 ` [PATCH net-next 2/2] bnxt: Use generic HBH removal helper in tx path Coco Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4SFaovDiiKp1Bw/@unreal \
    --to=leon@kernel.org \
    --cc=alexandr.lobakin@intel.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lixiaoyan@google.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.