From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78262C4332F for ; Mon, 28 Nov 2022 18:28:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wUrQK2m6u60ZAanE7UXqz7zkvr5vKaKYquBIPKaJ6KQ=; b=HjLQUxekUqe9Ek JxVMhBrwoFgOlsGAUcmfOCwBgA5R5ytWqk6aBru7KecxCSaytcgEPOBkti9XgNFmoHUyCIfFQODZD k8xlIe2hmXGahmlMiufEHutX2suFkG+UbfeiCtifbcyWDZMvXNK5vkCrWr+7nRe7WDqRey5BgmPf1 4sGMPZ7C78sd7PoAY+VtqMYAFCM+UCv6P/byN08VSKNeCuRPGR+nVX3Ke8G9xtLKwmLNSZ039K38R uD82/sNH1fAx3k/7qYL8G0IbyZJo5ZRpcGIUwyQ57/0doaQ2XluG7J8a5EibULW3ozaoFpf9UZ3zn FwE2DWOA/GNLAC50tcTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oziqM-003ZfM-GY; Mon, 28 Nov 2022 18:27:02 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oziHN-003FYw-69 for linux-arm-kernel@lists.infradead.org; Mon, 28 Nov 2022 17:50:55 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 885D761300 for ; Mon, 28 Nov 2022 17:50:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43E89C433D6; Mon, 28 Nov 2022 17:50:50 +0000 (UTC) Date: Mon, 28 Nov 2022 17:50:48 +0000 From: Catalin Marinas To: Ard Biesheuvel Cc: linux-arm-kernel@lists.infradead.org, will@kernel.org Subject: Re: [PATCH] arm64: mm: Align PGDs to at least 64 bytes Message-ID: References: <20221122165618.2453224-1-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221122165618.2453224-1-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221128_095053_300097_70513D19 X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 22, 2022 at 05:56:18PM +0100, Ard Biesheuvel wrote: > My copy of the ARM ARM (DDI 0487G.a) no longer describes the 64 byte G.a is nearly two years old. You may want to upgrade to H.a ;). > minimum alignment of root page tables as being conditional on whether > 52-bit physical addressing is supported and enabled, even though I seem > to remember that this was the case formerly (and our code suggests the > same). The wording in the ARM ARM implies that it's only needed if we go beyond 48 bits for the base address: A translation table must be aligned to the size of the table, except that when using a translation table base address larger than 48 bits the minimum alignment of a table containing fewer than eight entries is 64 bytes. But I'm fine with the patch, always forcing the 64 byte alignment. With the 'max_t' instead of 'max' (or whatever solves Anshuman's error): Acked-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel