From: Andrew Lunn <andrew@lunn.ch>
To: Daniil Tatianin <d-tatianin@yandex-team.ru>
Cc: netdev@vger.kernel.org, Michal Kubecek <mkubecek@suse.cz>,
yc-core@yandex-team.ru, lvc-project@linuxtesting.org
Subject: Re: [PATCH v2 1/3] net/ethtool/ioctl: return -EOPNOTSUPP if we have no phy stats
Date: Wed, 30 Nov 2022 01:20:50 +0100 [thread overview]
Message-ID: <Y4ah4jM8HN5BV4Ed@lunn.ch> (raw)
In-Reply-To: <20221129103801.498149-2-d-tatianin@yandex-team.ru>
On Tue, Nov 29, 2022 at 01:37:59PM +0300, Daniil Tatianin wrote:
> It's not very useful to copy back an empty ethtool_stats struct and
> return 0 if we didn't actually have any stats. This also allows for
> further simplification of this function in the future commits.
>
> Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next parent reply other threads:[~2022-11-30 0:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221129103801.498149-1-d-tatianin@yandex-team.ru>
[not found] ` <20221129103801.498149-2-d-tatianin@yandex-team.ru>
2022-11-30 0:20 ` Andrew Lunn [this message]
[not found] ` <20221129103801.498149-3-d-tatianin@yandex-team.ru>
2022-11-30 0:21 ` [PATCH v2 2/3] net/ethtool/ioctl: remove if n_stats checks from ethtool_get_phy_stats Andrew Lunn
[not found] ` <20221129103801.498149-4-d-tatianin@yandex-team.ru>
2022-11-30 0:25 ` [PATCH v2 3/3] net/ethtool/ioctl: split ethtool_get_phy_stats into multiple helpers Andrew Lunn
2022-11-30 2:39 ` Jakub Kicinski
2022-11-30 13:51 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4ah4jM8HN5BV4Ed@lunn.ch \
--to=andrew@lunn.ch \
--cc=d-tatianin@yandex-team.ru \
--cc=lvc-project@linuxtesting.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.