From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0335DC4167B for ; Wed, 30 Nov 2022 00:20:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230192AbiK3AU5 (ORCPT ); Tue, 29 Nov 2022 19:20:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229652AbiK3AU4 (ORCPT ); Tue, 29 Nov 2022 19:20:56 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B5C16D4B9 for ; Tue, 29 Nov 2022 16:20:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=nkB0gpWvFUi+ElvQRrbjKMhqLqqAqAWXbY7mu7xVXX8=; b=lS2cg0d/zEgUOXMJgOOo48OBZw I2x/Z9ID2iEeUtreFLoshiSLhxokmpnqz7038DtwR3OcFxzR/jrRjdn9/MxNB/93mntlRP5TALReA LsgJS1YGawCVaT3UNIFNETBnzQEL3t4XrBoInxkMnlanmebd4YnlyOTprCQDP3Wd3IVk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1p0AqI-003vBe-Pc; Wed, 30 Nov 2022 01:20:50 +0100 Date: Wed, 30 Nov 2022 01:20:50 +0100 From: Andrew Lunn To: Daniil Tatianin Cc: netdev@vger.kernel.org, Michal Kubecek , yc-core@yandex-team.ru, lvc-project@linuxtesting.org Subject: Re: [PATCH v2 1/3] net/ethtool/ioctl: return -EOPNOTSUPP if we have no phy stats Message-ID: References: <20221129103801.498149-1-d-tatianin@yandex-team.ru> <20221129103801.498149-2-d-tatianin@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221129103801.498149-2-d-tatianin@yandex-team.ru> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 29, 2022 at 01:37:59PM +0300, Daniil Tatianin wrote: > It's not very useful to copy back an empty ethtool_stats struct and > return 0 if we didn't actually have any stats. This also allows for > further simplification of this function in the future commits. > > Signed-off-by: Daniil Tatianin Reviewed-by: Andrew Lunn Andrew