From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5090C46467 for ; Wed, 30 Nov 2022 11:06:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669806409; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=4VWDUAjdyamMgsuRcmZBwLntdBRPSQsZxbCleNh/qKc=; b=bNqffzxdcmheW/vO4HYw6Uv864IYft0KH7qezu0bMlLJ9lwA8n1uhiQ2SL1T+tMKL/Ha6R k46tGHQPaBi3s73tQejS3F8zlSMOeXyQ/5YjO8A3JCPGAcXjyy/vnshOMCNbhiDspnGF2A mq5VBCAESLRe7eyyPV/ZkwHUj0HnHP8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-436-WojxmUdPNauC5lgMyCNRAQ-1; Wed, 30 Nov 2022 06:06:46 -0500 X-MC-Unique: WojxmUdPNauC5lgMyCNRAQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C585B101A54E; Wed, 30 Nov 2022 11:06:44 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id AA7131121314; Wed, 30 Nov 2022 11:06:40 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5908719465A2; Wed, 30 Nov 2022 11:06:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2D79719465A0 for ; Wed, 30 Nov 2022 11:06:29 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 12D1D200B404; Wed, 30 Nov 2022 11:06:24 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BB3D2027064 for ; Wed, 30 Nov 2022 11:06:24 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E3FF485A588 for ; Wed, 30 Nov 2022 11:06:23 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-424-pkGOxUI6MkS5Vartx2FCgA-1; Wed, 30 Nov 2022 06:06:20 -0500 X-MC-Unique: pkGOxUI6MkS5Vartx2FCgA-1 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2CFE661B2D; Wed, 30 Nov 2022 11:06:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46DF5C433D6; Wed, 30 Nov 2022 11:06:18 +0000 (UTC) Date: Wed, 30 Nov 2022 06:06:17 -0500 From: Sasha Levin To: Keith Busch Message-ID: References: <20221123124234.265396-1-sashal@kernel.org> <20221123124234.265396-25-sashal@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Subject: Re: [dm-devel] [PATCH AUTOSEL 5.15 25/31] dm-log-writes: set dma_alignment limit in io_hints X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Mike Snitzer , linux-kernel@vger.kernel.org, stable@vger.kernel.org, dm-devel@redhat.com, agk@redhat.com Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" On Wed, Nov 23, 2022 at 08:04:37AM -0700, Keith Busch wrote: >On Wed, Nov 23, 2022 at 07:42:26AM -0500, Sasha Levin wrote: >> From: Keith Busch >> >> [ Upstream commit 50a893359cd2643ee1afc96eedc9e7084cab49fa ] >> >> This device mapper needs bio vectors to be sized and memory aligned to >> the logical block size. Set the minimum required queue limit >> accordingly. > >Probably harmless, but these dm dma_alignment patches are not needed >prior to 6.0. I'll drop them on all <6.0 kernels, thanks! -- Thanks, Sasha -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 197B5C433FE for ; Wed, 30 Nov 2022 11:06:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229861AbiK3LGW (ORCPT ); Wed, 30 Nov 2022 06:06:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230148AbiK3LGU (ORCPT ); Wed, 30 Nov 2022 06:06:20 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A02A2BB0C; Wed, 30 Nov 2022 03:06:19 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 29B6361AFA; Wed, 30 Nov 2022 11:06:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46DF5C433D6; Wed, 30 Nov 2022 11:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669806378; bh=jujPM3njpPJca9XyPNWIYHk/sCCLKUbMoZq4AAx7fTM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a50kGSlgXYNoRl+R156zaFySm/onNpTsabkLsIaGm28rQNBsLSelMN2MjTcXLUs9a 9K6zBT0qgiElSmoCe65gTQzq/w9jfWBeg3ss1JRP+Mocqm5wCZjd6B7GMi0U8b9i3K KahJppYSkZNjoC+sD3H/KJuUD1MG5ufy5fGEhJvgQ+5nle3N7QV1wmKlv6lCho/YNM m56LY4wAK1RycTVxzmqOmTPJ20COzGgUbxM02ziAHFL9Eh2JV/j62WiRJeowimd4z5 WMehrPenc7WTyYWnzd+jw9VxuaLx6ve7V2nnbIWozDa7h/FM4X25Hu3VBs/tyQB9ru xlNBiPducPVXg== Date: Wed, 30 Nov 2022 06:06:17 -0500 From: Sasha Levin To: Keith Busch Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Mike Snitzer , Jens Axboe , agk@redhat.com, dm-devel@redhat.com Subject: Re: [PATCH AUTOSEL 5.15 25/31] dm-log-writes: set dma_alignment limit in io_hints Message-ID: References: <20221123124234.265396-1-sashal@kernel.org> <20221123124234.265396-25-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Nov 23, 2022 at 08:04:37AM -0700, Keith Busch wrote: >On Wed, Nov 23, 2022 at 07:42:26AM -0500, Sasha Levin wrote: >> From: Keith Busch >> >> [ Upstream commit 50a893359cd2643ee1afc96eedc9e7084cab49fa ] >> >> This device mapper needs bio vectors to be sized and memory aligned to >> the logical block size. Set the minimum required queue limit >> accordingly. > >Probably harmless, but these dm dma_alignment patches are not needed >prior to 6.0. I'll drop them on all <6.0 kernels, thanks! -- Thanks, Sasha