From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B93EC433FE for ; Wed, 30 Nov 2022 11:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vXIoMji1w6Q51MgTNKgY0vvonOItq/i2u0i0nAisvU0=; b=4CUeMHJH4emi3S 93dRDAWz/kjhKs2EqNmSvR+UuUPWbKQC18R5jzxYYT2rJ/egqp0qS8lHTIsNw8eCjHspWrRBrerJu r0v/8+EWZSs619mtKtDufa9YZ7t208Pb2NNpifJ7s56iXUQiJceu1fKOue/uru74o7DtB4u6ng5V5 AvGPHiWb/dTUDJa7NjATmChSfCCx3oNCM7jrSjKtQb5q5ZGRkbStphSCxH5zJ29zj/wGdmZvHTyg5 /EEP2hk1L7ey99L9Lk8A+hDTvvIuWsnar+0jSPHevmflYKUEdAJsQ95Fxe2FlzsGm0W0Y9r4TSXqx y5xWVupehlmOAUYb2oSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0LcS-00FwLj-KD; Wed, 30 Nov 2022 11:51:16 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0LcO-00FwIx-WC for linux-arm-kernel@lists.infradead.org; Wed, 30 Nov 2022 11:51:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SeprZaUCrg6YMDUQVxQrpsNw17qVCxSs694K/ikvslE=; b=DnY+sP3ETdi6+M6MeNzJpuGBM6 3Q6mYmwux7sT7CkxU9xl+BfJZD/l/CWSP7TJ89V45p9uBVpPkx93KWoG0cc3IYXfqmRGy6/3sjbb2 78COo1ggeQOWJ9vPx3R3AMbUuwvnNPNDg8DA8Wn0cCOnN3ofoQnrNeLi2AjJnyFeBHVx8YX2IsuR+ 3P1WvrTUBxgG1MZWTnEC21nXmOBjnawcYVt7AfFcfeJ1MJ242SqdZYl8tm1PRWZQbayVKpSx/BaSs y2BgKvCaFE3O/hRa66dxpbjWwiBKoPLlN/07nYrBtiDMqM2mwRX64X7uXf/sM9qJS6/C7lpYN12V0 t/t3DfAA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35498) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p0Lc5-0001fp-7X; Wed, 30 Nov 2022 11:50:53 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1p0Lc2-0002TM-C2; Wed, 30 Nov 2022 11:50:50 +0000 Date: Wed, 30 Nov 2022 11:50:50 +0000 From: "Russell King (Oracle)" To: Clark Wang Cc: "peppe.cavallaro@st.com" , "alexandre.torgue@foss.st.com" , "joabreu@synopsys.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "mcoquelin.stm32@gmail.com" , "andrew@lunn.ch" , "hkallweit1@gmail.com" , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] net: phylink: add sync flag mac_ready to fix resume issue with WoL enabled Message-ID: References: <20221130111148.1064475-1-xiaoning.wang@nxp.com> <20221130111148.1064475-2-xiaoning.wang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221130_035113_059009_3815E7AF X-CRM114-Status: GOOD ( 24.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBOb3YgMzAsIDIwMjIgYXQgMTE6MzI6MDlBTSArMDAwMCwgQ2xhcmsgV2FuZyB3cm90 ZToKPiBIaSBSdXNzZWxsLAo+IAo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZy b206IFJ1c3NlbGwgS2luZyA8bGludXhAYXJtbGludXgub3JnLnVrPgo+ID4gU2VudDogMjAyMuW5 tDEx5pyIMzDml6UgMTk6MjQKPiA+IFRvOiBDbGFyayBXYW5nIDx4aWFvbmluZy53YW5nQG54cC5j b20+Cj4gPiBDYzogcGVwcGUuY2F2YWxsYXJvQHN0LmNvbTsgYWxleGFuZHJlLnRvcmd1ZUBmb3Nz LnN0LmNvbTsKPiA+IGpvYWJyZXVAc3lub3BzeXMuY29tOyBkYXZlbUBkYXZlbWxvZnQubmV0OyBl ZHVtYXpldEBnb29nbGUuY29tOwo+ID4ga3ViYUBrZXJuZWwub3JnOyBwYWJlbmlAcmVkaGF0LmNv bTsgbWNvcXVlbGluLnN0bTMyQGdtYWlsLmNvbTsKPiA+IGFuZHJld0BsdW5uLmNoOyBoa2FsbHdl aXQxQGdtYWlsLmNvbTsgbmV0ZGV2QHZnZXIua2VybmVsLm9yZzsKPiA+IGxpbnV4LXN0bTMyQHN0 LW1kLW1haWxtYW4uc3Rvcm1yZXBseS5jb207Cj4gPiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcKPiA+IFN1YmplY3Q6IFJl OiBbUEFUQ0ggMS8yXSBuZXQ6IHBoeWxpbms6IGFkZCBzeW5jIGZsYWcgbWFjX3JlYWR5IHRvIGZp eCByZXN1bWUKPiA+IGlzc3VlIHdpdGggV29MIGVuYWJsZWQKPiA+IAo+ID4gT24gV2VkLCBOb3Yg MzAsIDIwMjIgYXQgMDc6MTE6NDdQTSArMDgwMCwgQ2xhcmsgV2FuZyB3cm90ZToKPiA+ID4gSXNz dWUgd2UgbWV0Ogo+ID4gPiBPbiBzb21lIHBsYXRmb3JtcywgbWFjIGNhbm5vdCB3b3JrIGFmdGVy IHJlc3VtZWQgZnJvbSB0aGUgc3VzcGVuZCB3aXRoCj4gPiA+IFdvTCBlbmFibGVkLgo+ID4gPgo+ ID4gPiBUaGUgY2F1c2Ugb2YgdGhlIGlzc3VlOgo+ID4gPiAxLiBwaHlsaW5rX3Jlc29sdmUoKSBp cyBpbiBhIHdvcmtxdWV1ZSB3aGljaCB3aWxsIG5vdCBiZSBleGVjdXRlZCBpbW1lZGlhdGVseS4K PiA+ID4gICAgVGhpcyBpcyB0aGUgY2FsbCBzZXF1ZW5jZToKPiA+ID4gICAgICAgIHBoeWxpbmtf cmVzb2x2ZSgpLT5waHlsaW5rX2xpbmtfdXAoKS0+cGwtPm1hY19vcHMtPm1hY19saW5rX3VwKCkK PiA+ID4gICAgRm9yIHN0bW1hYyBkcml2ZXIsIG1hY19saW5rX3VwKCkgd2lsbCBzZXQgdGhlIGNv cnJlY3Qgc3BlZWQvZHVwbGV4Li4uCj4gPiA+ICAgIHZhbHVlcyB3aGljaCBhcmUgZnJvbSBsaW5r X3N0YXRlLgo+ID4gPiAyLiBJbiBzdG1tYWNfcmVzdW1lKCksIGl0IHdpbGwgY2FsbCBzdG1tYWNf aHdfc2V0dXAoKSBhZnRlciBjYWxsZWQgdGhlCj4gPiA+ICAgIHBoeWxpbmtfcmVzdW1lKCkuIHN0 bW1hY19jb3JlX2luaXQoKSBpcyBjYWxsZWQgaW4gZnVuY3Rpb24KPiA+ID4gc3RtbWFjX2h3X3Nl dHVwKCksCj4gPiAKPiA+IC4uLiBhbmQgdGhhdCBpcyB3aGVyZSB0aGUgcHJvYmxlbSBpcy4gRG9u J3QgY2FsbCBwaHlsaW5rX3Jlc3VtZSgpIGJlZm9yZSB5b3VyCj4gPiBoYXJkd2FyZSBpcyByZWFk eSB0byBzZWUgYSBsaW5rLXVwIGV2ZW50Lgo+IAo+IFRoYW5rIHlvdSB2ZXJ5IG11Y2ggZm9yIHlv dXIgcmVwbHkhCj4gCj4gWW91IGFyZSByaWdodC4KPiAKPiBIb3dldmVyLCBzdG1tYWMgcmVxdWly ZXMgUlhDIHRvIGhhdmUgYSBjbG9jayBpbnB1dCB3aGVuIHBlcmZvcm1pbmcgYSByZXNldChpbiBz dG1tYWNfaHdfc2V0dXAoKSkuIE9uIG91ciBib2FyZCwgUlhDIGlzIHByb3ZpZGVkIGJ5IHRoZSBw aHkuCj4gCj4gSW4gV29MIG1vZGUsIHRoaXMgaXMgbm90IGEgcHJvYmxlbSwgYmVjYXVzZSB0aGUg cGh5IHdpbGwgbm90IGJlIGRvd24gd2hlbiBzdXNwZW5kLiBSWEMgd2lsbCBrZWVwIG91dHB1dC4g QnV0IGluIG5vcm1hbCBzdXNwZW5kKHdpdGhvdXQgV29MKSwgdGhlIHBoeSB3aWxsIGJlIGRvd24s IHdoaWNoIGRvZXMgbm90IGd1YXJhbnRlZSB0aGUgb3V0cHV0IG9mIHRoZSBSWEMgb2YgdGhlIHBo eS4gVGhlcmVmb3JlLCB0aGUgcHJldmlvdXMgY29kZSB3aWxsIGNhbGwgcGh5bGlua19yZXN1bWUo KSBiZWZvcmUgc3RtbWFjX2h3X3NldHVwKCkuCgpJIHRoaW5rIHdlIG5lZWQgcGh5bGlua19waHlf cmVzdW1lKCkgd2hpY2ggc3RtbWFjIGNhbiB1c2UgdG8gcmVzdW1lIHRoZQpQSFkgd2l0aG91dCBy ZXN1bWluZyBwaHlsaW5rLCBhc3N1bWluZyB0aGF0IHdpbGwgb3V0cHV0IHRoZSBSWEMuIFdoaWNo ClBIWSBkcml2ZXIocykgYXJlIHVzZWQgd2l0aCBzdG1tYWM/CgotLSAKUk1LJ3MgUGF0Y2ggc3lz dGVtOiBodHRwczovL3d3dy5hcm1saW51eC5vcmcudWsvZGV2ZWxvcGVyL3BhdGNoZXMvCkZUVFAg aXMgaGVyZSEgNDBNYnBzIGRvd24gMTBNYnBzIHVwLiBEZWNlbnQgY29ubmVjdGl2aXR5IGF0IGxh c3QhCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDA12C433FE for ; Wed, 30 Nov 2022 11:51:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230024AbiK3Lvi (ORCPT ); Wed, 30 Nov 2022 06:51:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234475AbiK3LvQ (ORCPT ); Wed, 30 Nov 2022 06:51:16 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EA597B4E9; Wed, 30 Nov 2022 03:51:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SeprZaUCrg6YMDUQVxQrpsNw17qVCxSs694K/ikvslE=; b=DnY+sP3ETdi6+M6MeNzJpuGBM6 3Q6mYmwux7sT7CkxU9xl+BfJZD/l/CWSP7TJ89V45p9uBVpPkx93KWoG0cc3IYXfqmRGy6/3sjbb2 78COo1ggeQOWJ9vPx3R3AMbUuwvnNPNDg8DA8Wn0cCOnN3ofoQnrNeLi2AjJnyFeBHVx8YX2IsuR+ 3P1WvrTUBxgG1MZWTnEC21nXmOBjnawcYVt7AfFcfeJ1MJ242SqdZYl8tm1PRWZQbayVKpSx/BaSs y2BgKvCaFE3O/hRa66dxpbjWwiBKoPLlN/07nYrBtiDMqM2mwRX64X7uXf/sM9qJS6/C7lpYN12V0 t/t3DfAA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35498) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p0Lc5-0001fp-7X; Wed, 30 Nov 2022 11:50:53 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1p0Lc2-0002TM-C2; Wed, 30 Nov 2022 11:50:50 +0000 Date: Wed, 30 Nov 2022 11:50:50 +0000 From: "Russell King (Oracle)" To: Clark Wang Cc: "peppe.cavallaro@st.com" , "alexandre.torgue@foss.st.com" , "joabreu@synopsys.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "mcoquelin.stm32@gmail.com" , "andrew@lunn.ch" , "hkallweit1@gmail.com" , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] net: phylink: add sync flag mac_ready to fix resume issue with WoL enabled Message-ID: References: <20221130111148.1064475-1-xiaoning.wang@nxp.com> <20221130111148.1064475-2-xiaoning.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 30, 2022 at 11:32:09AM +0000, Clark Wang wrote: > Hi Russell, > > > -----Original Message----- > > From: Russell King > > Sent: 2022年11月30日 19:24 > > To: Clark Wang > > Cc: peppe.cavallaro@st.com; alexandre.torgue@foss.st.com; > > joabreu@synopsys.com; davem@davemloft.net; edumazet@google.com; > > kuba@kernel.org; pabeni@redhat.com; mcoquelin.stm32@gmail.com; > > andrew@lunn.ch; hkallweit1@gmail.com; netdev@vger.kernel.org; > > linux-stm32@st-md-mailman.stormreply.com; > > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org > > Subject: Re: [PATCH 1/2] net: phylink: add sync flag mac_ready to fix resume > > issue with WoL enabled > > > > On Wed, Nov 30, 2022 at 07:11:47PM +0800, Clark Wang wrote: > > > Issue we met: > > > On some platforms, mac cannot work after resumed from the suspend with > > > WoL enabled. > > > > > > The cause of the issue: > > > 1. phylink_resolve() is in a workqueue which will not be executed immediately. > > > This is the call sequence: > > > phylink_resolve()->phylink_link_up()->pl->mac_ops->mac_link_up() > > > For stmmac driver, mac_link_up() will set the correct speed/duplex... > > > values which are from link_state. > > > 2. In stmmac_resume(), it will call stmmac_hw_setup() after called the > > > phylink_resume(). stmmac_core_init() is called in function > > > stmmac_hw_setup(), > > > > ... and that is where the problem is. Don't call phylink_resume() before your > > hardware is ready to see a link-up event. > > Thank you very much for your reply! > > You are right. > > However, stmmac requires RXC to have a clock input when performing a reset(in stmmac_hw_setup()). On our board, RXC is provided by the phy. > > In WoL mode, this is not a problem, because the phy will not be down when suspend. RXC will keep output. But in normal suspend(without WoL), the phy will be down, which does not guarantee the output of the RXC of the phy. Therefore, the previous code will call phylink_resume() before stmmac_hw_setup(). I think we need phylink_phy_resume() which stmmac can use to resume the PHY without resuming phylink, assuming that will output the RXC. Which PHY driver(s) are used with stmmac? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!