From: Cyril Hrubis <chrubis@suse.cz>
To: Teo Couprie Diaz <teo.coupriediaz@arm.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [RFC PATCH 0/1] brk: use direct syscalls
Date: Wed, 30 Nov 2022 14:15:06 +0100 [thread overview]
Message-ID: <Y4dXWopbsqbyDZMF@yuki> (raw)
In-Reply-To: <448cb776-770d-3235-c0d9-3c9005663790@arm.com>
Hi!
> >> WDYT about .test_variants? In that case it'd be tested also on musl
> >> or any platform where it's implemented.
> > I would got for it, that way we would test both the kernel implemntation
> > and that libc does something sensible, e.g. returns error.
> >
> I'm still quite new to LTP, so I might be understanding things wrong.
>
> My understanding of your conversation is that you're suggesting using
> the .test_variants to have one version of the tests going through the
> libc wrappers as usual, eventually skipping the test with TCONF if the
> libc wrapper does not implement the syscall, and one version which would
> be the the direct syscall I am suggesting in this patch.
>
> Would that be correct ? If so it does make sense to me, I could try
> implementing that.
Yes, exactly this.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-11-30 13:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 9:15 [LTP] [RFC PATCH 0/1] brk: use direct syscalls Teo Couprie Diaz
2022-11-28 9:15 ` [LTP] [RFC PATCH 1/1] syscalls/brk: use direct syscall Teo Couprie Diaz
2022-11-28 19:30 ` [LTP] [RFC PATCH 0/1] brk: use direct syscalls Petr Vorel
2022-11-29 13:09 ` Cyril Hrubis
2022-11-29 13:36 ` Petr Vorel
2022-11-29 13:40 ` Cyril Hrubis
2022-11-30 13:03 ` Teo Couprie Diaz
2022-11-30 13:15 ` Cyril Hrubis [this message]
2022-11-30 14:22 ` Teo Couprie Diaz
2022-11-30 12:49 ` Teo Couprie Diaz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4dXWopbsqbyDZMF@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=teo.coupriediaz@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.