All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: Monitor commands related to display server passwords
Date: Wed, 30 Nov 2022 13:29:56 +0000	[thread overview]
Message-ID: <Y4da1Ble0mkqNvZW@redhat.com> (raw)
In-Reply-To: <87h6yglgke.fsf@pond.sub.org>

On Wed, Nov 30, 2022 at 02:25:53PM +0100, Markus Armbruster wrote:
> Daniel P. Berrangé <berrange@redhat.com> writes:

> > In 6.0 I introduced support for 'password-secret' to SPICE and VNC
> > command line.
> >
> > I don't know why, but I only deprecated 'password' in SPICE and
> > not in VNC.
> 
> I figure you mean
> 
>     ``-spice password=string`` (since 6.0)
>     ''''''''''''''''''''''''''''''''''''''
> 
>     This option is insecure because the SPICE password remains visible in
>     the process listing. This is replaced by the new ``password-secret``
>     option which lets the password be securely provided on the command
>     line using a ``secret`` object instance.
> 
> and -vnc password=...
> 
> There's also -iscsi password=..., and possibly more.

Oh, iSCSI already has password-secret=, so yeah, we should
deprecate the old way there too.

Basically I want nothing in QMP/CLI to accept passwords,
everything must use the 'secret' objects.


> > I didn't wire up any QMP commands todo live password changes. If
> > the display was already configured with 'password-secret', you
> > could delete and re-create the existing named secret object
> > using object-add/object-del, since we fetch the secret value
> > on every auth check.
> 
> Is this behavior documented?

I don't believe so


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2022-11-30 13:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30  8:02 Monitor commands related to display server passwords Markus Armbruster
2022-11-30  9:03 ` Daniel P. Berrangé
2022-11-30 13:25   ` Markus Armbruster
2022-11-30 13:29     ` Daniel P. Berrangé [this message]
2022-12-01  6:48       ` Markus Armbruster
2022-12-01  9:20   ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4da1Ble0mkqNvZW@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.