All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Yi Liu <yi.l.liu@intel.com>
Cc: Anthony Krowiak <akrowiak@linux.ibm.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Bagas Sanjaya <bagasdotme@gmail.com>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Chaitanya Kulkarni <chaitanyak@nvidia.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Daniel Jordan <daniel.m.jordan@oracle.com>,
	David Gibson <david@gibson.dropbear.id.au>,
	Eric Auger <eric.auger@redhat.com>,
	Eric Farman <farman@linux.ibm.com>,
	iommu@lists.linux.dev, Jason Wang <jasowang@redhat.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Jason Herne <jjherne@linux.ibm.com>,
	Joao Martins <joao.m.martins@oracle.com>,
	Kevin Tian <kevin.tian@intel.com>,
	kvm@vger.kernel.org, Lixiao Yang <lixiao.yang@intel.com>,
	Matthew Rosato <mjrosato@linux.ibm.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Nicolin Chen <nicolinc@nvidia.com>,
	Halil Pasic <pasic@linux.ibm.com>,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>,
	Yu He <yu.he@intel.com>, Keqian Zhu <zhukeqian1@huawei.com>
Subject: Re: [PATCH v6 19/19] iommufd: Add a selftest
Date: Wed, 30 Nov 2022 09:51:02 -0400	[thread overview]
Message-ID: <Y4dfxp19/OVreNoU@nvidia.com> (raw)
In-Reply-To: <48c89797-600b-48db-8df4-fc6674561417@intel.com>

On Wed, Nov 30, 2022 at 03:14:32PM +0800, Yi Liu wrote:
> On 2022/11/30 04:29, Jason Gunthorpe wrote:
> > Cover the essential functionality of the iommufd with a directed test from
> > userspace. This aims to achieve reasonable functional coverage using the
> > in-kernel self test framework.
> > 
> > A second test does a failure injection sweep of the success paths to study
> > error unwind behaviors.
> > 
> > This allows achieving high coverage of the corner cases in pages.c.
> > 
> > Tested-by: Nicolin Chen <nicolinc@nvidia.com>
> > Tested-by: Matthew Rosato <mjrosato@linux.ibm.com> # s390
> > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> > Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> 
> with sudo echo 4 > /proc/sys/vm/nr_hugepages
>
> Both "sudo ./iommufd" and "sudo ./iommufd_fail_nth" works on my
> side.

It is interesting that you need that, my VM doesn't, I wonder what the
difference is

Thanks,
Jason

  reply	other threads:[~2022-11-30 13:51 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29 20:29 [PATCH v6 00/19] IOMMUFD Generic interface Jason Gunthorpe
2022-11-29 20:29 ` Jason Gunthorpe
2022-11-29 20:29 ` [PATCH v6 01/19] iommu: Add IOMMU_CAP_ENFORCE_CACHE_COHERENCY Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-29 20:29 ` [PATCH v6 02/19] iommu: Add device-centric DMA ownership interfaces Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-29 20:29 ` [PATCH v6 03/19] interval-tree: Add a utility to iterate over spans in an interval tree Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-29 20:29 ` [PATCH v6 04/19] scripts/kernel-doc: support EXPORT_SYMBOL_NS_GPL() with -export Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-29 20:29 ` [PATCH v6 05/19] iommufd: Document overview of iommufd Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-29 20:29 ` [PATCH v6 06/19] iommufd: File descriptor, context, kconfig and makefiles Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-30 14:02   ` Eric Auger
2022-12-04 10:58   ` Binbin Wu
2022-11-29 20:29 ` [PATCH v6 07/19] kernel/user: Allow user::locked_vm to be usable for iommufd Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-29 20:42   ` Michael S. Tsirkin
2022-11-29 20:48     ` Jason Gunthorpe
2022-11-29 21:10       ` Michael S. Tsirkin
2022-11-29 20:29 ` [PATCH v6 08/19] iommufd: PFN handling for iopt_pages Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-12-05 15:58   ` Binbin Wu
2022-12-06 20:53     ` Jason Gunthorpe
2022-12-06 12:36   ` Binbin Wu
2022-12-06 20:57     ` Jason Gunthorpe
2022-11-29 20:29 ` [PATCH v6 09/19] iommufd: Algorithms for PFN storage Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-29 20:29 ` [PATCH v6 10/19] iommufd: Data structure to provide IOVA to PFN mapping Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-29 20:29 ` [PATCH v6 11/19] iommufd: IOCTLs for the io_pagetable Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-30 14:04   ` Eric Auger
2022-11-29 20:29 ` [PATCH v6 12/19] iommufd: Add a HW pagetable object Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-29 20:29 ` [PATCH v6 13/19] iommufd: Add kAPI toward external drivers for physical devices Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-29 20:29 ` [PATCH v6 14/19] iommufd: Add kAPI toward external drivers for kernel access Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-29 20:29 ` [PATCH v6 15/19] iommufd: vfio container FD ioctl compatibility Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-29 20:29 ` [PATCH v6 16/19] iommufd: Add kernel support for testing iommufd Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2024-04-22  7:27   ` Geert Uytterhoeven
2024-04-22 11:54     ` Jason Gunthorpe
2024-04-22 12:48       ` Geert Uytterhoeven
2024-04-22 12:50         ` Jason Gunthorpe
2022-11-29 20:29 ` [PATCH v6 17/19] iommufd: Add some fault injection points Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-29 20:29 ` [PATCH v6 18/19] iommufd: Add additional invariant assertions Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-29 20:29 ` [PATCH v6 19/19] iommufd: Add a selftest Jason Gunthorpe
2022-11-29 20:29   ` Jason Gunthorpe
2022-11-30  7:14   ` Yi Liu
2022-11-30 13:51     ` Jason Gunthorpe [this message]
2022-11-30 17:18       ` Eric Auger
2022-12-01  0:13         ` Jason Gunthorpe
2022-12-01  4:59         ` Yi Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4dfxp19/OVreNoU@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=akrowiak@linux.ibm.com \
    --cc=alex.williamson@redhat.com \
    --cc=bagasdotme@gmail.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=chaitanyak@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=corbet@lwn.net \
    --cc=daniel.m.jordan@oracle.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=eric.auger@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=iommu@lists.linux.dev \
    --cc=jasowang@redhat.com \
    --cc=jean-philippe@linaro.org \
    --cc=jjherne@linux.ibm.com \
    --cc=joao.m.martins@oracle.com \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=lixiao.yang@intel.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=mst@redhat.com \
    --cc=nicolinc@nvidia.com \
    --cc=pasic@linux.ibm.com \
    --cc=schnelle@linux.ibm.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=yi.l.liu@intel.com \
    --cc=yu.he@intel.com \
    --cc=zhukeqian1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.