From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70094C4332F for ; Wed, 30 Nov 2022 14:36:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbiK3Of3 (ORCPT ); Wed, 30 Nov 2022 09:35:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230080AbiK3Oel (ORCPT ); Wed, 30 Nov 2022 09:34:41 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEFA62A706 for ; Wed, 30 Nov 2022 06:34:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=jf+6ElMC07B1X+dyU/GaRA8cEU8jwQkLG3EIjvOdDzw=; b=UGDjA88GfuDosMz3altRORgLU1 hImKpHxCJx+UPwBb2inZaDv0Cpv/DAqRCZSCkiQ8/+pO96i2pzFAbfXCcckwgqgqkbPNpPvYYXUwb uVrHBy5+eeuP+K0qIMuPGWcw1VDt9ZsGz59ahyXvCzhyhAWAZin+GNGkMa05IMySP3uQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1p0NUQ-003xYe-Nk; Wed, 30 Nov 2022 14:51:06 +0100 Date: Wed, 30 Nov 2022 14:51:06 +0100 From: Andrew Lunn To: Jakub Kicinski Cc: Daniil Tatianin , netdev@vger.kernel.org, Michal Kubecek , yc-core@yandex-team.ru, lvc-project@linuxtesting.org Subject: Re: [PATCH v2 3/3] net/ethtool/ioctl: split ethtool_get_phy_stats into multiple helpers Message-ID: References: <20221129103801.498149-1-d-tatianin@yandex-team.ru> <20221129103801.498149-4-d-tatianin@yandex-team.ru> <20221129183938.496850f7@kicinski-fedora-PC1C0HJN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221129183938.496850f7@kicinski-fedora-PC1C0HJN> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 29, 2022 at 06:39:41PM -0800, Jakub Kicinski wrote: > On Wed, 30 Nov 2022 01:25:06 +0100 Andrew Lunn wrote: > > On Tue, Nov 29, 2022 at 01:38:01PM +0300, Daniil Tatianin wrote: > > > So that it's easier to follow and make sense of the branching and > > > various conditions. > > > > > > Stats retrieval has been split into two separate functions > > > ethtool_get_phy_stats_phydev & ethtool_get_phy_stats_ethtool. > > > The former attempts to retrieve the stats using phydev & phy_ops, while > > > the latter uses ethtool_ops. > > > > > > Actual n_stats validation & array allocation has been moved into a new > > > ethtool_vzalloc_stats_array helper. > > > > > > This also fixes a potential NULL dereference of > > > ops->get_ethtool_phy_stats where it was getting called in an else branch > > > unconditionally without making sure it was actually present. > > > > > > Found by Linux Verification Center (linuxtesting.org) with the SVACE > > > static analysis tool. > > > > > > Signed-off-by: Daniil Tatianin > > > > Reviewed-by: Andrew Lunn > > FWIW the patches did not hit the list, once again :/ Daniil, how are you sending the patches? git send-email? You might need to contact postmaster@vger.kernel.org and ask if they have logs records of why it is discarding your emails. Andrew