All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: zhang.songyi@zte.com.cn
Cc: dm-devel@redhat.com, snitzer@kernel.org,
	linux-kernel@vger.kernel.org, agk@redhat.com
Subject: Re: [dm-devel] [PATCH linux-next] dm: remove redundant sz variable
Date: Wed, 30 Nov 2022 11:25:47 -0500	[thread overview]
Message-ID: <Y4eEC48JUauAZuio@redhat.com> (raw)
In-Reply-To: <202211301535171577902@zte.com.cn>

On Wed, Nov 30 2022 at  2:35P -0500,
zhang.songyi@zte.com.cn <zhang.songyi@zte.com.cn> wrote:

> From: zhang songyi <zhang.songyi@zte.com.cn>
> 
> Return value from hst_status() directly instead of taking
> this in another redundant variable.
> 
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> ---
>  drivers/md/dm-ps-historical-service-time.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/md/dm-ps-historical-service-time.c b/drivers/md/dm-ps-historical-service-time.c
> index 1d82c95d323d..6c8e83ad2662 100644
> --- a/drivers/md/dm-ps-historical-service-time.c
> +++ b/drivers/md/dm-ps-historical-service-time.c
> @@ -237,7 +237,6 @@ static void hst_destroy(struct path_selector *ps)
>  static int hst_status(struct path_selector *ps, struct dm_path *path,
>                      status_type_t type, char *result, unsigned int maxlen)
>  {
> -       unsigned int sz = 0;
>         struct path_info *pi;
> 
>         if (!path) {
> @@ -261,7 +260,7 @@ static int hst_status(struct path_selector *ps, struct dm_path *path,
>                 }
>         }
> 
> -       return sz;
> +       return 0;
>  }
> 
>  static int hst_add_path(struct path_selector *ps, struct dm_path *path,
> --
> 2.15.2
> 

NACK

This sz variable is needed! (see DMEMIT)

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: zhang.songyi@zte.com.cn
Cc: agk@redhat.com, snitzer@kernel.org, dm-devel@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next] dm: remove redundant sz variable
Date: Wed, 30 Nov 2022 11:25:47 -0500	[thread overview]
Message-ID: <Y4eEC48JUauAZuio@redhat.com> (raw)
In-Reply-To: <202211301535171577902@zte.com.cn>

On Wed, Nov 30 2022 at  2:35P -0500,
zhang.songyi@zte.com.cn <zhang.songyi@zte.com.cn> wrote:

> From: zhang songyi <zhang.songyi@zte.com.cn>
> 
> Return value from hst_status() directly instead of taking
> this in another redundant variable.
> 
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> ---
>  drivers/md/dm-ps-historical-service-time.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/md/dm-ps-historical-service-time.c b/drivers/md/dm-ps-historical-service-time.c
> index 1d82c95d323d..6c8e83ad2662 100644
> --- a/drivers/md/dm-ps-historical-service-time.c
> +++ b/drivers/md/dm-ps-historical-service-time.c
> @@ -237,7 +237,6 @@ static void hst_destroy(struct path_selector *ps)
>  static int hst_status(struct path_selector *ps, struct dm_path *path,
>                      status_type_t type, char *result, unsigned int maxlen)
>  {
> -       unsigned int sz = 0;
>         struct path_info *pi;
> 
>         if (!path) {
> @@ -261,7 +260,7 @@ static int hst_status(struct path_selector *ps, struct dm_path *path,
>                 }
>         }
> 
> -       return sz;
> +       return 0;
>  }
> 
>  static int hst_add_path(struct path_selector *ps, struct dm_path *path,
> --
> 2.15.2
> 

NACK

This sz variable is needed! (see DMEMIT)


  reply	other threads:[~2022-11-30 17:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30  7:35 [dm-devel] [PATCH linux-next] dm: remove redundant sz variable zhang.songyi
2022-11-30  7:35 ` zhang.songyi
2022-11-30 16:25 ` Mike Snitzer [this message]
2022-11-30 16:25   ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4eEC48JUauAZuio@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=snitzer@kernel.org \
    --cc=zhang.songyi@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.