* [dm-devel] [PATCH linux-next] dm: remove redundant sz variable
@ 2022-11-30 7:35 ` zhang.songyi
0 siblings, 0 replies; 4+ messages in thread
From: zhang.songyi @ 2022-11-30 7:35 UTC (permalink / raw)
To: agk; +Cc: dm-devel, snitzer, linux-kernel, zhang.songyi
From: zhang songyi <zhang.songyi@zte.com.cn>
Return value from hst_status() directly instead of taking
this in another redundant variable.
Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
---
drivers/md/dm-ps-historical-service-time.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/dm-ps-historical-service-time.c b/drivers/md/dm-ps-historical-service-time.c
index 1d82c95d323d..6c8e83ad2662 100644
--- a/drivers/md/dm-ps-historical-service-time.c
+++ b/drivers/md/dm-ps-historical-service-time.c
@@ -237,7 +237,6 @@ static void hst_destroy(struct path_selector *ps)
static int hst_status(struct path_selector *ps, struct dm_path *path,
status_type_t type, char *result, unsigned int maxlen)
{
- unsigned int sz = 0;
struct path_info *pi;
if (!path) {
@@ -261,7 +260,7 @@ static int hst_status(struct path_selector *ps, struct dm_path *path,
}
}
- return sz;
+ return 0;
}
static int hst_add_path(struct path_selector *ps, struct dm_path *path,
--
2.15.2
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH linux-next] dm: remove redundant sz variable
@ 2022-11-30 7:35 ` zhang.songyi
0 siblings, 0 replies; 4+ messages in thread
From: zhang.songyi @ 2022-11-30 7:35 UTC (permalink / raw)
To: agk; +Cc: snitzer, dm-devel, linux-kernel, zhang.songyi
From: zhang songyi <zhang.songyi@zte.com.cn>
Return value from hst_status() directly instead of taking
this in another redundant variable.
Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
---
drivers/md/dm-ps-historical-service-time.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/dm-ps-historical-service-time.c b/drivers/md/dm-ps-historical-service-time.c
index 1d82c95d323d..6c8e83ad2662 100644
--- a/drivers/md/dm-ps-historical-service-time.c
+++ b/drivers/md/dm-ps-historical-service-time.c
@@ -237,7 +237,6 @@ static void hst_destroy(struct path_selector *ps)
static int hst_status(struct path_selector *ps, struct dm_path *path,
status_type_t type, char *result, unsigned int maxlen)
{
- unsigned int sz = 0;
struct path_info *pi;
if (!path) {
@@ -261,7 +260,7 @@ static int hst_status(struct path_selector *ps, struct dm_path *path,
}
}
- return sz;
+ return 0;
}
static int hst_add_path(struct path_selector *ps, struct dm_path *path,
--
2.15.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [dm-devel] [PATCH linux-next] dm: remove redundant sz variable
2022-11-30 7:35 ` zhang.songyi
@ 2022-11-30 16:25 ` Mike Snitzer
-1 siblings, 0 replies; 4+ messages in thread
From: Mike Snitzer @ 2022-11-30 16:25 UTC (permalink / raw)
To: zhang.songyi; +Cc: dm-devel, snitzer, linux-kernel, agk
On Wed, Nov 30 2022 at 2:35P -0500,
zhang.songyi@zte.com.cn <zhang.songyi@zte.com.cn> wrote:
> From: zhang songyi <zhang.songyi@zte.com.cn>
>
> Return value from hst_status() directly instead of taking
> this in another redundant variable.
>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> ---
> drivers/md/dm-ps-historical-service-time.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/md/dm-ps-historical-service-time.c b/drivers/md/dm-ps-historical-service-time.c
> index 1d82c95d323d..6c8e83ad2662 100644
> --- a/drivers/md/dm-ps-historical-service-time.c
> +++ b/drivers/md/dm-ps-historical-service-time.c
> @@ -237,7 +237,6 @@ static void hst_destroy(struct path_selector *ps)
> static int hst_status(struct path_selector *ps, struct dm_path *path,
> status_type_t type, char *result, unsigned int maxlen)
> {
> - unsigned int sz = 0;
> struct path_info *pi;
>
> if (!path) {
> @@ -261,7 +260,7 @@ static int hst_status(struct path_selector *ps, struct dm_path *path,
> }
> }
>
> - return sz;
> + return 0;
> }
>
> static int hst_add_path(struct path_selector *ps, struct dm_path *path,
> --
> 2.15.2
>
NACK
This sz variable is needed! (see DMEMIT)
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH linux-next] dm: remove redundant sz variable
@ 2022-11-30 16:25 ` Mike Snitzer
0 siblings, 0 replies; 4+ messages in thread
From: Mike Snitzer @ 2022-11-30 16:25 UTC (permalink / raw)
To: zhang.songyi; +Cc: agk, snitzer, dm-devel, linux-kernel
On Wed, Nov 30 2022 at 2:35P -0500,
zhang.songyi@zte.com.cn <zhang.songyi@zte.com.cn> wrote:
> From: zhang songyi <zhang.songyi@zte.com.cn>
>
> Return value from hst_status() directly instead of taking
> this in another redundant variable.
>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> ---
> drivers/md/dm-ps-historical-service-time.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/md/dm-ps-historical-service-time.c b/drivers/md/dm-ps-historical-service-time.c
> index 1d82c95d323d..6c8e83ad2662 100644
> --- a/drivers/md/dm-ps-historical-service-time.c
> +++ b/drivers/md/dm-ps-historical-service-time.c
> @@ -237,7 +237,6 @@ static void hst_destroy(struct path_selector *ps)
> static int hst_status(struct path_selector *ps, struct dm_path *path,
> status_type_t type, char *result, unsigned int maxlen)
> {
> - unsigned int sz = 0;
> struct path_info *pi;
>
> if (!path) {
> @@ -261,7 +260,7 @@ static int hst_status(struct path_selector *ps, struct dm_path *path,
> }
> }
>
> - return sz;
> + return 0;
> }
>
> static int hst_add_path(struct path_selector *ps, struct dm_path *path,
> --
> 2.15.2
>
NACK
This sz variable is needed! (see DMEMIT)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-30 17:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-30 7:35 [dm-devel] [PATCH linux-next] dm: remove redundant sz variable zhang.songyi
2022-11-30 7:35 ` zhang.songyi
2022-11-30 16:25 ` [dm-devel] " Mike Snitzer
2022-11-30 16:25 ` Mike Snitzer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.