From: Sean Christopherson <seanjc@google.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org,
"Guilherme G . Piccoli" <gpiccoli@igalia.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH v4 4/4] x86/reboot: Disable SVM, not just VMX, when stopping CPUs
Date: Wed, 30 Nov 2022 23:38:57 +0000 [thread overview]
Message-ID: <Y4fpkUUeu0s86Sh4@google.com> (raw)
In-Reply-To: <20221130233650.1404148-5-seanjc@google.com>
On Wed, Nov 30, 2022, Sean Christopherson wrote:
> Disable SVM and more importantly force GIF=1 when halting a CPU or
> rebooting the machine. Similar to VMX, SVM allows software to block
> INITs via CLGI, and thus can be problematic for a crash/reboot. The
> window for failure is smaller with SVM as INIT is only blocked while
> GIF=0, i.e. between CLGI and STGI, but the window does exist.
>
> Fixes: fba4f472b33a ("x86/reboot: Turn off KVM when halting a CPU")
> Cc: stable@vger.kernel
Argh, forgot the .org, and of course my scripts then failed to filter out the
address.
next prev parent reply other threads:[~2022-11-30 23:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 23:36 [PATCH v4 0/4] x86/crash: Fix double NMI shootdown bug Sean Christopherson
2022-11-30 23:36 ` [PATCH v4 1/4] x86/crash: Disable virt in core NMI crash handler to avoid double shootdown Sean Christopherson
2022-11-30 23:36 ` [PATCH v4 2/4] x86/virt: Force GIF=1 prior to disabling SVM (for reboot flows) Sean Christopherson
2022-12-01 22:46 ` Andrew Cooper
2022-12-01 23:04 ` Sean Christopherson
2022-12-02 0:08 ` Andrew Cooper
2022-11-30 23:36 ` [PATCH v4 3/4] x86/reboot: Disable virtualization in an emergency if SVM is supported Sean Christopherson
2022-11-30 23:36 ` [PATCH v4 4/4] x86/reboot: Disable SVM, not just VMX, when stopping CPUs Sean Christopherson
2022-11-30 23:38 ` Sean Christopherson [this message]
2022-12-02 17:10 ` [PATCH v4 0/4] x86/crash: Fix double NMI shootdown bug Thomas Gleixner
2023-01-28 0:05 ` Sean Christopherson
2023-01-28 14:52 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4fpkUUeu0s86Sh4@google.com \
--to=seanjc@google.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gpiccoli@igalia.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.