From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2C8B1C36; Thu, 1 Dec 2022 13:29:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1669901370; x=1701437370; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=uzYyfpe5ovcmHtziruShrAihFDRO3ojyXNM6UnYgYzM=; b=iUpH7ehJxKBw+C0mn8E/TY8cIR2T+gknuBqbUfD9ABYvupb80gGapdf9 o8oRtiKloSR3Ns+Vp8U12KwSLPWghEb2WJG73KOBHtGRJ60E71PqSyvBf GRbKAwgcsCSYLdlaMOL4OEBezMXIYsvrMlV1renGiMB2sotdfd5/R9b7u NuGMvARe6+VWqHw4TInxFQq/b5c7wJE8S3Pg09QM6r3N9AnOEu6I5V9/Z RDen2VdYJyhtCdThUmrDbhFezpAwd3XqmR+dH3VrKo55vVhq1KiXPuJUF 6ygoIA21ykDjjeJFzt0gno4+Mg5iCpWCBoqgQkXHF/mHux0OfTprCAwec g==; X-IronPort-AV: E=Sophos;i="5.96,209,1665471600"; d="scan'208";a="125998122" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 01 Dec 2022 06:29:21 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 1 Dec 2022 06:29:09 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Thu, 1 Dec 2022 06:29:01 -0700 Date: Thu, 1 Dec 2022 13:28:42 +0000 From: Conor Dooley To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= CC: Alexandre Belloni , Alexandre Torgue , , "Douglas Anderson" , Thierry Reding , Satya Priya , Pavel Machek , "Guenter Roeck" , Marijn Suijten , Nobuhiro Iwamatsu , , , "Jerome Brunet" , , "Florian Fainelli" , Samuel Holland , "Sean Anderson" , Kevin Hilman , Bartosz Golaszewski , Michal Simek , , Hammer Hsieh , , Chen-Yu Tsai , Matthias Kaehlcke , "Broadcom internal kernel review list" , NXP Linux Team , Orson Zhai , , , "Pengutronix Kernel Team" , Martin Blumenstingl , Ray Jui , "Sascha Hauer" , Steven Rostedt , "Stephen Boyd" , , Fabrice Gasnier , , , Baolin Wang , Paul Walmsley , Matthias Brugger , , , Scott Branden , Bjorn Andersson , Nicolas Ferre , "Michael Walle" , Palmer Dabbelt , "Masami Hiramatsu" , Maxime Coquelin , Chunyan Zhang , Shawn Guo , Claudiu Beznea Subject: Re: [PATCH v2 00/11] pwm: Allow .get_state to fail Message-ID: References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221201131907.bmrenldnua7uaeab@pengutronix.de> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221201131907.bmrenldnua7uaeab@pengutronix.de> On Thu, Dec 01, 2022 at 02:19:07PM +0100, Uwe Kleine-König wrote: > Hello Conor, > > On Thu, Dec 01, 2022 at 11:11:51AM +0000, Conor Dooley wrote: > > TL;DR, I quite like the ability to return an error and not mislead the > > caller. > > Is this an Ack? It is if you want it to be! I didn't really feel qualified to do so which is why I gave some context etc. I did check out the callsites for the non-void returning op, and it looked good to me, so sure, why not: Acked-by: Conor Dooley Thanks, Conor. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 241C9C43217 for ; Thu, 1 Dec 2022 13:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ATr8N58aEitLCl2hp6Ud8zRX8drPUgYbb6El6UlTo8w=; b=fGr6HG9yafMKoJ NW/RTMiVWf/+qRnkUTvTKHnnEtrM4JnVnKeW1wvIkm8rRdFnBtbAUy6s5CYJVDc2R01dQAsNNBPGh FWwlk1Sl3oJ8syletZ+qLjxq6aHis3ofGkDoe8YciX8hHn10NtoSD9TJRuK6TYquTs/GkJ0KffNoW l5gEimMw1dxgceDgihUWU64hF01XocAcclrpWsPasWFy23FG076zg+LguCKO7JYPl5+LLwcZXwumJ UQbyFwYbjAL8zhedGPdETCqGs9aKWzq2TU01AklB7QaiwXSp14PbNfmrH/Y7QRHP8zjqqoOBNmZVy oTviojP7zaCrjzjGswJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0jd2-007hH5-6b; Thu, 01 Dec 2022 13:29:28 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0jcx-007hEc-FN; Thu, 01 Dec 2022 13:29:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1669901363; x=1701437363; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=uzYyfpe5ovcmHtziruShrAihFDRO3ojyXNM6UnYgYzM=; b=rZxb5+hfjDXxjtZu937XvgDrAjM36daIPnVrCIzmd93mSr2H5Kc5O2mH WXY59NT9pt5M8Gv5e0hUGGIYl64nJ48mtaCwYhf6rpwTub4m/nE/gp1YN 6cl2xVV0NZFsHkAeR4vvkV1j4BJEITOAdu6ozOmOwNRbBjhLx+iCV6os8 fbbq+86k282FAse3AIBr30+pBsXYRi+rOcbBvQieX+WF0IicJftcDWXNw Kyh6TbTtadQI7xwfLZGGP2g5Yo+lqgRsCwKKa34xij9RU/mZkfDk5ejV7 92/rR3cxTsGxr6Qhyrc068eKcPGra2tB2YdWgOfMCYFauCxZ+xnI5df3+ A==; X-IronPort-AV: E=Sophos;i="5.96,209,1665471600"; d="scan'208";a="125998122" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 01 Dec 2022 06:29:21 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 1 Dec 2022 06:29:09 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Thu, 1 Dec 2022 06:29:01 -0700 Date: Thu, 1 Dec 2022 13:28:42 +0000 From: Conor Dooley To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= CC: Alexandre Belloni , Alexandre Torgue , , "Douglas Anderson" , Thierry Reding , Satya Priya , Pavel Machek , "Guenter Roeck" , Marijn Suijten , Nobuhiro Iwamatsu , , , "Jerome Brunet" , , "Florian Fainelli" , Samuel Holland , "Sean Anderson" , Kevin Hilman , Bartosz Golaszewski , Michal Simek , , Hammer Hsieh , , Chen-Yu Tsai , Matthias Kaehlcke , "Broadcom internal kernel review list" , NXP Linux Team , Orson Zhai , , , "Pengutronix Kernel Team" , Martin Blumenstingl , Ray Jui , "Sascha Hauer" , Steven Rostedt , "Stephen Boyd" , , Fabrice Gasnier , , , Baolin Wang , Paul Walmsley , Matthias Brugger , , , Scott Branden , Bjorn Andersson , Nicolas Ferre , "Michael Walle" , Palmer Dabbelt , "Masami Hiramatsu" , Maxime Coquelin , Chunyan Zhang , Shawn Guo , Claudiu Beznea Subject: Re: [PATCH v2 00/11] pwm: Allow .get_state to fail Message-ID: References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221201131907.bmrenldnua7uaeab@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221201131907.bmrenldnua7uaeab@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221201_052923_604677_ABC41199 X-CRM114-Status: GOOD ( 10.51 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Thu, Dec 01, 2022 at 02:19:07PM +0100, Uwe Kleine-K=F6nig wrote: > Hello Conor, > = > On Thu, Dec 01, 2022 at 11:11:51AM +0000, Conor Dooley wrote: > > TL;DR, I quite like the ability to return an error and not mislead the > > caller. > = > Is this an Ack? It is if you want it to be! I didn't really feel qualified to do so which is why I gave some context etc. I did check out the callsites for the non-void returning op, and it looked good to me, so sure, why not: Acked-by: Conor Dooley Thanks, Conor. _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBCE4C47088 for ; Thu, 1 Dec 2022 13:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RckbHdT0TzghzYRz/jeR/0orAtfeRkcNwvlE2egXZ/Q=; b=xb4Ai5jepLBQCD 1/1CGGxW3vYCgJ7ZiFecvFG+gYoTUH7QQ8ETt4K/EGBHifo8xBX+tjdP1Hzf6CLwGz71QZyEPjuHD /Y6IJYRa/BzSjK/XM6Led0cOvzwrElxqjf4TQiFPV494qSBhr16Wr+BkveRrfHhrxOKTd9pVvzsbZ 9mmJPF0A6ecvJSgCwMeouGe6yI8oULPi3CVw5QEIzYVC4FYXbCYa3gtow0vvazKyPhDaHc4LWu9lT RmqcMnpvXzQ5Wt6X8F2Gk0nhYasmxjlo/AXPqUCITXsdQ02WL63qFmX2k34jFZ/0tEAZiVH/6JSqZ jQb13q074emKAIi/L6FA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0jd4-007hI9-S1; Thu, 01 Dec 2022 13:29:30 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0jcx-007hEc-FN; Thu, 01 Dec 2022 13:29:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1669901363; x=1701437363; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=uzYyfpe5ovcmHtziruShrAihFDRO3ojyXNM6UnYgYzM=; b=rZxb5+hfjDXxjtZu937XvgDrAjM36daIPnVrCIzmd93mSr2H5Kc5O2mH WXY59NT9pt5M8Gv5e0hUGGIYl64nJ48mtaCwYhf6rpwTub4m/nE/gp1YN 6cl2xVV0NZFsHkAeR4vvkV1j4BJEITOAdu6ozOmOwNRbBjhLx+iCV6os8 fbbq+86k282FAse3AIBr30+pBsXYRi+rOcbBvQieX+WF0IicJftcDWXNw Kyh6TbTtadQI7xwfLZGGP2g5Yo+lqgRsCwKKa34xij9RU/mZkfDk5ejV7 92/rR3cxTsGxr6Qhyrc068eKcPGra2tB2YdWgOfMCYFauCxZ+xnI5df3+ A==; X-IronPort-AV: E=Sophos;i="5.96,209,1665471600"; d="scan'208";a="125998122" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 01 Dec 2022 06:29:21 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 1 Dec 2022 06:29:09 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Thu, 1 Dec 2022 06:29:01 -0700 Date: Thu, 1 Dec 2022 13:28:42 +0000 From: Conor Dooley To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= CC: Alexandre Belloni , Alexandre Torgue , , "Douglas Anderson" , Thierry Reding , Satya Priya , Pavel Machek , "Guenter Roeck" , Marijn Suijten , Nobuhiro Iwamatsu , , , "Jerome Brunet" , , "Florian Fainelli" , Samuel Holland , "Sean Anderson" , Kevin Hilman , Bartosz Golaszewski , Michal Simek , , Hammer Hsieh , , Chen-Yu Tsai , Matthias Kaehlcke , "Broadcom internal kernel review list" , NXP Linux Team , Orson Zhai , , , "Pengutronix Kernel Team" , Martin Blumenstingl , Ray Jui , "Sascha Hauer" , Steven Rostedt , "Stephen Boyd" , , Fabrice Gasnier , , , Baolin Wang , Paul Walmsley , Matthias Brugger , , , Scott Branden , Bjorn Andersson , Nicolas Ferre , "Michael Walle" , Palmer Dabbelt , "Masami Hiramatsu" , Maxime Coquelin , Chunyan Zhang , Shawn Guo , Claudiu Beznea Subject: Re: [PATCH v2 00/11] pwm: Allow .get_state to fail Message-ID: References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221201131907.bmrenldnua7uaeab@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221201131907.bmrenldnua7uaeab@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221201_052923_604677_ABC41199 X-CRM114-Status: GOOD ( 10.51 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Thu, Dec 01, 2022 at 02:19:07PM +0100, Uwe Kleine-K=F6nig wrote: > Hello Conor, > = > On Thu, Dec 01, 2022 at 11:11:51AM +0000, Conor Dooley wrote: > > TL;DR, I quite like the ability to return an error and not mislead the > > caller. > = > Is this an Ack? It is if you want it to be! I didn't really feel qualified to do so which is why I gave some context etc. I did check out the callsites for the non-void returning op, and it looked good to me, so sure, why not: Acked-by: Conor Dooley Thanks, Conor. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF1E8C43217 for ; Thu, 1 Dec 2022 13:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H4zp+w5ZKwcInT3OP3qV+Qm4QcWKwVoL/dq1xzqrfuc=; b=d1M6BAhTqaqe8l IZTVSQqICslBgpQKwlGvVAt3oKWORJh7UQVuza0BcXPQxp2MXUjnXJM7paLvc/d51dJTeg46h6I4m qf1puT6BFh6pmEP4/K5MKur+FyelgrnPLWJhdXniz2ht9CuU671WOZIGT8FMe0Z1XwXt8MtQukY4d Pn0GQ6hnwr837vFlJxK9+7Srd0IysDNM3jHI9CKXBrOLh38LBUgHyp8U8A5DXCcHZUcwogT8ZcO5z YeMLjG733NsY7NUht9QhpDi2kDvOkFG4UbmGXbt4qWpXz8WYvlOtrlZPs25B4/b/aHrCdR0Ny9XP9 kNqN3EcXmmrfIc0skSKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0jd2-007hHL-Rq; Thu, 01 Dec 2022 13:29:28 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0jcx-007hEc-FN; Thu, 01 Dec 2022 13:29:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1669901363; x=1701437363; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=uzYyfpe5ovcmHtziruShrAihFDRO3ojyXNM6UnYgYzM=; b=rZxb5+hfjDXxjtZu937XvgDrAjM36daIPnVrCIzmd93mSr2H5Kc5O2mH WXY59NT9pt5M8Gv5e0hUGGIYl64nJ48mtaCwYhf6rpwTub4m/nE/gp1YN 6cl2xVV0NZFsHkAeR4vvkV1j4BJEITOAdu6ozOmOwNRbBjhLx+iCV6os8 fbbq+86k282FAse3AIBr30+pBsXYRi+rOcbBvQieX+WF0IicJftcDWXNw Kyh6TbTtadQI7xwfLZGGP2g5Yo+lqgRsCwKKa34xij9RU/mZkfDk5ejV7 92/rR3cxTsGxr6Qhyrc068eKcPGra2tB2YdWgOfMCYFauCxZ+xnI5df3+ A==; X-IronPort-AV: E=Sophos;i="5.96,209,1665471600"; d="scan'208";a="125998122" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 01 Dec 2022 06:29:21 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 1 Dec 2022 06:29:09 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Thu, 1 Dec 2022 06:29:01 -0700 Date: Thu, 1 Dec 2022 13:28:42 +0000 From: Conor Dooley To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= CC: Alexandre Belloni , Alexandre Torgue , , "Douglas Anderson" , Thierry Reding , Satya Priya , Pavel Machek , "Guenter Roeck" , Marijn Suijten , Nobuhiro Iwamatsu , , , "Jerome Brunet" , , "Florian Fainelli" , Samuel Holland , "Sean Anderson" , Kevin Hilman , Bartosz Golaszewski , Michal Simek , , Hammer Hsieh , , Chen-Yu Tsai , Matthias Kaehlcke , "Broadcom internal kernel review list" , NXP Linux Team , Orson Zhai , , , "Pengutronix Kernel Team" , Martin Blumenstingl , Ray Jui , "Sascha Hauer" , Steven Rostedt , "Stephen Boyd" , , Fabrice Gasnier , , , Baolin Wang , Paul Walmsley , Matthias Brugger , , , Scott Branden , Bjorn Andersson , Nicolas Ferre , "Michael Walle" , Palmer Dabbelt , "Masami Hiramatsu" , Maxime Coquelin , Chunyan Zhang , Shawn Guo , Claudiu Beznea Subject: Re: [PATCH v2 00/11] pwm: Allow .get_state to fail Message-ID: References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221201131907.bmrenldnua7uaeab@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221201131907.bmrenldnua7uaeab@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221201_052923_604677_ABC41199 X-CRM114-Status: GOOD ( 10.51 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Dec 01, 2022 at 02:19:07PM +0100, Uwe Kleine-K=F6nig wrote: > Hello Conor, > = > On Thu, Dec 01, 2022 at 11:11:51AM +0000, Conor Dooley wrote: > > TL;DR, I quite like the ability to return an error and not mislead the > > caller. > = > Is this an Ack? It is if you want it to be! I didn't really feel qualified to do so which is why I gave some context etc. I did check out the callsites for the non-void returning op, and it looked good to me, so sure, why not: Acked-by: Conor Dooley Thanks, Conor. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D9B9C43217 for ; Thu, 1 Dec 2022 13:36:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C5D3C10E5E3; Thu, 1 Dec 2022 13:36:34 +0000 (UTC) X-Greylist: delayed 424 seconds by postgrey-1.36 at gabe; Thu, 01 Dec 2022 13:36:27 UTC Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by gabe.freedesktop.org (Postfix) with ESMTPS id BF61610E5E3 for ; Thu, 1 Dec 2022 13:36:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1669901787; x=1701437787; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=uzYyfpe5ovcmHtziruShrAihFDRO3ojyXNM6UnYgYzM=; b=EZwV+ahF73ZkA508WO0T629QX+ZNvCmSr9Vtl+JZyAf1hU291bJ5+ooF toratOF24b1YKyJHOcilpqRgGZtUiWjLd/5BlhWTjcKDAWQXI3zAEMENd sPO4iJbW0CkeEuvGL+O9Eoi9wY1XN4GKOiPDluFoIA3NJ9L8AX0E0zzme UXzaKiXzHl7stoywDJ1q7fJ4UqO3SZn2KzKX4n0D0S4Lz0GXdNEWfbCOq gDJx63kS/efgAIEH5SIuxo5Y0Jbz5PJ+kOma+QPJdsKPPDuY8EN2sfW1E EKRkPFVLhyZiNBpc7+OOJ2094lB33+Q4ydhgTosvJs5oAaylaVDLYwVG4 Q==; X-IronPort-AV: E=Sophos;i="5.96,209,1665471600"; d="scan'208";a="125998122" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 01 Dec 2022 06:29:21 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 1 Dec 2022 06:29:09 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Thu, 1 Dec 2022 06:29:01 -0700 Date: Thu, 1 Dec 2022 13:28:42 +0000 From: Conor Dooley To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v2 00/11] pwm: Allow .get_state to fail Message-ID: References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221201131907.bmrenldnua7uaeab@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221201131907.bmrenldnua7uaeab@pengutronix.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Alexandre Torgue , dri-devel@lists.freedesktop.org, Nicolas Ferre , Thierry Reding , Satya Priya , Pavel Machek , Guenter Roeck , Marijn Suijten , Nobuhiro Iwamatsu , linux-stm32@st-md-mailman.stormreply.com, linux-leds@vger.kernel.org, Jerome Brunet , chrome-platform@lists.linux.dev, Florian Fainelli , Samuel Holland , Sean Anderson , Kevin Hilman , Bartosz Golaszewski , Michal Simek , linux-riscv@lists.infradead.org, Hammer Hsieh , linux-rockchip@lists.infradead.org, Chen-Yu Tsai , Matthias Kaehlcke , Broadcom internal kernel review list , NXP Linux Team , Orson Zhai , linux-sunxi@lists.linux.dev, linux-pwm@vger.kernel.org, Maxime Coquelin , Martin Blumenstingl , Ray Jui , Sascha Hauer , Steven Rostedt , Stephen Boyd , linux-gpio@vger.kernel.org, Fabrice Gasnier , linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, Baolin Wang , Paul Walmsley , Matthias Brugger , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Scott Branden , Bjorn Andersson , Douglas Anderson , Michael Walle , Palmer Dabbelt , Masami Hiramatsu , Pengutronix Kernel Team , Chunyan Zhang , Shawn Guo , Claudiu Beznea Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Dec 01, 2022 at 02:19:07PM +0100, Uwe Kleine-König wrote: > Hello Conor, > > On Thu, Dec 01, 2022 at 11:11:51AM +0000, Conor Dooley wrote: > > TL;DR, I quite like the ability to return an error and not mislead the > > caller. > > Is this an Ack? It is if you want it to be! I didn't really feel qualified to do so which is why I gave some context etc. I did check out the callsites for the non-void returning op, and it looked good to me, so sure, why not: Acked-by: Conor Dooley Thanks, Conor.