From: Andrew Lunn <andrew@lunn.ch>
To: Zeng Heng <zengheng4@huawei.com>,
Yang Yingliang <yangyingliang@huawei.com>
Cc: f.fainelli@gmail.com, pabeni@redhat.com, kuba@kernel.org,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
hkallweit1@gmail.com, netdev@vger.kernel.org,
liwei391@huawei.com
Subject: Re: [PATCH] net: mdio: fix unbalanced fwnode reference count in mdio_device_release()
Date: Thu, 1 Dec 2022 16:27:17 +0100 [thread overview]
Message-ID: <Y4jH1Z8UdA/h+WlE@lunn.ch> (raw)
In-Reply-To: <20221201092202.3394119-1-zengheng4@huawei.com>
On Thu, Dec 01, 2022 at 05:22:02PM +0800, Zeng Heng wrote:
> There is warning report about of_node refcount leak
> while probing mdio device:
>
> OF: ERROR: memory leak, expected refcount 1 instead of 2,
> of_node_get()/of_node_put() unbalanced - destroy cset entry:
> attach overlay node /spi/soc@0/mdio@710700c0/ethernet@4
>
> In of_mdiobus_register_device(), we increase fwnode refcount
> by fwnode_handle_get() before associating the of_node with
> mdio device, but it has never been decreased after that.
> Since that, in mdio_device_release(), it needs to call
> fwnode_handle_put() in addition instead of calling kfree()
> directly.
>
> After above, just calling mdio_device_free() in the error handle
> path of of_mdiobus_register_device() is enough to keep the
> refcount balanced.
How does this interact with:
https://lore.kernel.org/netdev/20221201033838.1938765-1-yangyingliang@huawei.com/T/
Andrew
next prev parent reply other threads:[~2022-12-01 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 9:22 [PATCH] net: mdio: fix unbalanced fwnode reference count in mdio_device_release() Zeng Heng
2022-12-01 15:27 ` Andrew Lunn [this message]
2022-12-02 2:14 ` Zeng Heng
2022-12-02 12:56 ` Andrew Lunn
2022-12-02 13:12 ` Yang Yingliang
2022-12-02 13:36 ` Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4jH1Z8UdA/h+WlE@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liwei391@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yangyingliang@huawei.com \
--cc=zengheng4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.