From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Thu, 1 Dec 2022 16:38:16 +0000 Subject: [PATCH v2 26/50] KVM: PPC: Move processor compatibility check to module init In-Reply-To: <87cz93snqc.fsf@mpe.ellerman.id.au> References: <20221130230934.1014142-1-seanjc@google.com> <20221130230934.1014142-27-seanjc@google.com> <87cz93snqc.fsf@mpe.ellerman.id.au> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Dec 01, 2022, Michael Ellerman wrote: > Sean Christopherson writes: > > Move KVM PPC's compatibility checks to their respective module_init() > > hooks, there's no need to wait until KVM's common compat check, nor is > > there a need to perform the check on every CPU (provided by common KVM's > > hook), as the compatibility checks operate on global data. > > > > arch/powerpc/include/asm/cputable.h: extern struct cpu_spec *cur_cpu_spec; > > arch/powerpc/kvm/book3s.c: return 0 > > arch/powerpc/kvm/e500.c: strcmp(cur_cpu_spec->cpu_name, "e500v2") > > arch/powerpc/kvm/e500mc.c: strcmp(cur_cpu_spec->cpu_name, "e500mc") > > strcmp(cur_cpu_spec->cpu_name, "e5500") > > strcmp(cur_cpu_spec->cpu_name, "e6500") > > I'm not sure that output is really useful in the change log unless you > explain more about what it is. Agreed, I got lazy. I'll write a proper description. > > diff --git a/arch/powerpc/kvm/e500mc.c b/arch/powerpc/kvm/e500mc.c > > index 57e0ad6a2ca3..795667f7ebf0 100644 > > --- a/arch/powerpc/kvm/e500mc.c > > +++ b/arch/powerpc/kvm/e500mc.c > > @@ -388,6 +388,10 @@ static int __init kvmppc_e500mc_init(void) > > { > > int r; > > > > + r = kvmppc_e500mc_check_processor_compat(); > > + if (r) > > + return kvmppc_e500mc; > > This doesn't build: > > linux/arch/powerpc/kvm/e500mc.c: In function ?kvmppc_e500mc_init?: > linux/arch/powerpc/kvm/e500mc.c:391:13: error: implicit declaration of function ?kvmppc_e500mc_check_processor_compat?; did you mean ?kvmppc_core_check_processor_compat?? [-Werror=implicit-function-declaration] > 391 | r = kvmppc_e500mc_check_processor_compat(); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | kvmppc_core_check_processor_compat > linux/arch/powerpc/kvm/e500mc.c:393:24: error: ?kvmppc_e500mc? undeclared (first use in this function); did you mean ?kvm_ops_e500mc?? > 393 | return kvmppc_e500mc; > | ^~~~~~~~~~~~~ > | kvm_ops_e500mc > linux/arch/powerpc/kvm/e500mc.c:393:24: note: each undeclared identifier is reported only once for each function it appears in Huh, CONFIG_PPC_E500MC got unselected in the config I use to compile test this flavor. I suspect I botched an oldconfig at some point. Anyways, fixed that and the bugs. Thanks much! -- Subject: [PATCH] KVM: PPC: Move processor compatibility check to module init Move KVM PPC's compatibility checks to their respective module_init() hooks, there's no need to wait until KVM's common compat check, nor is there a need to perform the check on every CPU (provided by common KVM's hook). The compatibility checks are either a nop (Book3S), or simply check the CPU name stored in the global CPU spec (e500 and e500mc). Cc: Fabiano Rosas Cc: Michael Ellerman Signed-off-by: Sean Christopherson --- arch/powerpc/include/asm/kvm_ppc.h | 1 - arch/powerpc/kvm/book3s.c | 10 ---------- arch/powerpc/kvm/e500.c | 4 ++-- arch/powerpc/kvm/e500mc.c | 6 +++++- arch/powerpc/kvm/powerpc.c | 2 +- 5 files changed, 8 insertions(+), 15 deletions(-) diff --git a/arch/powerpc/include/asm/kvm_ppc.h b/arch/powerpc/include/asm/kvm_ppc.h index bfacf12784dd..51a1824b0a16 100644 --- a/arch/powerpc/include/asm/kvm_ppc.h +++ b/arch/powerpc/include/asm/kvm_ppc.h @@ -118,7 +118,6 @@ extern int kvmppc_xlate(struct kvm_vcpu *vcpu, ulong eaddr, extern int kvmppc_core_vcpu_create(struct kvm_vcpu *vcpu); extern void kvmppc_core_vcpu_free(struct kvm_vcpu *vcpu); extern int kvmppc_core_vcpu_setup(struct kvm_vcpu *vcpu); -extern int kvmppc_core_check_processor_compat(void); extern int kvmppc_core_vcpu_translate(struct kvm_vcpu *vcpu, struct kvm_translation *tr); diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c index 6d525285dbe8..87283a0e33d8 100644 --- a/arch/powerpc/kvm/book3s.c +++ b/arch/powerpc/kvm/book3s.c @@ -999,16 +999,6 @@ int kvmppc_h_logical_ci_store(struct kvm_vcpu *vcpu) } EXPORT_SYMBOL_GPL(kvmppc_h_logical_ci_store); -int kvmppc_core_check_processor_compat(void) -{ - /* - * We always return 0 for book3s. We check - * for compatibility while loading the HV - * or PR module - */ - return 0; -} - int kvmppc_book3s_hcall_implemented(struct kvm *kvm, unsigned long hcall) { return kvm->arch.kvm_ops->hcall_implemented(hcall); diff --git a/arch/powerpc/kvm/e500.c b/arch/powerpc/kvm/e500.c index c8b2b4478545..0ea61190ec04 100644 --- a/arch/powerpc/kvm/e500.c +++ b/arch/powerpc/kvm/e500.c @@ -314,7 +314,7 @@ static void kvmppc_core_vcpu_put_e500(struct kvm_vcpu *vcpu) kvmppc_booke_vcpu_put(vcpu); } -int kvmppc_core_check_processor_compat(void) +static int kvmppc_e500_check_processor_compat(void) { int r; @@ -507,7 +507,7 @@ static int __init kvmppc_e500_init(void) unsigned long handler_len; unsigned long max_ivor = 0; - r = kvmppc_core_check_processor_compat(); + r = kvmppc_e500_check_processor_compat(); if (r) goto err_out; diff --git a/arch/powerpc/kvm/e500mc.c b/arch/powerpc/kvm/e500mc.c index 57e0ad6a2ca3..4564aa27edcf 100644 --- a/arch/powerpc/kvm/e500mc.c +++ b/arch/powerpc/kvm/e500mc.c @@ -168,7 +168,7 @@ static void kvmppc_core_vcpu_put_e500mc(struct kvm_vcpu *vcpu) kvmppc_booke_vcpu_put(vcpu); } -int kvmppc_core_check_processor_compat(void) +int kvmppc_e500mc_check_processor_compat(void) { int r; @@ -388,6 +388,10 @@ static int __init kvmppc_e500mc_init(void) { int r; + r = kvmppc_e500mc_check_processor_compat(); + if (r) + goto err_out; + r = kvmppc_booke_init(); if (r) goto err_out; diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c index 5faf69421f13..d44b85ba8cef 100644 --- a/arch/powerpc/kvm/powerpc.c +++ b/arch/powerpc/kvm/powerpc.c @@ -442,7 +442,7 @@ int kvm_arch_hardware_enable(void) int kvm_arch_check_processor_compat(void *opaque) { - return kvmppc_core_check_processor_compat(); + return 0; } int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) base-commit: 00e4493db7c6163d48d5b45034d1a77e16a1c8dc -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id A33F6C43217 for ; Thu, 1 Dec 2022 16:38:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1CD6F4086D; Thu, 1 Dec 2022 11:38:28 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VAfXliIzM+sp; Thu, 1 Dec 2022 11:38:26 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A4A9040C23; Thu, 1 Dec 2022 11:38:26 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D254C4086D for ; Thu, 1 Dec 2022 11:38:25 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DLGbNrLaHKzw for ; Thu, 1 Dec 2022 11:38:24 -0500 (EST) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 63B45407D9 for ; Thu, 1 Dec 2022 11:38:24 -0500 (EST) Received: by mail-pf1-f182.google.com with SMTP id x66so2383984pfx.3 for ; Thu, 01 Dec 2022 08:38:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=wz5UjU3Ma0W7cBTZ/63jSNwcUzSf/RN7ETO0YflOK9Q=; b=L5oONEpJeyYInhCN8kEGfJ8WS2VPlfmSQI0EIRyACnSb62Ho4uiLAZ+22FZ0LpKSBY OanLGdeorUn/O6YHVn5BHqcWoMtKOfzbPKcz+4fsn48JXXYOuwBU81HsoXu4yIA+KxBs oNf69ULLkYXBFawHATlUKtmTRlCCGuue7O3x4Uj20kNa312jwW6CLd6dDy2pzPGk3DaL y4jm5SpqWS/wMH/C2TjT2ihvVuFcoRw2TnuuxPCYPfzDwkDLPEA8hE11/Idhqhxr7xt0 rj/FXhrQIb1ypgd2I2CBp8L/oyRKWO3NUq8Jq7LgrgnoUKAu1/kU3hKmcHIeaOcvmDNO M6Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wz5UjU3Ma0W7cBTZ/63jSNwcUzSf/RN7ETO0YflOK9Q=; b=sOF5jgwwakjQ088wJBbvH36rkI15lRwxJD2zUBATs1VzVwlovgw8hQMuPuazLXtClA DnZraZHTg/yzejx3NUh5acM68hxq5LzP+s3w2Di7Qe7hQFsWyIbPnlUUkUQkhaAQYgiQ dWj6DS1BMp9mfoZ2yM5/0b9tMvVhdX+tw462wn/2/bWHYz/IYHxiSuo0AehCLESsJSsH J6mxzVOEjkB5neLSsnS7eGJyEKqg+tppjAdibZrUWa8HiTLvRKFHSGp9Y2TxuEXCstu0 P7Q1d8eUFhxcrS8OS86nvnAKyXaRTghdoUT7hxmydGXY+yxl76d4hcKiHbDTuTNJOA9p sckw== X-Gm-Message-State: ANoB5pnf3s9y9RDJke6c9RVb7RdiGIe5gHDiolmO68gl8NuOsc+2+0WA u+OjXRVZWQPzDmHCoSv9LA14vQ== X-Google-Smtp-Source: AA0mqf7E8VTs9g+yA9GqMgTdFbO4YLYoa36a9KLdCj074cztIQB7gniXVzh1et27ldGMC17rtCxmqQ== X-Received: by 2002:aa7:8512:0:b0:575:65ff:8831 with SMTP id v18-20020aa78512000000b0057565ff8831mr16235817pfn.80.1669912703144; Thu, 01 Dec 2022 08:38:23 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id l4-20020a17090a384400b00212c27abcaesm5118172pjf.17.2022.12.01.08.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 08:38:22 -0800 (PST) Date: Thu, 1 Dec 2022 16:38:16 +0000 From: Sean Christopherson To: Michael Ellerman Subject: Re: [PATCH v2 26/50] KVM: PPC: Move processor compatibility check to module init Message-ID: References: <20221130230934.1014142-1-seanjc@google.com> <20221130230934.1014142-27-seanjc@google.com> <87cz93snqc.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87cz93snqc.fsf@mpe.ellerman.id.au> Cc: Matthew Rosato , Paul Durrant , Yuan Yao , Paul Walmsley , David Hildenbrand , linux-kernel@vger.kernel.org, Kai Huang , linux-riscv@lists.infradead.org, Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org, Janosch Frank , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Christian Borntraeger , Chao Gao , Eric Farman , Albert Ou , kvm@vger.kernel.org, Atish Patra , kvmarm@lists.linux.dev, Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Isaku Yamahata , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Fabiano Rosas , linuxppc-dev@lists.ozlabs.org, Cornelia Huck , linux-mips@vger.kernel.org, Palmer Dabbelt , kvm-riscv@lists.infradead.org, Paolo Bonzini , Vitaly Kuznetsov , David Woodhouse X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gVGh1LCBEZWMgMDEsIDIwMjIsIE1pY2hhZWwgRWxsZXJtYW4gd3JvdGU6Cj4gU2VhbiBDaHJp c3RvcGhlcnNvbiA8c2VhbmpjQGdvb2dsZS5jb20+IHdyaXRlczoKPiA+IE1vdmUgS1ZNIFBQQydz IGNvbXBhdGliaWxpdHkgY2hlY2tzIHRvIHRoZWlyIHJlc3BlY3RpdmUgbW9kdWxlX2luaXQoKQo+ ID4gaG9va3MsIHRoZXJlJ3Mgbm8gbmVlZCB0byB3YWl0IHVudGlsIEtWTSdzIGNvbW1vbiBjb21w YXQgY2hlY2ssIG5vciBpcwo+ID4gdGhlcmUgYSBuZWVkIHRvIHBlcmZvcm0gdGhlIGNoZWNrIG9u IGV2ZXJ5IENQVSAocHJvdmlkZWQgYnkgY29tbW9uIEtWTSdzCj4gPiBob29rKSwgYXMgdGhlIGNv bXBhdGliaWxpdHkgY2hlY2tzIG9wZXJhdGUgb24gZ2xvYmFsIGRhdGEuCj4gPgo+ID4gICBhcmNo L3Bvd2VycGMvaW5jbHVkZS9hc20vY3B1dGFibGUuaDogZXh0ZXJuIHN0cnVjdCBjcHVfc3BlYyAq Y3VyX2NwdV9zcGVjOwo+ID4gICBhcmNoL3Bvd2VycGMva3ZtL2Jvb2szcy5jOiByZXR1cm4gMAo+ ID4gICBhcmNoL3Bvd2VycGMva3ZtL2U1MDAuYzogc3RyY21wKGN1cl9jcHVfc3BlYy0+Y3B1X25h bWUsICJlNTAwdjIiKQo+ID4gICBhcmNoL3Bvd2VycGMva3ZtL2U1MDBtYy5jOiBzdHJjbXAoY3Vy X2NwdV9zcGVjLT5jcHVfbmFtZSwgImU1MDBtYyIpCj4gPiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHN0cmNtcChjdXJfY3B1X3NwZWMtPmNwdV9uYW1lLCAiZTU1MDAiKQo+ID4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBzdHJjbXAoY3VyX2NwdV9zcGVjLT5jcHVfbmFtZSwgImU2 NTAwIikKPiAKPiBJJ20gbm90IHN1cmUgdGhhdCBvdXRwdXQgaXMgcmVhbGx5IHVzZWZ1bCBpbiB0 aGUgY2hhbmdlIGxvZyB1bmxlc3MgeW91Cj4gZXhwbGFpbiBtb3JlIGFib3V0IHdoYXQgaXQgaXMu CgpBZ3JlZWQsIEkgZ290IGxhenkuICBJJ2xsIHdyaXRlIGEgcHJvcGVyIGRlc2NyaXB0aW9uLgog Cj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMuYyBiL2FyY2gvcG93ZXJw Yy9rdm0vZTUwMG1jLmMKPiA+IGluZGV4IDU3ZTBhZDZhMmNhMy4uNzk1NjY3ZjdlYmYwIDEwMDY0 NAo+ID4gLS0tIGEvYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMuYwo+ID4gKysrIGIvYXJjaC9wb3dl cnBjL2t2bS9lNTAwbWMuYwo+ID4gQEAgLTM4OCw2ICszODgsMTAgQEAgc3RhdGljIGludCBfX2lu aXQga3ZtcHBjX2U1MDBtY19pbml0KHZvaWQpCj4gPiAgewo+ID4gIAlpbnQgcjsKPiA+ICAKPiA+ ICsJciA9IGt2bXBwY19lNTAwbWNfY2hlY2tfcHJvY2Vzc29yX2NvbXBhdCgpOwo+ID4gKwlpZiAo cikKPiA+ICsJCXJldHVybiBrdm1wcGNfZTUwMG1jOwo+ICAKPiBUaGlzIGRvZXNuJ3QgYnVpbGQ6 Cj4gCj4gbGludXgvYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMuYzogSW4gZnVuY3Rpb24g4oCYa3Zt cHBjX2U1MDBtY19pbml04oCZOgo+IGxpbnV4L2FyY2gvcG93ZXJwYy9rdm0vZTUwMG1jLmM6Mzkx OjEzOiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g4oCYa3ZtcHBjX2U1 MDBtY19jaGVja19wcm9jZXNzb3JfY29tcGF04oCZOyBkaWQgeW91IG1lYW4g4oCYa3ZtcHBjX2Nv cmVfY2hlY2tfcHJvY2Vzc29yX2NvbXBhdOKAmT8gWy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rpb24t ZGVjbGFyYXRpb25dCj4gICAzOTEgfCAgICAgICAgIHIgPSBrdm1wcGNfZTUwMG1jX2NoZWNrX3By b2Nlc3Nvcl9jb21wYXQoKTsKPiAgICAgICB8ICAgICAgICAgICAgIF5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fgo+ICAgICAgIHwgICAgICAgICAgICAga3ZtcHBjX2NvcmVfY2hl Y2tfcHJvY2Vzc29yX2NvbXBhdAo+IGxpbnV4L2FyY2gvcG93ZXJwYy9rdm0vZTUwMG1jLmM6Mzkz OjI0OiBlcnJvcjog4oCYa3ZtcHBjX2U1MDBtY+KAmSB1bmRlY2xhcmVkIChmaXJzdCB1c2UgaW4g dGhpcyBmdW5jdGlvbik7IGRpZCB5b3UgbWVhbiDigJhrdm1fb3BzX2U1MDBtY+KAmT8KPiAgIDM5 MyB8ICAgICAgICAgICAgICAgICByZXR1cm4ga3ZtcHBjX2U1MDBtYzsKPiAgICAgICB8ICAgICAg ICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fn5+fgo+ICAgICAgIHwgICAgICAgICAgICAgICAg ICAgICAgICBrdm1fb3BzX2U1MDBtYwo+IGxpbnV4L2FyY2gvcG93ZXJwYy9rdm0vZTUwMG1jLmM6 MzkzOjI0OiBub3RlOiBlYWNoIHVuZGVjbGFyZWQgaWRlbnRpZmllciBpcyByZXBvcnRlZCBvbmx5 IG9uY2UgZm9yIGVhY2ggZnVuY3Rpb24gaXQgYXBwZWFycyBpbgoKSHVoLCBDT05GSUdfUFBDX0U1 MDBNQyBnb3QgdW5zZWxlY3RlZCBpbiB0aGUgY29uZmlnIEkgdXNlIHRvIGNvbXBpbGUgdGVzdCB0 aGlzCmZsYXZvci4gIEkgc3VzcGVjdCBJIGJvdGNoZWQgYW4gb2xkY29uZmlnIGF0IHNvbWUgcG9p bnQuCiAKQW55d2F5cywgZml4ZWQgdGhhdCBhbmQgdGhlIGJ1Z3MuCgpUaGFua3MgbXVjaCEKCi0t ClN1YmplY3Q6IFtQQVRDSF0gS1ZNOiBQUEM6IE1vdmUgcHJvY2Vzc29yIGNvbXBhdGliaWxpdHkg Y2hlY2sgdG8gbW9kdWxlIGluaXQKCk1vdmUgS1ZNIFBQQydzIGNvbXBhdGliaWxpdHkgY2hlY2tz IHRvIHRoZWlyIHJlc3BlY3RpdmUgbW9kdWxlX2luaXQoKQpob29rcywgdGhlcmUncyBubyBuZWVk IHRvIHdhaXQgdW50aWwgS1ZNJ3MgY29tbW9uIGNvbXBhdCBjaGVjaywgbm9yIGlzCnRoZXJlIGEg bmVlZCB0byBwZXJmb3JtIHRoZSBjaGVjayBvbiBldmVyeSBDUFUgKHByb3ZpZGVkIGJ5IGNvbW1v biBLVk0ncwpob29rKS4gIFRoZSBjb21wYXRpYmlsaXR5IGNoZWNrcyBhcmUgZWl0aGVyIGEgbm9w IChCb29rM1MpLCBvciBzaW1wbHkKY2hlY2sgdGhlIENQVSBuYW1lIHN0b3JlZCBpbiB0aGUgZ2xv YmFsIENQVSBzcGVjIChlNTAwIGFuZCBlNTAwbWMpLgoKQ2M6IEZhYmlhbm8gUm9zYXMgPGZhcm9z YXNAbGludXguaWJtLmNvbT4KQ2M6IE1pY2hhZWwgRWxsZXJtYW4gPG1wZUBlbGxlcm1hbi5pZC5h dT4KU2lnbmVkLW9mZi1ieTogU2VhbiBDaHJpc3RvcGhlcnNvbiA8c2VhbmpjQGdvb2dsZS5jb20+ Ci0tLQogYXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNtL2t2bV9wcGMuaCB8ICAxIC0KIGFyY2gvcG93 ZXJwYy9rdm0vYm9vazNzLmMgICAgICAgICAgfCAxMCAtLS0tLS0tLS0tCiBhcmNoL3Bvd2VycGMv a3ZtL2U1MDAuYyAgICAgICAgICAgIHwgIDQgKystLQogYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMu YyAgICAgICAgICB8ICA2ICsrKysrLQogYXJjaC9wb3dlcnBjL2t2bS9wb3dlcnBjLmMgICAgICAg ICB8ICAyICstCiA1IGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNtL2t2bV9wcGMuaCBiL2Fy Y2gvcG93ZXJwYy9pbmNsdWRlL2FzbS9rdm1fcHBjLmgKaW5kZXggYmZhY2YxMjc4NGRkLi41MWEx ODI0YjBhMTYgMTAwNjQ0Ci0tLSBhL2FyY2gvcG93ZXJwYy9pbmNsdWRlL2FzbS9rdm1fcHBjLmgK KysrIGIvYXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNtL2t2bV9wcGMuaApAQCAtMTE4LDcgKzExOCw2 IEBAIGV4dGVybiBpbnQga3ZtcHBjX3hsYXRlKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwgdWxvbmcg ZWFkZHIsCiBleHRlcm4gaW50IGt2bXBwY19jb3JlX3ZjcHVfY3JlYXRlKHN0cnVjdCBrdm1fdmNw dSAqdmNwdSk7CiBleHRlcm4gdm9pZCBrdm1wcGNfY29yZV92Y3B1X2ZyZWUoc3RydWN0IGt2bV92 Y3B1ICp2Y3B1KTsKIGV4dGVybiBpbnQga3ZtcHBjX2NvcmVfdmNwdV9zZXR1cChzdHJ1Y3Qga3Zt X3ZjcHUgKnZjcHUpOwotZXh0ZXJuIGludCBrdm1wcGNfY29yZV9jaGVja19wcm9jZXNzb3JfY29t cGF0KHZvaWQpOwogZXh0ZXJuIGludCBrdm1wcGNfY29yZV92Y3B1X3RyYW5zbGF0ZShzdHJ1Y3Qg a3ZtX3ZjcHUgKnZjcHUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0 cnVjdCBrdm1fdHJhbnNsYXRpb24gKnRyKTsKIApkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL2t2 bS9ib29rM3MuYyBiL2FyY2gvcG93ZXJwYy9rdm0vYm9vazNzLmMKaW5kZXggNmQ1MjUyODVkYmU4 Li44NzI4M2EwZTMzZDggMTAwNjQ0Ci0tLSBhL2FyY2gvcG93ZXJwYy9rdm0vYm9vazNzLmMKKysr IGIvYXJjaC9wb3dlcnBjL2t2bS9ib29rM3MuYwpAQCAtOTk5LDE2ICs5OTksNiBAQCBpbnQga3Zt cHBjX2hfbG9naWNhbF9jaV9zdG9yZShzdHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUpCiB9CiBFWFBPUlRf U1lNQk9MX0dQTChrdm1wcGNfaF9sb2dpY2FsX2NpX3N0b3JlKTsKIAotaW50IGt2bXBwY19jb3Jl X2NoZWNrX3Byb2Nlc3Nvcl9jb21wYXQodm9pZCkKLXsKLQkvKgotCSAqIFdlIGFsd2F5cyByZXR1 cm4gMCBmb3IgYm9vazNzLiBXZSBjaGVjawotCSAqIGZvciBjb21wYXRpYmlsaXR5IHdoaWxlIGxv YWRpbmcgdGhlIEhWCi0JICogb3IgUFIgbW9kdWxlCi0JICovCi0JcmV0dXJuIDA7Ci19Ci0KIGlu dCBrdm1wcGNfYm9vazNzX2hjYWxsX2ltcGxlbWVudGVkKHN0cnVjdCBrdm0gKmt2bSwgdW5zaWdu ZWQgbG9uZyBoY2FsbCkKIHsKIAlyZXR1cm4ga3ZtLT5hcmNoLmt2bV9vcHMtPmhjYWxsX2ltcGxl bWVudGVkKGhjYWxsKTsKZGlmZiAtLWdpdCBhL2FyY2gvcG93ZXJwYy9rdm0vZTUwMC5jIGIvYXJj aC9wb3dlcnBjL2t2bS9lNTAwLmMKaW5kZXggYzhiMmI0NDc4NTQ1Li4wZWE2MTE5MGVjMDQgMTAw NjQ0Ci0tLSBhL2FyY2gvcG93ZXJwYy9rdm0vZTUwMC5jCisrKyBiL2FyY2gvcG93ZXJwYy9rdm0v ZTUwMC5jCkBAIC0zMTQsNyArMzE0LDcgQEAgc3RhdGljIHZvaWQga3ZtcHBjX2NvcmVfdmNwdV9w dXRfZTUwMChzdHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUpCiAJa3ZtcHBjX2Jvb2tlX3ZjcHVfcHV0KHZj cHUpOwogfQogCi1pbnQga3ZtcHBjX2NvcmVfY2hlY2tfcHJvY2Vzc29yX2NvbXBhdCh2b2lkKQor c3RhdGljIGludCBrdm1wcGNfZTUwMF9jaGVja19wcm9jZXNzb3JfY29tcGF0KHZvaWQpCiB7CiAJ aW50IHI7CiAKQEAgLTUwNyw3ICs1MDcsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBrdm1wcGNfZTUw MF9pbml0KHZvaWQpCiAJdW5zaWduZWQgbG9uZyBoYW5kbGVyX2xlbjsKIAl1bnNpZ25lZCBsb25n IG1heF9pdm9yID0gMDsKIAotCXIgPSBrdm1wcGNfY29yZV9jaGVja19wcm9jZXNzb3JfY29tcGF0 KCk7CisJciA9IGt2bXBwY19lNTAwX2NoZWNrX3Byb2Nlc3Nvcl9jb21wYXQoKTsKIAlpZiAocikK IAkJZ290byBlcnJfb3V0OwogCmRpZmYgLS1naXQgYS9hcmNoL3Bvd2VycGMva3ZtL2U1MDBtYy5j IGIvYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMuYwppbmRleCA1N2UwYWQ2YTJjYTMuLjQ1NjRhYTI3 ZWRjZiAxMDA2NDQKLS0tIGEvYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMuYworKysgYi9hcmNoL3Bv d2VycGMva3ZtL2U1MDBtYy5jCkBAIC0xNjgsNyArMTY4LDcgQEAgc3RhdGljIHZvaWQga3ZtcHBj X2NvcmVfdmNwdV9wdXRfZTUwMG1jKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSkKIAlrdm1wcGNfYm9v a2VfdmNwdV9wdXQodmNwdSk7CiB9CiAKLWludCBrdm1wcGNfY29yZV9jaGVja19wcm9jZXNzb3Jf Y29tcGF0KHZvaWQpCitpbnQga3ZtcHBjX2U1MDBtY19jaGVja19wcm9jZXNzb3JfY29tcGF0KHZv aWQpCiB7CiAJaW50IHI7CiAKQEAgLTM4OCw2ICszODgsMTAgQEAgc3RhdGljIGludCBfX2luaXQg a3ZtcHBjX2U1MDBtY19pbml0KHZvaWQpCiB7CiAJaW50IHI7CiAKKwlyID0ga3ZtcHBjX2U1MDBt Y19jaGVja19wcm9jZXNzb3JfY29tcGF0KCk7CisJaWYgKHIpCisJCWdvdG8gZXJyX291dDsKKwog CXIgPSBrdm1wcGNfYm9va2VfaW5pdCgpOwogCWlmIChyKQogCQlnb3RvIGVycl9vdXQ7CmRpZmYg LS1naXQgYS9hcmNoL3Bvd2VycGMva3ZtL3Bvd2VycGMuYyBiL2FyY2gvcG93ZXJwYy9rdm0vcG93 ZXJwYy5jCmluZGV4IDVmYWY2OTQyMWYxMy4uZDQ0Yjg1YmE4Y2VmIDEwMDY0NAotLS0gYS9hcmNo L3Bvd2VycGMva3ZtL3Bvd2VycGMuYworKysgYi9hcmNoL3Bvd2VycGMva3ZtL3Bvd2VycGMuYwpA QCAtNDQyLDcgKzQ0Miw3IEBAIGludCBrdm1fYXJjaF9oYXJkd2FyZV9lbmFibGUodm9pZCkKIAog aW50IGt2bV9hcmNoX2NoZWNrX3Byb2Nlc3Nvcl9jb21wYXQodm9pZCAqb3BhcXVlKQogewotCXJl dHVybiBrdm1wcGNfY29yZV9jaGVja19wcm9jZXNzb3JfY29tcGF0KCk7CisJcmV0dXJuIDA7CiB9 CiAKIGludCBrdm1fYXJjaF9pbml0X3ZtKHN0cnVjdCBrdm0gKmt2bSwgdW5zaWduZWQgbG9uZyB0 eXBlKQoKYmFzZS1jb21taXQ6IDAwZTQ0OTNkYjdjNjE2M2Q0OGQ1YjQ1MDM0ZDFhNzdlMTZhMWM4 ZGMKLS0gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpr dm1hcm0gbWFpbGluZyBsaXN0Cmt2bWFybUBsaXN0cy5jcy5jb2x1bWJpYS5lZHUKaHR0cHM6Ly9s aXN0cy5jcy5jb2x1bWJpYS5lZHUvbWFpbG1hbi9saXN0aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECD0310F6 for ; Thu, 1 Dec 2022 16:38:23 +0000 (UTC) Received: by mail-pf1-f176.google.com with SMTP id k79so2362570pfd.7 for ; Thu, 01 Dec 2022 08:38:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=wz5UjU3Ma0W7cBTZ/63jSNwcUzSf/RN7ETO0YflOK9Q=; b=L5oONEpJeyYInhCN8kEGfJ8WS2VPlfmSQI0EIRyACnSb62Ho4uiLAZ+22FZ0LpKSBY OanLGdeorUn/O6YHVn5BHqcWoMtKOfzbPKcz+4fsn48JXXYOuwBU81HsoXu4yIA+KxBs oNf69ULLkYXBFawHATlUKtmTRlCCGuue7O3x4Uj20kNa312jwW6CLd6dDy2pzPGk3DaL y4jm5SpqWS/wMH/C2TjT2ihvVuFcoRw2TnuuxPCYPfzDwkDLPEA8hE11/Idhqhxr7xt0 rj/FXhrQIb1ypgd2I2CBp8L/oyRKWO3NUq8Jq7LgrgnoUKAu1/kU3hKmcHIeaOcvmDNO M6Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wz5UjU3Ma0W7cBTZ/63jSNwcUzSf/RN7ETO0YflOK9Q=; b=lDVF2X0Xhv3PxjbAc9BXU+rjiUblDungalxQbgf6175pHlKBOurQ0tgFdHVCDTWtNh pYSrvex06A3e0L9QcLUM95TFgHJw61+Bg6PjXtZ1lEzXlMtxlS6IYjqgdF8F+D6BGeo1 PBhGrUBtdPLzWDLXRJOAhk7Qvbb3avoyiJ+VLAL8g9EnwptX1WpQ1bk7l7Z1/j1YWYaL GFza6OAGFz7ZxYMU3IYi703EyfqqLheNERrA1WzkXyyQFrFciu0NOx0/n7QPpG56JkWx FD2H2n2OUP4m1QGDGXcklIQBaLCeYiou84kR8djfBjf6XnRrMHLRe3fEMU3S8lFBKKQt nF1A== X-Gm-Message-State: ANoB5pkL0cZvUErYjqD8FqhO7Hh9/CUe3MVFAS0suoYd/iOa6vRY0pm/ Qw5d/1BjoRyTH1wYRzbwWaI0gg== X-Google-Smtp-Source: AA0mqf7E8VTs9g+yA9GqMgTdFbO4YLYoa36a9KLdCj074cztIQB7gniXVzh1et27ldGMC17rtCxmqQ== X-Received: by 2002:aa7:8512:0:b0:575:65ff:8831 with SMTP id v18-20020aa78512000000b0057565ff8831mr16235817pfn.80.1669912703144; Thu, 01 Dec 2022 08:38:23 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id l4-20020a17090a384400b00212c27abcaesm5118172pjf.17.2022.12.01.08.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 08:38:22 -0800 (PST) Date: Thu, 1 Dec 2022 16:38:16 +0000 From: Sean Christopherson To: Michael Ellerman Cc: Paolo Bonzini , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Matthew Rosato , Eric Farman , Vitaly Kuznetsov , David Woodhouse , Paul Durrant , James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , Atish Patra , David Hildenbrand , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Yuan Yao , Cornelia Huck , Isaku Yamahata , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Fabiano Rosas , Kai Huang , Chao Gao , Thomas Gleixner Subject: Re: [PATCH v2 26/50] KVM: PPC: Move processor compatibility check to module init Message-ID: References: <20221130230934.1014142-1-seanjc@google.com> <20221130230934.1014142-27-seanjc@google.com> <87cz93snqc.fsf@mpe.ellerman.id.au> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87cz93snqc.fsf@mpe.ellerman.id.au> Message-ID: <20221201163816.d1CdTmvQ9q2mt89XTgxdQ5E9RcBt-Ua_P6Moqb0Hhys@z> On Thu, Dec 01, 2022, Michael Ellerman wrote: > Sean Christopherson writes: > > Move KVM PPC's compatibility checks to their respective module_init() > > hooks, there's no need to wait until KVM's common compat check, nor is > > there a need to perform the check on every CPU (provided by common KVM's > > hook), as the compatibility checks operate on global data. > > > > arch/powerpc/include/asm/cputable.h: extern struct cpu_spec *cur_cpu_spec; > > arch/powerpc/kvm/book3s.c: return 0 > > arch/powerpc/kvm/e500.c: strcmp(cur_cpu_spec->cpu_name, "e500v2") > > arch/powerpc/kvm/e500mc.c: strcmp(cur_cpu_spec->cpu_name, "e500mc") > > strcmp(cur_cpu_spec->cpu_name, "e5500") > > strcmp(cur_cpu_spec->cpu_name, "e6500") > > I'm not sure that output is really useful in the change log unless you > explain more about what it is. Agreed, I got lazy. I'll write a proper description. > > diff --git a/arch/powerpc/kvm/e500mc.c b/arch/powerpc/kvm/e500mc.c > > index 57e0ad6a2ca3..795667f7ebf0 100644 > > --- a/arch/powerpc/kvm/e500mc.c > > +++ b/arch/powerpc/kvm/e500mc.c > > @@ -388,6 +388,10 @@ static int __init kvmppc_e500mc_init(void) > > { > > int r; > > > > + r = kvmppc_e500mc_check_processor_compat(); > > + if (r) > > + return kvmppc_e500mc; > > This doesn't build: > > linux/arch/powerpc/kvm/e500mc.c: In function ‘kvmppc_e500mc_init’: > linux/arch/powerpc/kvm/e500mc.c:391:13: error: implicit declaration of function ‘kvmppc_e500mc_check_processor_compat’; did you mean ‘kvmppc_core_check_processor_compat’? [-Werror=implicit-function-declaration] > 391 | r = kvmppc_e500mc_check_processor_compat(); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | kvmppc_core_check_processor_compat > linux/arch/powerpc/kvm/e500mc.c:393:24: error: ‘kvmppc_e500mc’ undeclared (first use in this function); did you mean ‘kvm_ops_e500mc’? > 393 | return kvmppc_e500mc; > | ^~~~~~~~~~~~~ > | kvm_ops_e500mc > linux/arch/powerpc/kvm/e500mc.c:393:24: note: each undeclared identifier is reported only once for each function it appears in Huh, CONFIG_PPC_E500MC got unselected in the config I use to compile test this flavor. I suspect I botched an oldconfig at some point. Anyways, fixed that and the bugs. Thanks much! -- Subject: [PATCH] KVM: PPC: Move processor compatibility check to module init Move KVM PPC's compatibility checks to their respective module_init() hooks, there's no need to wait until KVM's common compat check, nor is there a need to perform the check on every CPU (provided by common KVM's hook). The compatibility checks are either a nop (Book3S), or simply check the CPU name stored in the global CPU spec (e500 and e500mc). Cc: Fabiano Rosas Cc: Michael Ellerman Signed-off-by: Sean Christopherson --- arch/powerpc/include/asm/kvm_ppc.h | 1 - arch/powerpc/kvm/book3s.c | 10 ---------- arch/powerpc/kvm/e500.c | 4 ++-- arch/powerpc/kvm/e500mc.c | 6 +++++- arch/powerpc/kvm/powerpc.c | 2 +- 5 files changed, 8 insertions(+), 15 deletions(-) diff --git a/arch/powerpc/include/asm/kvm_ppc.h b/arch/powerpc/include/asm/kvm_ppc.h index bfacf12784dd..51a1824b0a16 100644 --- a/arch/powerpc/include/asm/kvm_ppc.h +++ b/arch/powerpc/include/asm/kvm_ppc.h @@ -118,7 +118,6 @@ extern int kvmppc_xlate(struct kvm_vcpu *vcpu, ulong eaddr, extern int kvmppc_core_vcpu_create(struct kvm_vcpu *vcpu); extern void kvmppc_core_vcpu_free(struct kvm_vcpu *vcpu); extern int kvmppc_core_vcpu_setup(struct kvm_vcpu *vcpu); -extern int kvmppc_core_check_processor_compat(void); extern int kvmppc_core_vcpu_translate(struct kvm_vcpu *vcpu, struct kvm_translation *tr); diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c index 6d525285dbe8..87283a0e33d8 100644 --- a/arch/powerpc/kvm/book3s.c +++ b/arch/powerpc/kvm/book3s.c @@ -999,16 +999,6 @@ int kvmppc_h_logical_ci_store(struct kvm_vcpu *vcpu) } EXPORT_SYMBOL_GPL(kvmppc_h_logical_ci_store); -int kvmppc_core_check_processor_compat(void) -{ - /* - * We always return 0 for book3s. We check - * for compatibility while loading the HV - * or PR module - */ - return 0; -} - int kvmppc_book3s_hcall_implemented(struct kvm *kvm, unsigned long hcall) { return kvm->arch.kvm_ops->hcall_implemented(hcall); diff --git a/arch/powerpc/kvm/e500.c b/arch/powerpc/kvm/e500.c index c8b2b4478545..0ea61190ec04 100644 --- a/arch/powerpc/kvm/e500.c +++ b/arch/powerpc/kvm/e500.c @@ -314,7 +314,7 @@ static void kvmppc_core_vcpu_put_e500(struct kvm_vcpu *vcpu) kvmppc_booke_vcpu_put(vcpu); } -int kvmppc_core_check_processor_compat(void) +static int kvmppc_e500_check_processor_compat(void) { int r; @@ -507,7 +507,7 @@ static int __init kvmppc_e500_init(void) unsigned long handler_len; unsigned long max_ivor = 0; - r = kvmppc_core_check_processor_compat(); + r = kvmppc_e500_check_processor_compat(); if (r) goto err_out; diff --git a/arch/powerpc/kvm/e500mc.c b/arch/powerpc/kvm/e500mc.c index 57e0ad6a2ca3..4564aa27edcf 100644 --- a/arch/powerpc/kvm/e500mc.c +++ b/arch/powerpc/kvm/e500mc.c @@ -168,7 +168,7 @@ static void kvmppc_core_vcpu_put_e500mc(struct kvm_vcpu *vcpu) kvmppc_booke_vcpu_put(vcpu); } -int kvmppc_core_check_processor_compat(void) +int kvmppc_e500mc_check_processor_compat(void) { int r; @@ -388,6 +388,10 @@ static int __init kvmppc_e500mc_init(void) { int r; + r = kvmppc_e500mc_check_processor_compat(); + if (r) + goto err_out; + r = kvmppc_booke_init(); if (r) goto err_out; diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c index 5faf69421f13..d44b85ba8cef 100644 --- a/arch/powerpc/kvm/powerpc.c +++ b/arch/powerpc/kvm/powerpc.c @@ -442,7 +442,7 @@ int kvm_arch_hardware_enable(void) int kvm_arch_check_processor_compat(void *opaque) { - return kvmppc_core_check_processor_compat(); + return 0; } int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) base-commit: 00e4493db7c6163d48d5b45034d1a77e16a1c8dc -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BBA0C43217 for ; Thu, 1 Dec 2022 16:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fHWXc6XYzMeWv5opOlFpHJ7Sj+Q9HrmPbiUtQf9hp00=; b=Td0YpOdXUOeIea p7H8RGUACBxOITFOAYliW3g7jkJdd8n6eIVdHFuWaEiKuXPCsiF6uK0AVmTdeUeoPy9QdcqOq264V IRlwIxR+J3io542XKt14Yu+HumCg/cK1yDR3zhqOfAl3xAVmy/3mV9SUa1YJBFjYHwYJd1WUyua/k PoI9R5JHkDcqB9Rwmy7uxTvglTht2YhqXHhcQvi/nTA7K6w/yWmPHmB8lC1wdsXuqb+Fk4H5cMTKd Lh48ioC/M+yCSFnGlxhOxka68cshk3DulrTIP94pL/Kd68urPM3xJuxUJrzVL1ff23rbTHsK1+4/d amgHWrZJeWN8aS3ORAmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0ma9-008c1V-5t; Thu, 01 Dec 2022 16:38:41 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0mZx-008buc-Q2 for linux-riscv@lists.infradead.org; Thu, 01 Dec 2022 16:38:31 +0000 Received: by mail-pf1-x42c.google.com with SMTP id w129so2373800pfb.5 for ; Thu, 01 Dec 2022 08:38:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=wz5UjU3Ma0W7cBTZ/63jSNwcUzSf/RN7ETO0YflOK9Q=; b=L5oONEpJeyYInhCN8kEGfJ8WS2VPlfmSQI0EIRyACnSb62Ho4uiLAZ+22FZ0LpKSBY OanLGdeorUn/O6YHVn5BHqcWoMtKOfzbPKcz+4fsn48JXXYOuwBU81HsoXu4yIA+KxBs oNf69ULLkYXBFawHATlUKtmTRlCCGuue7O3x4Uj20kNa312jwW6CLd6dDy2pzPGk3DaL y4jm5SpqWS/wMH/C2TjT2ihvVuFcoRw2TnuuxPCYPfzDwkDLPEA8hE11/Idhqhxr7xt0 rj/FXhrQIb1ypgd2I2CBp8L/oyRKWO3NUq8Jq7LgrgnoUKAu1/kU3hKmcHIeaOcvmDNO M6Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wz5UjU3Ma0W7cBTZ/63jSNwcUzSf/RN7ETO0YflOK9Q=; b=cpa+s42+Wh3mXXJMDeyx09CNSAEjI9PYX1OIW8qyFHY9EIsu/60CQvl2Ux5UOaWNjz YHTBRQsFipHvuUJtVT4nZ4bP+APIdpLW+yg9hj732QcuHJxxKHjpA3bobR6XHPU0+eVR l/sSFKmclH3fry/UOOuLuCyDKd6rgDoSEUFI9j6eRgrER4gxDit5bEbLz2dF281Meg2X Q6n4ju2ClimCqTh2ELnHSQiOvmDUaW0rAv+FwBkKiErmio4xr6tNPrUwVJNOxf2uUq4d VpOd8yl6XCfNFyY+cfT/6K5aNzc91a9qhbcPxgKQ21QRo5f3ptefYmMyJcsRHyWBR6Qe HUSg== X-Gm-Message-State: ANoB5pn8CISRmV/lQt2cfe16ks1I2ULoco9NH6UdIwAPtGjI3iZxMF/l Q35/exhfL46hMX4I32MVCxUN8A== X-Google-Smtp-Source: AA0mqf7E8VTs9g+yA9GqMgTdFbO4YLYoa36a9KLdCj074cztIQB7gniXVzh1et27ldGMC17rtCxmqQ== X-Received: by 2002:aa7:8512:0:b0:575:65ff:8831 with SMTP id v18-20020aa78512000000b0057565ff8831mr16235817pfn.80.1669912703144; Thu, 01 Dec 2022 08:38:23 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id l4-20020a17090a384400b00212c27abcaesm5118172pjf.17.2022.12.01.08.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 08:38:22 -0800 (PST) Date: Thu, 1 Dec 2022 16:38:16 +0000 From: Sean Christopherson To: Michael Ellerman Cc: Paolo Bonzini , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Matthew Rosato , Eric Farman , Vitaly Kuznetsov , David Woodhouse , Paul Durrant , James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , Atish Patra , David Hildenbrand , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Yuan Yao , Cornelia Huck , Isaku Yamahata , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Fabiano Rosas , Kai Huang , Chao Gao , Thomas Gleixner Subject: Re: [PATCH v2 26/50] KVM: PPC: Move processor compatibility check to module init Message-ID: References: <20221130230934.1014142-1-seanjc@google.com> <20221130230934.1014142-27-seanjc@google.com> <87cz93snqc.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87cz93snqc.fsf@mpe.ellerman.id.au> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221201_083829_875644_5898AB9F X-CRM114-Status: GOOD ( 33.65 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCBEZWMgMDEsIDIwMjIsIE1pY2hhZWwgRWxsZXJtYW4gd3JvdGU6Cj4gU2VhbiBDaHJp c3RvcGhlcnNvbiA8c2VhbmpjQGdvb2dsZS5jb20+IHdyaXRlczoKPiA+IE1vdmUgS1ZNIFBQQydz IGNvbXBhdGliaWxpdHkgY2hlY2tzIHRvIHRoZWlyIHJlc3BlY3RpdmUgbW9kdWxlX2luaXQoKQo+ ID4gaG9va3MsIHRoZXJlJ3Mgbm8gbmVlZCB0byB3YWl0IHVudGlsIEtWTSdzIGNvbW1vbiBjb21w YXQgY2hlY2ssIG5vciBpcwo+ID4gdGhlcmUgYSBuZWVkIHRvIHBlcmZvcm0gdGhlIGNoZWNrIG9u IGV2ZXJ5IENQVSAocHJvdmlkZWQgYnkgY29tbW9uIEtWTSdzCj4gPiBob29rKSwgYXMgdGhlIGNv bXBhdGliaWxpdHkgY2hlY2tzIG9wZXJhdGUgb24gZ2xvYmFsIGRhdGEuCj4gPgo+ID4gICBhcmNo L3Bvd2VycGMvaW5jbHVkZS9hc20vY3B1dGFibGUuaDogZXh0ZXJuIHN0cnVjdCBjcHVfc3BlYyAq Y3VyX2NwdV9zcGVjOwo+ID4gICBhcmNoL3Bvd2VycGMva3ZtL2Jvb2szcy5jOiByZXR1cm4gMAo+ ID4gICBhcmNoL3Bvd2VycGMva3ZtL2U1MDAuYzogc3RyY21wKGN1cl9jcHVfc3BlYy0+Y3B1X25h bWUsICJlNTAwdjIiKQo+ID4gICBhcmNoL3Bvd2VycGMva3ZtL2U1MDBtYy5jOiBzdHJjbXAoY3Vy X2NwdV9zcGVjLT5jcHVfbmFtZSwgImU1MDBtYyIpCj4gPiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHN0cmNtcChjdXJfY3B1X3NwZWMtPmNwdV9uYW1lLCAiZTU1MDAiKQo+ID4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBzdHJjbXAoY3VyX2NwdV9zcGVjLT5jcHVfbmFtZSwgImU2 NTAwIikKPiAKPiBJJ20gbm90IHN1cmUgdGhhdCBvdXRwdXQgaXMgcmVhbGx5IHVzZWZ1bCBpbiB0 aGUgY2hhbmdlIGxvZyB1bmxlc3MgeW91Cj4gZXhwbGFpbiBtb3JlIGFib3V0IHdoYXQgaXQgaXMu CgpBZ3JlZWQsIEkgZ290IGxhenkuICBJJ2xsIHdyaXRlIGEgcHJvcGVyIGRlc2NyaXB0aW9uLgog Cj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMuYyBiL2FyY2gvcG93ZXJw Yy9rdm0vZTUwMG1jLmMKPiA+IGluZGV4IDU3ZTBhZDZhMmNhMy4uNzk1NjY3ZjdlYmYwIDEwMDY0 NAo+ID4gLS0tIGEvYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMuYwo+ID4gKysrIGIvYXJjaC9wb3dl cnBjL2t2bS9lNTAwbWMuYwo+ID4gQEAgLTM4OCw2ICszODgsMTAgQEAgc3RhdGljIGludCBfX2lu aXQga3ZtcHBjX2U1MDBtY19pbml0KHZvaWQpCj4gPiAgewo+ID4gIAlpbnQgcjsKPiA+ICAKPiA+ ICsJciA9IGt2bXBwY19lNTAwbWNfY2hlY2tfcHJvY2Vzc29yX2NvbXBhdCgpOwo+ID4gKwlpZiAo cikKPiA+ICsJCXJldHVybiBrdm1wcGNfZTUwMG1jOwo+ICAKPiBUaGlzIGRvZXNuJ3QgYnVpbGQ6 Cj4gCj4gbGludXgvYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMuYzogSW4gZnVuY3Rpb24g4oCYa3Zt cHBjX2U1MDBtY19pbml04oCZOgo+IGxpbnV4L2FyY2gvcG93ZXJwYy9rdm0vZTUwMG1jLmM6Mzkx OjEzOiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g4oCYa3ZtcHBjX2U1 MDBtY19jaGVja19wcm9jZXNzb3JfY29tcGF04oCZOyBkaWQgeW91IG1lYW4g4oCYa3ZtcHBjX2Nv cmVfY2hlY2tfcHJvY2Vzc29yX2NvbXBhdOKAmT8gWy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rpb24t ZGVjbGFyYXRpb25dCj4gICAzOTEgfCAgICAgICAgIHIgPSBrdm1wcGNfZTUwMG1jX2NoZWNrX3By b2Nlc3Nvcl9jb21wYXQoKTsKPiAgICAgICB8ICAgICAgICAgICAgIF5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fgo+ICAgICAgIHwgICAgICAgICAgICAga3ZtcHBjX2NvcmVfY2hl Y2tfcHJvY2Vzc29yX2NvbXBhdAo+IGxpbnV4L2FyY2gvcG93ZXJwYy9rdm0vZTUwMG1jLmM6Mzkz OjI0OiBlcnJvcjog4oCYa3ZtcHBjX2U1MDBtY+KAmSB1bmRlY2xhcmVkIChmaXJzdCB1c2UgaW4g dGhpcyBmdW5jdGlvbik7IGRpZCB5b3UgbWVhbiDigJhrdm1fb3BzX2U1MDBtY+KAmT8KPiAgIDM5 MyB8ICAgICAgICAgICAgICAgICByZXR1cm4ga3ZtcHBjX2U1MDBtYzsKPiAgICAgICB8ICAgICAg ICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fn5+fgo+ICAgICAgIHwgICAgICAgICAgICAgICAg ICAgICAgICBrdm1fb3BzX2U1MDBtYwo+IGxpbnV4L2FyY2gvcG93ZXJwYy9rdm0vZTUwMG1jLmM6 MzkzOjI0OiBub3RlOiBlYWNoIHVuZGVjbGFyZWQgaWRlbnRpZmllciBpcyByZXBvcnRlZCBvbmx5 IG9uY2UgZm9yIGVhY2ggZnVuY3Rpb24gaXQgYXBwZWFycyBpbgoKSHVoLCBDT05GSUdfUFBDX0U1 MDBNQyBnb3QgdW5zZWxlY3RlZCBpbiB0aGUgY29uZmlnIEkgdXNlIHRvIGNvbXBpbGUgdGVzdCB0 aGlzCmZsYXZvci4gIEkgc3VzcGVjdCBJIGJvdGNoZWQgYW4gb2xkY29uZmlnIGF0IHNvbWUgcG9p bnQuCiAKQW55d2F5cywgZml4ZWQgdGhhdCBhbmQgdGhlIGJ1Z3MuCgpUaGFua3MgbXVjaCEKCi0t ClN1YmplY3Q6IFtQQVRDSF0gS1ZNOiBQUEM6IE1vdmUgcHJvY2Vzc29yIGNvbXBhdGliaWxpdHkg Y2hlY2sgdG8gbW9kdWxlIGluaXQKCk1vdmUgS1ZNIFBQQydzIGNvbXBhdGliaWxpdHkgY2hlY2tz IHRvIHRoZWlyIHJlc3BlY3RpdmUgbW9kdWxlX2luaXQoKQpob29rcywgdGhlcmUncyBubyBuZWVk IHRvIHdhaXQgdW50aWwgS1ZNJ3MgY29tbW9uIGNvbXBhdCBjaGVjaywgbm9yIGlzCnRoZXJlIGEg bmVlZCB0byBwZXJmb3JtIHRoZSBjaGVjayBvbiBldmVyeSBDUFUgKHByb3ZpZGVkIGJ5IGNvbW1v biBLVk0ncwpob29rKS4gIFRoZSBjb21wYXRpYmlsaXR5IGNoZWNrcyBhcmUgZWl0aGVyIGEgbm9w IChCb29rM1MpLCBvciBzaW1wbHkKY2hlY2sgdGhlIENQVSBuYW1lIHN0b3JlZCBpbiB0aGUgZ2xv YmFsIENQVSBzcGVjIChlNTAwIGFuZCBlNTAwbWMpLgoKQ2M6IEZhYmlhbm8gUm9zYXMgPGZhcm9z YXNAbGludXguaWJtLmNvbT4KQ2M6IE1pY2hhZWwgRWxsZXJtYW4gPG1wZUBlbGxlcm1hbi5pZC5h dT4KU2lnbmVkLW9mZi1ieTogU2VhbiBDaHJpc3RvcGhlcnNvbiA8c2VhbmpjQGdvb2dsZS5jb20+ Ci0tLQogYXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNtL2t2bV9wcGMuaCB8ICAxIC0KIGFyY2gvcG93 ZXJwYy9rdm0vYm9vazNzLmMgICAgICAgICAgfCAxMCAtLS0tLS0tLS0tCiBhcmNoL3Bvd2VycGMv a3ZtL2U1MDAuYyAgICAgICAgICAgIHwgIDQgKystLQogYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMu YyAgICAgICAgICB8ICA2ICsrKysrLQogYXJjaC9wb3dlcnBjL2t2bS9wb3dlcnBjLmMgICAgICAg ICB8ICAyICstCiA1IGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNtL2t2bV9wcGMuaCBiL2Fy Y2gvcG93ZXJwYy9pbmNsdWRlL2FzbS9rdm1fcHBjLmgKaW5kZXggYmZhY2YxMjc4NGRkLi41MWEx ODI0YjBhMTYgMTAwNjQ0Ci0tLSBhL2FyY2gvcG93ZXJwYy9pbmNsdWRlL2FzbS9rdm1fcHBjLmgK KysrIGIvYXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNtL2t2bV9wcGMuaApAQCAtMTE4LDcgKzExOCw2 IEBAIGV4dGVybiBpbnQga3ZtcHBjX3hsYXRlKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwgdWxvbmcg ZWFkZHIsCiBleHRlcm4gaW50IGt2bXBwY19jb3JlX3ZjcHVfY3JlYXRlKHN0cnVjdCBrdm1fdmNw dSAqdmNwdSk7CiBleHRlcm4gdm9pZCBrdm1wcGNfY29yZV92Y3B1X2ZyZWUoc3RydWN0IGt2bV92 Y3B1ICp2Y3B1KTsKIGV4dGVybiBpbnQga3ZtcHBjX2NvcmVfdmNwdV9zZXR1cChzdHJ1Y3Qga3Zt X3ZjcHUgKnZjcHUpOwotZXh0ZXJuIGludCBrdm1wcGNfY29yZV9jaGVja19wcm9jZXNzb3JfY29t cGF0KHZvaWQpOwogZXh0ZXJuIGludCBrdm1wcGNfY29yZV92Y3B1X3RyYW5zbGF0ZShzdHJ1Y3Qg a3ZtX3ZjcHUgKnZjcHUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0 cnVjdCBrdm1fdHJhbnNsYXRpb24gKnRyKTsKIApkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL2t2 bS9ib29rM3MuYyBiL2FyY2gvcG93ZXJwYy9rdm0vYm9vazNzLmMKaW5kZXggNmQ1MjUyODVkYmU4 Li44NzI4M2EwZTMzZDggMTAwNjQ0Ci0tLSBhL2FyY2gvcG93ZXJwYy9rdm0vYm9vazNzLmMKKysr IGIvYXJjaC9wb3dlcnBjL2t2bS9ib29rM3MuYwpAQCAtOTk5LDE2ICs5OTksNiBAQCBpbnQga3Zt cHBjX2hfbG9naWNhbF9jaV9zdG9yZShzdHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUpCiB9CiBFWFBPUlRf U1lNQk9MX0dQTChrdm1wcGNfaF9sb2dpY2FsX2NpX3N0b3JlKTsKIAotaW50IGt2bXBwY19jb3Jl X2NoZWNrX3Byb2Nlc3Nvcl9jb21wYXQodm9pZCkKLXsKLQkvKgotCSAqIFdlIGFsd2F5cyByZXR1 cm4gMCBmb3IgYm9vazNzLiBXZSBjaGVjawotCSAqIGZvciBjb21wYXRpYmlsaXR5IHdoaWxlIGxv YWRpbmcgdGhlIEhWCi0JICogb3IgUFIgbW9kdWxlCi0JICovCi0JcmV0dXJuIDA7Ci19Ci0KIGlu dCBrdm1wcGNfYm9vazNzX2hjYWxsX2ltcGxlbWVudGVkKHN0cnVjdCBrdm0gKmt2bSwgdW5zaWdu ZWQgbG9uZyBoY2FsbCkKIHsKIAlyZXR1cm4ga3ZtLT5hcmNoLmt2bV9vcHMtPmhjYWxsX2ltcGxl bWVudGVkKGhjYWxsKTsKZGlmZiAtLWdpdCBhL2FyY2gvcG93ZXJwYy9rdm0vZTUwMC5jIGIvYXJj aC9wb3dlcnBjL2t2bS9lNTAwLmMKaW5kZXggYzhiMmI0NDc4NTQ1Li4wZWE2MTE5MGVjMDQgMTAw NjQ0Ci0tLSBhL2FyY2gvcG93ZXJwYy9rdm0vZTUwMC5jCisrKyBiL2FyY2gvcG93ZXJwYy9rdm0v ZTUwMC5jCkBAIC0zMTQsNyArMzE0LDcgQEAgc3RhdGljIHZvaWQga3ZtcHBjX2NvcmVfdmNwdV9w dXRfZTUwMChzdHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUpCiAJa3ZtcHBjX2Jvb2tlX3ZjcHVfcHV0KHZj cHUpOwogfQogCi1pbnQga3ZtcHBjX2NvcmVfY2hlY2tfcHJvY2Vzc29yX2NvbXBhdCh2b2lkKQor c3RhdGljIGludCBrdm1wcGNfZTUwMF9jaGVja19wcm9jZXNzb3JfY29tcGF0KHZvaWQpCiB7CiAJ aW50IHI7CiAKQEAgLTUwNyw3ICs1MDcsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBrdm1wcGNfZTUw MF9pbml0KHZvaWQpCiAJdW5zaWduZWQgbG9uZyBoYW5kbGVyX2xlbjsKIAl1bnNpZ25lZCBsb25n IG1heF9pdm9yID0gMDsKIAotCXIgPSBrdm1wcGNfY29yZV9jaGVja19wcm9jZXNzb3JfY29tcGF0 KCk7CisJciA9IGt2bXBwY19lNTAwX2NoZWNrX3Byb2Nlc3Nvcl9jb21wYXQoKTsKIAlpZiAocikK IAkJZ290byBlcnJfb3V0OwogCmRpZmYgLS1naXQgYS9hcmNoL3Bvd2VycGMva3ZtL2U1MDBtYy5j IGIvYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMuYwppbmRleCA1N2UwYWQ2YTJjYTMuLjQ1NjRhYTI3 ZWRjZiAxMDA2NDQKLS0tIGEvYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMuYworKysgYi9hcmNoL3Bv d2VycGMva3ZtL2U1MDBtYy5jCkBAIC0xNjgsNyArMTY4LDcgQEAgc3RhdGljIHZvaWQga3ZtcHBj X2NvcmVfdmNwdV9wdXRfZTUwMG1jKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSkKIAlrdm1wcGNfYm9v a2VfdmNwdV9wdXQodmNwdSk7CiB9CiAKLWludCBrdm1wcGNfY29yZV9jaGVja19wcm9jZXNzb3Jf Y29tcGF0KHZvaWQpCitpbnQga3ZtcHBjX2U1MDBtY19jaGVja19wcm9jZXNzb3JfY29tcGF0KHZv aWQpCiB7CiAJaW50IHI7CiAKQEAgLTM4OCw2ICszODgsMTAgQEAgc3RhdGljIGludCBfX2luaXQg a3ZtcHBjX2U1MDBtY19pbml0KHZvaWQpCiB7CiAJaW50IHI7CiAKKwlyID0ga3ZtcHBjX2U1MDBt Y19jaGVja19wcm9jZXNzb3JfY29tcGF0KCk7CisJaWYgKHIpCisJCWdvdG8gZXJyX291dDsKKwog CXIgPSBrdm1wcGNfYm9va2VfaW5pdCgpOwogCWlmIChyKQogCQlnb3RvIGVycl9vdXQ7CmRpZmYg LS1naXQgYS9hcmNoL3Bvd2VycGMva3ZtL3Bvd2VycGMuYyBiL2FyY2gvcG93ZXJwYy9rdm0vcG93 ZXJwYy5jCmluZGV4IDVmYWY2OTQyMWYxMy4uZDQ0Yjg1YmE4Y2VmIDEwMDY0NAotLS0gYS9hcmNo L3Bvd2VycGMva3ZtL3Bvd2VycGMuYworKysgYi9hcmNoL3Bvd2VycGMva3ZtL3Bvd2VycGMuYwpA QCAtNDQyLDcgKzQ0Miw3IEBAIGludCBrdm1fYXJjaF9oYXJkd2FyZV9lbmFibGUodm9pZCkKIAog aW50IGt2bV9hcmNoX2NoZWNrX3Byb2Nlc3Nvcl9jb21wYXQodm9pZCAqb3BhcXVlKQogewotCXJl dHVybiBrdm1wcGNfY29yZV9jaGVja19wcm9jZXNzb3JfY29tcGF0KCk7CisJcmV0dXJuIDA7CiB9 CiAKIGludCBrdm1fYXJjaF9pbml0X3ZtKHN0cnVjdCBrdm0gKmt2bSwgdW5zaWduZWQgbG9uZyB0 eXBlKQoKYmFzZS1jb21taXQ6IDAwZTQ0OTNkYjdjNjE2M2Q0OGQ1YjQ1MDM0ZDFhNzdlMTZhMWM4 ZGMKLS0gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48A67C4321E for ; Thu, 1 Dec 2022 16:39:26 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NNMH03cXZz3bgH for ; Fri, 2 Dec 2022 03:39:24 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=L5oONEpJ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::435; helo=mail-pf1-x435.google.com; envelope-from=seanjc@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=L5oONEpJ; dkim-atps=neutral Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NNMFt68r3z3bY0 for ; Fri, 2 Dec 2022 03:38:25 +1100 (AEDT) Received: by mail-pf1-x435.google.com with SMTP id w2so833572pfq.12 for ; Thu, 01 Dec 2022 08:38:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=wz5UjU3Ma0W7cBTZ/63jSNwcUzSf/RN7ETO0YflOK9Q=; b=L5oONEpJeyYInhCN8kEGfJ8WS2VPlfmSQI0EIRyACnSb62Ho4uiLAZ+22FZ0LpKSBY OanLGdeorUn/O6YHVn5BHqcWoMtKOfzbPKcz+4fsn48JXXYOuwBU81HsoXu4yIA+KxBs oNf69ULLkYXBFawHATlUKtmTRlCCGuue7O3x4Uj20kNa312jwW6CLd6dDy2pzPGk3DaL y4jm5SpqWS/wMH/C2TjT2ihvVuFcoRw2TnuuxPCYPfzDwkDLPEA8hE11/Idhqhxr7xt0 rj/FXhrQIb1ypgd2I2CBp8L/oyRKWO3NUq8Jq7LgrgnoUKAu1/kU3hKmcHIeaOcvmDNO M6Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wz5UjU3Ma0W7cBTZ/63jSNwcUzSf/RN7ETO0YflOK9Q=; b=NqwgQtax2mqhvCzKgCLGPhEBkDVndjApHOOtcnmsyJ9tBFoJ+P3HtYbzBS/EZE4d1q TeyakfnH9u2DUv3eMFVCNZvgh6tRgxa7Ds5EFE2fsS2AB9QyIWRZ5stZ36Fv/C2ZRXic zVC3PuyqTJdf2ka4k9SVe8AWwBX4ThCDkdWuYo0TnzayHykPsnPOY7uUPFKRe82DzIzs 6I/VlZl1g1wUdztd0fEKvvW4HtC/Q9VNlOBqCZdKR2J2kxwK3NCPyXO4cWArm/qBmr10 xBJDEbHwkThXvTrH1Vpma6nJZ0Dgkrkjcl+figwMc/PhfIXPrj98tFSkiUnaDL2FnwZm xODw== X-Gm-Message-State: ANoB5pmoDkxmSdr1R/kAqfCd+DKvCLuN0QNr1U5bhirPbLEu14ncGxfu +8alQwxspc7p7EbpXF9ANBz3aw== X-Google-Smtp-Source: AA0mqf7E8VTs9g+yA9GqMgTdFbO4YLYoa36a9KLdCj074cztIQB7gniXVzh1et27ldGMC17rtCxmqQ== X-Received: by 2002:aa7:8512:0:b0:575:65ff:8831 with SMTP id v18-20020aa78512000000b0057565ff8831mr16235817pfn.80.1669912703144; Thu, 01 Dec 2022 08:38:23 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id l4-20020a17090a384400b00212c27abcaesm5118172pjf.17.2022.12.01.08.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 08:38:22 -0800 (PST) Date: Thu, 1 Dec 2022 16:38:16 +0000 From: Sean Christopherson To: Michael Ellerman Subject: Re: [PATCH v2 26/50] KVM: PPC: Move processor compatibility check to module init Message-ID: References: <20221130230934.1014142-1-seanjc@google.com> <20221130230934.1014142-27-seanjc@google.com> <87cz93snqc.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87cz93snqc.fsf@mpe.ellerman.id.au> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthew Rosato , Paul Durrant , Yuan Yao , Paul Walmsley , David Hildenbrand , linux-kernel@vger.kernel.org, Kai Huang , linux-riscv@lists.infradead.org, Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org, Janosch Frank , Marc Zyngier , Huacai Chen , Aleksandar Markovic , James Morse , Christian Borntraeger , Chao Gao , Eric Farman , Albert Ou , Suzuki K Poulose , kvm@vger.kernel.org, Atish Patra , kvmarm@lists.linux.dev, Thomas Gleixner , Alexandru Elisei , linux-arm-kernel@lists.infradead.org, Isaku Yamahata , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Fabiano Rosas , linuxppc-dev@lists.ozlabs.org, Cornelia Huck , linux-mips@vger.kernel.org, Oliver Upton , Palmer Dabbelt , kvm-riscv@lists.infradead.org, Anup Patel , Paolo Bonzini , Vitaly Kuznetsov , David Woodhouse Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Dec 01, 2022, Michael Ellerman wrote: > Sean Christopherson writes: > > Move KVM PPC's compatibility checks to their respective module_init() > > hooks, there's no need to wait until KVM's common compat check, nor is > > there a need to perform the check on every CPU (provided by common KVM's > > hook), as the compatibility checks operate on global data. > > > > arch/powerpc/include/asm/cputable.h: extern struct cpu_spec *cur_cpu_spec; > > arch/powerpc/kvm/book3s.c: return 0 > > arch/powerpc/kvm/e500.c: strcmp(cur_cpu_spec->cpu_name, "e500v2") > > arch/powerpc/kvm/e500mc.c: strcmp(cur_cpu_spec->cpu_name, "e500mc") > > strcmp(cur_cpu_spec->cpu_name, "e5500") > > strcmp(cur_cpu_spec->cpu_name, "e6500") > > I'm not sure that output is really useful in the change log unless you > explain more about what it is. Agreed, I got lazy. I'll write a proper description. > > diff --git a/arch/powerpc/kvm/e500mc.c b/arch/powerpc/kvm/e500mc.c > > index 57e0ad6a2ca3..795667f7ebf0 100644 > > --- a/arch/powerpc/kvm/e500mc.c > > +++ b/arch/powerpc/kvm/e500mc.c > > @@ -388,6 +388,10 @@ static int __init kvmppc_e500mc_init(void) > > { > > int r; > > > > + r = kvmppc_e500mc_check_processor_compat(); > > + if (r) > > + return kvmppc_e500mc; > > This doesn't build: > > linux/arch/powerpc/kvm/e500mc.c: In function ‘kvmppc_e500mc_init’: > linux/arch/powerpc/kvm/e500mc.c:391:13: error: implicit declaration of function ‘kvmppc_e500mc_check_processor_compat’; did you mean ‘kvmppc_core_check_processor_compat’? [-Werror=implicit-function-declaration] > 391 | r = kvmppc_e500mc_check_processor_compat(); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | kvmppc_core_check_processor_compat > linux/arch/powerpc/kvm/e500mc.c:393:24: error: ‘kvmppc_e500mc’ undeclared (first use in this function); did you mean ‘kvm_ops_e500mc’? > 393 | return kvmppc_e500mc; > | ^~~~~~~~~~~~~ > | kvm_ops_e500mc > linux/arch/powerpc/kvm/e500mc.c:393:24: note: each undeclared identifier is reported only once for each function it appears in Huh, CONFIG_PPC_E500MC got unselected in the config I use to compile test this flavor. I suspect I botched an oldconfig at some point. Anyways, fixed that and the bugs. Thanks much! -- Subject: [PATCH] KVM: PPC: Move processor compatibility check to module init Move KVM PPC's compatibility checks to their respective module_init() hooks, there's no need to wait until KVM's common compat check, nor is there a need to perform the check on every CPU (provided by common KVM's hook). The compatibility checks are either a nop (Book3S), or simply check the CPU name stored in the global CPU spec (e500 and e500mc). Cc: Fabiano Rosas Cc: Michael Ellerman Signed-off-by: Sean Christopherson --- arch/powerpc/include/asm/kvm_ppc.h | 1 - arch/powerpc/kvm/book3s.c | 10 ---------- arch/powerpc/kvm/e500.c | 4 ++-- arch/powerpc/kvm/e500mc.c | 6 +++++- arch/powerpc/kvm/powerpc.c | 2 +- 5 files changed, 8 insertions(+), 15 deletions(-) diff --git a/arch/powerpc/include/asm/kvm_ppc.h b/arch/powerpc/include/asm/kvm_ppc.h index bfacf12784dd..51a1824b0a16 100644 --- a/arch/powerpc/include/asm/kvm_ppc.h +++ b/arch/powerpc/include/asm/kvm_ppc.h @@ -118,7 +118,6 @@ extern int kvmppc_xlate(struct kvm_vcpu *vcpu, ulong eaddr, extern int kvmppc_core_vcpu_create(struct kvm_vcpu *vcpu); extern void kvmppc_core_vcpu_free(struct kvm_vcpu *vcpu); extern int kvmppc_core_vcpu_setup(struct kvm_vcpu *vcpu); -extern int kvmppc_core_check_processor_compat(void); extern int kvmppc_core_vcpu_translate(struct kvm_vcpu *vcpu, struct kvm_translation *tr); diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c index 6d525285dbe8..87283a0e33d8 100644 --- a/arch/powerpc/kvm/book3s.c +++ b/arch/powerpc/kvm/book3s.c @@ -999,16 +999,6 @@ int kvmppc_h_logical_ci_store(struct kvm_vcpu *vcpu) } EXPORT_SYMBOL_GPL(kvmppc_h_logical_ci_store); -int kvmppc_core_check_processor_compat(void) -{ - /* - * We always return 0 for book3s. We check - * for compatibility while loading the HV - * or PR module - */ - return 0; -} - int kvmppc_book3s_hcall_implemented(struct kvm *kvm, unsigned long hcall) { return kvm->arch.kvm_ops->hcall_implemented(hcall); diff --git a/arch/powerpc/kvm/e500.c b/arch/powerpc/kvm/e500.c index c8b2b4478545..0ea61190ec04 100644 --- a/arch/powerpc/kvm/e500.c +++ b/arch/powerpc/kvm/e500.c @@ -314,7 +314,7 @@ static void kvmppc_core_vcpu_put_e500(struct kvm_vcpu *vcpu) kvmppc_booke_vcpu_put(vcpu); } -int kvmppc_core_check_processor_compat(void) +static int kvmppc_e500_check_processor_compat(void) { int r; @@ -507,7 +507,7 @@ static int __init kvmppc_e500_init(void) unsigned long handler_len; unsigned long max_ivor = 0; - r = kvmppc_core_check_processor_compat(); + r = kvmppc_e500_check_processor_compat(); if (r) goto err_out; diff --git a/arch/powerpc/kvm/e500mc.c b/arch/powerpc/kvm/e500mc.c index 57e0ad6a2ca3..4564aa27edcf 100644 --- a/arch/powerpc/kvm/e500mc.c +++ b/arch/powerpc/kvm/e500mc.c @@ -168,7 +168,7 @@ static void kvmppc_core_vcpu_put_e500mc(struct kvm_vcpu *vcpu) kvmppc_booke_vcpu_put(vcpu); } -int kvmppc_core_check_processor_compat(void) +int kvmppc_e500mc_check_processor_compat(void) { int r; @@ -388,6 +388,10 @@ static int __init kvmppc_e500mc_init(void) { int r; + r = kvmppc_e500mc_check_processor_compat(); + if (r) + goto err_out; + r = kvmppc_booke_init(); if (r) goto err_out; diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c index 5faf69421f13..d44b85ba8cef 100644 --- a/arch/powerpc/kvm/powerpc.c +++ b/arch/powerpc/kvm/powerpc.c @@ -442,7 +442,7 @@ int kvm_arch_hardware_enable(void) int kvm_arch_check_processor_compat(void *opaque) { - return kvmppc_core_check_processor_compat(); + return 0; } int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) base-commit: 00e4493db7c6163d48d5b45034d1a77e16a1c8dc -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA486C4321E for ; Thu, 1 Dec 2022 16:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wHtKQg11REqzxR9DF4TtLJMnDTqVUpX7DOUzvJBDRcM=; b=r14U68/la5FjB2 JBMmDkDHsf2K23cLOwsCCr7xTWgbzKWTjWd4NfpEhp3/QvCXIxbelNtsBOxK8xta/4qsuU68nQ3YJ mrheOAm2jGHoysj8NLS7dFq3MkkfUuEkDbgJSaXbPhynuCFx+f1HTqG7/s4ITdXt7SmTzyOhz1LQB fSpRQepUwFc3Jbsf3rLUgaTIdLiGFp5jZ+PWDvGxd/Hnbn0XNOzLvQz+tDRGoiJBdReqi1DmhsId8 SzG8VjZYyBijDXXSVgwnCNEwR72dG/pfRGESSJEyYxbAmnXu4qCoou0KtHdXHpVSvT7qkX1+y+XKS Ks1z16kNLYYbf6B9LG5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0ma0-008byJ-O8; Thu, 01 Dec 2022 16:38:32 +0000 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0mZx-008bub-QC for linux-arm-kernel@lists.infradead.org; Thu, 01 Dec 2022 16:38:31 +0000 Received: by mail-pf1-x436.google.com with SMTP id 21so2375764pfw.4 for ; Thu, 01 Dec 2022 08:38:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=wz5UjU3Ma0W7cBTZ/63jSNwcUzSf/RN7ETO0YflOK9Q=; b=L5oONEpJeyYInhCN8kEGfJ8WS2VPlfmSQI0EIRyACnSb62Ho4uiLAZ+22FZ0LpKSBY OanLGdeorUn/O6YHVn5BHqcWoMtKOfzbPKcz+4fsn48JXXYOuwBU81HsoXu4yIA+KxBs oNf69ULLkYXBFawHATlUKtmTRlCCGuue7O3x4Uj20kNa312jwW6CLd6dDy2pzPGk3DaL y4jm5SpqWS/wMH/C2TjT2ihvVuFcoRw2TnuuxPCYPfzDwkDLPEA8hE11/Idhqhxr7xt0 rj/FXhrQIb1ypgd2I2CBp8L/oyRKWO3NUq8Jq7LgrgnoUKAu1/kU3hKmcHIeaOcvmDNO M6Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wz5UjU3Ma0W7cBTZ/63jSNwcUzSf/RN7ETO0YflOK9Q=; b=vQyFDdTuJ0PnHEJTooogiNCVfqro9NWC++Icyhvt9gve43Lp+VjaV1VJ7FrUJWvN/T dkah15pJs+Xu4dyX7rVl/8makthwWKFX/tUwryqRm0GF0RoKppFe5WJcP8iI7A9ohe3R VAJ+WTnCvvFFOLZRn+Qla7ElAlP1aWGcGGBF8gvg4tbCJFU0cJoooBpBxR3hwHYzBGvC u9oub3wjqhPDvlV9S0wNQhbqVTPfYUYotMIUdoxfvUsdNhyvzze7IhB09/R4y0ojAfJL 6Dal6T10NaOxtC6CPbUuJUVpLqA1eFSjx+tzrzGP0/bUR86KNuyMd4RnCRa7gtXxwt4f vdeQ== X-Gm-Message-State: ANoB5plC0W7jYXt2B6TKRskWRCBxohI0UndXRNqRVwpWrPqB2ck2sia2 RIV3eekGB7zP2eKL44DtVcs6/Q== X-Google-Smtp-Source: AA0mqf7E8VTs9g+yA9GqMgTdFbO4YLYoa36a9KLdCj074cztIQB7gniXVzh1et27ldGMC17rtCxmqQ== X-Received: by 2002:aa7:8512:0:b0:575:65ff:8831 with SMTP id v18-20020aa78512000000b0057565ff8831mr16235817pfn.80.1669912703144; Thu, 01 Dec 2022 08:38:23 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id l4-20020a17090a384400b00212c27abcaesm5118172pjf.17.2022.12.01.08.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 08:38:22 -0800 (PST) Date: Thu, 1 Dec 2022 16:38:16 +0000 From: Sean Christopherson To: Michael Ellerman Cc: Paolo Bonzini , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Matthew Rosato , Eric Farman , Vitaly Kuznetsov , David Woodhouse , Paul Durrant , James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , Atish Patra , David Hildenbrand , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Yuan Yao , Cornelia Huck , Isaku Yamahata , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Fabiano Rosas , Kai Huang , Chao Gao , Thomas Gleixner Subject: Re: [PATCH v2 26/50] KVM: PPC: Move processor compatibility check to module init Message-ID: References: <20221130230934.1014142-1-seanjc@google.com> <20221130230934.1014142-27-seanjc@google.com> <87cz93snqc.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87cz93snqc.fsf@mpe.ellerman.id.au> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221201_083829_876800_BD1007C2 X-CRM114-Status: GOOD ( 35.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBEZWMgMDEsIDIwMjIsIE1pY2hhZWwgRWxsZXJtYW4gd3JvdGU6Cj4gU2VhbiBDaHJp c3RvcGhlcnNvbiA8c2VhbmpjQGdvb2dsZS5jb20+IHdyaXRlczoKPiA+IE1vdmUgS1ZNIFBQQydz IGNvbXBhdGliaWxpdHkgY2hlY2tzIHRvIHRoZWlyIHJlc3BlY3RpdmUgbW9kdWxlX2luaXQoKQo+ ID4gaG9va3MsIHRoZXJlJ3Mgbm8gbmVlZCB0byB3YWl0IHVudGlsIEtWTSdzIGNvbW1vbiBjb21w YXQgY2hlY2ssIG5vciBpcwo+ID4gdGhlcmUgYSBuZWVkIHRvIHBlcmZvcm0gdGhlIGNoZWNrIG9u IGV2ZXJ5IENQVSAocHJvdmlkZWQgYnkgY29tbW9uIEtWTSdzCj4gPiBob29rKSwgYXMgdGhlIGNv bXBhdGliaWxpdHkgY2hlY2tzIG9wZXJhdGUgb24gZ2xvYmFsIGRhdGEuCj4gPgo+ID4gICBhcmNo L3Bvd2VycGMvaW5jbHVkZS9hc20vY3B1dGFibGUuaDogZXh0ZXJuIHN0cnVjdCBjcHVfc3BlYyAq Y3VyX2NwdV9zcGVjOwo+ID4gICBhcmNoL3Bvd2VycGMva3ZtL2Jvb2szcy5jOiByZXR1cm4gMAo+ ID4gICBhcmNoL3Bvd2VycGMva3ZtL2U1MDAuYzogc3RyY21wKGN1cl9jcHVfc3BlYy0+Y3B1X25h bWUsICJlNTAwdjIiKQo+ID4gICBhcmNoL3Bvd2VycGMva3ZtL2U1MDBtYy5jOiBzdHJjbXAoY3Vy X2NwdV9zcGVjLT5jcHVfbmFtZSwgImU1MDBtYyIpCj4gPiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHN0cmNtcChjdXJfY3B1X3NwZWMtPmNwdV9uYW1lLCAiZTU1MDAiKQo+ID4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBzdHJjbXAoY3VyX2NwdV9zcGVjLT5jcHVfbmFtZSwgImU2 NTAwIikKPiAKPiBJJ20gbm90IHN1cmUgdGhhdCBvdXRwdXQgaXMgcmVhbGx5IHVzZWZ1bCBpbiB0 aGUgY2hhbmdlIGxvZyB1bmxlc3MgeW91Cj4gZXhwbGFpbiBtb3JlIGFib3V0IHdoYXQgaXQgaXMu CgpBZ3JlZWQsIEkgZ290IGxhenkuICBJJ2xsIHdyaXRlIGEgcHJvcGVyIGRlc2NyaXB0aW9uLgog Cj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMuYyBiL2FyY2gvcG93ZXJw Yy9rdm0vZTUwMG1jLmMKPiA+IGluZGV4IDU3ZTBhZDZhMmNhMy4uNzk1NjY3ZjdlYmYwIDEwMDY0 NAo+ID4gLS0tIGEvYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMuYwo+ID4gKysrIGIvYXJjaC9wb3dl cnBjL2t2bS9lNTAwbWMuYwo+ID4gQEAgLTM4OCw2ICszODgsMTAgQEAgc3RhdGljIGludCBfX2lu aXQga3ZtcHBjX2U1MDBtY19pbml0KHZvaWQpCj4gPiAgewo+ID4gIAlpbnQgcjsKPiA+ICAKPiA+ ICsJciA9IGt2bXBwY19lNTAwbWNfY2hlY2tfcHJvY2Vzc29yX2NvbXBhdCgpOwo+ID4gKwlpZiAo cikKPiA+ICsJCXJldHVybiBrdm1wcGNfZTUwMG1jOwo+ICAKPiBUaGlzIGRvZXNuJ3QgYnVpbGQ6 Cj4gCj4gbGludXgvYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMuYzogSW4gZnVuY3Rpb24g4oCYa3Zt cHBjX2U1MDBtY19pbml04oCZOgo+IGxpbnV4L2FyY2gvcG93ZXJwYy9rdm0vZTUwMG1jLmM6Mzkx OjEzOiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g4oCYa3ZtcHBjX2U1 MDBtY19jaGVja19wcm9jZXNzb3JfY29tcGF04oCZOyBkaWQgeW91IG1lYW4g4oCYa3ZtcHBjX2Nv cmVfY2hlY2tfcHJvY2Vzc29yX2NvbXBhdOKAmT8gWy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rpb24t ZGVjbGFyYXRpb25dCj4gICAzOTEgfCAgICAgICAgIHIgPSBrdm1wcGNfZTUwMG1jX2NoZWNrX3By b2Nlc3Nvcl9jb21wYXQoKTsKPiAgICAgICB8ICAgICAgICAgICAgIF5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fgo+ICAgICAgIHwgICAgICAgICAgICAga3ZtcHBjX2NvcmVfY2hl Y2tfcHJvY2Vzc29yX2NvbXBhdAo+IGxpbnV4L2FyY2gvcG93ZXJwYy9rdm0vZTUwMG1jLmM6Mzkz OjI0OiBlcnJvcjog4oCYa3ZtcHBjX2U1MDBtY+KAmSB1bmRlY2xhcmVkIChmaXJzdCB1c2UgaW4g dGhpcyBmdW5jdGlvbik7IGRpZCB5b3UgbWVhbiDigJhrdm1fb3BzX2U1MDBtY+KAmT8KPiAgIDM5 MyB8ICAgICAgICAgICAgICAgICByZXR1cm4ga3ZtcHBjX2U1MDBtYzsKPiAgICAgICB8ICAgICAg ICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fn5+fgo+ICAgICAgIHwgICAgICAgICAgICAgICAg ICAgICAgICBrdm1fb3BzX2U1MDBtYwo+IGxpbnV4L2FyY2gvcG93ZXJwYy9rdm0vZTUwMG1jLmM6 MzkzOjI0OiBub3RlOiBlYWNoIHVuZGVjbGFyZWQgaWRlbnRpZmllciBpcyByZXBvcnRlZCBvbmx5 IG9uY2UgZm9yIGVhY2ggZnVuY3Rpb24gaXQgYXBwZWFycyBpbgoKSHVoLCBDT05GSUdfUFBDX0U1 MDBNQyBnb3QgdW5zZWxlY3RlZCBpbiB0aGUgY29uZmlnIEkgdXNlIHRvIGNvbXBpbGUgdGVzdCB0 aGlzCmZsYXZvci4gIEkgc3VzcGVjdCBJIGJvdGNoZWQgYW4gb2xkY29uZmlnIGF0IHNvbWUgcG9p bnQuCiAKQW55d2F5cywgZml4ZWQgdGhhdCBhbmQgdGhlIGJ1Z3MuCgpUaGFua3MgbXVjaCEKCi0t ClN1YmplY3Q6IFtQQVRDSF0gS1ZNOiBQUEM6IE1vdmUgcHJvY2Vzc29yIGNvbXBhdGliaWxpdHkg Y2hlY2sgdG8gbW9kdWxlIGluaXQKCk1vdmUgS1ZNIFBQQydzIGNvbXBhdGliaWxpdHkgY2hlY2tz IHRvIHRoZWlyIHJlc3BlY3RpdmUgbW9kdWxlX2luaXQoKQpob29rcywgdGhlcmUncyBubyBuZWVk IHRvIHdhaXQgdW50aWwgS1ZNJ3MgY29tbW9uIGNvbXBhdCBjaGVjaywgbm9yIGlzCnRoZXJlIGEg bmVlZCB0byBwZXJmb3JtIHRoZSBjaGVjayBvbiBldmVyeSBDUFUgKHByb3ZpZGVkIGJ5IGNvbW1v biBLVk0ncwpob29rKS4gIFRoZSBjb21wYXRpYmlsaXR5IGNoZWNrcyBhcmUgZWl0aGVyIGEgbm9w IChCb29rM1MpLCBvciBzaW1wbHkKY2hlY2sgdGhlIENQVSBuYW1lIHN0b3JlZCBpbiB0aGUgZ2xv YmFsIENQVSBzcGVjIChlNTAwIGFuZCBlNTAwbWMpLgoKQ2M6IEZhYmlhbm8gUm9zYXMgPGZhcm9z YXNAbGludXguaWJtLmNvbT4KQ2M6IE1pY2hhZWwgRWxsZXJtYW4gPG1wZUBlbGxlcm1hbi5pZC5h dT4KU2lnbmVkLW9mZi1ieTogU2VhbiBDaHJpc3RvcGhlcnNvbiA8c2VhbmpjQGdvb2dsZS5jb20+ Ci0tLQogYXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNtL2t2bV9wcGMuaCB8ICAxIC0KIGFyY2gvcG93 ZXJwYy9rdm0vYm9vazNzLmMgICAgICAgICAgfCAxMCAtLS0tLS0tLS0tCiBhcmNoL3Bvd2VycGMv a3ZtL2U1MDAuYyAgICAgICAgICAgIHwgIDQgKystLQogYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMu YyAgICAgICAgICB8ICA2ICsrKysrLQogYXJjaC9wb3dlcnBjL2t2bS9wb3dlcnBjLmMgICAgICAg ICB8ICAyICstCiA1IGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNtL2t2bV9wcGMuaCBiL2Fy Y2gvcG93ZXJwYy9pbmNsdWRlL2FzbS9rdm1fcHBjLmgKaW5kZXggYmZhY2YxMjc4NGRkLi41MWEx ODI0YjBhMTYgMTAwNjQ0Ci0tLSBhL2FyY2gvcG93ZXJwYy9pbmNsdWRlL2FzbS9rdm1fcHBjLmgK KysrIGIvYXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNtL2t2bV9wcGMuaApAQCAtMTE4LDcgKzExOCw2 IEBAIGV4dGVybiBpbnQga3ZtcHBjX3hsYXRlKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwgdWxvbmcg ZWFkZHIsCiBleHRlcm4gaW50IGt2bXBwY19jb3JlX3ZjcHVfY3JlYXRlKHN0cnVjdCBrdm1fdmNw dSAqdmNwdSk7CiBleHRlcm4gdm9pZCBrdm1wcGNfY29yZV92Y3B1X2ZyZWUoc3RydWN0IGt2bV92 Y3B1ICp2Y3B1KTsKIGV4dGVybiBpbnQga3ZtcHBjX2NvcmVfdmNwdV9zZXR1cChzdHJ1Y3Qga3Zt X3ZjcHUgKnZjcHUpOwotZXh0ZXJuIGludCBrdm1wcGNfY29yZV9jaGVja19wcm9jZXNzb3JfY29t cGF0KHZvaWQpOwogZXh0ZXJuIGludCBrdm1wcGNfY29yZV92Y3B1X3RyYW5zbGF0ZShzdHJ1Y3Qg a3ZtX3ZjcHUgKnZjcHUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0 cnVjdCBrdm1fdHJhbnNsYXRpb24gKnRyKTsKIApkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL2t2 bS9ib29rM3MuYyBiL2FyY2gvcG93ZXJwYy9rdm0vYm9vazNzLmMKaW5kZXggNmQ1MjUyODVkYmU4 Li44NzI4M2EwZTMzZDggMTAwNjQ0Ci0tLSBhL2FyY2gvcG93ZXJwYy9rdm0vYm9vazNzLmMKKysr IGIvYXJjaC9wb3dlcnBjL2t2bS9ib29rM3MuYwpAQCAtOTk5LDE2ICs5OTksNiBAQCBpbnQga3Zt cHBjX2hfbG9naWNhbF9jaV9zdG9yZShzdHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUpCiB9CiBFWFBPUlRf U1lNQk9MX0dQTChrdm1wcGNfaF9sb2dpY2FsX2NpX3N0b3JlKTsKIAotaW50IGt2bXBwY19jb3Jl X2NoZWNrX3Byb2Nlc3Nvcl9jb21wYXQodm9pZCkKLXsKLQkvKgotCSAqIFdlIGFsd2F5cyByZXR1 cm4gMCBmb3IgYm9vazNzLiBXZSBjaGVjawotCSAqIGZvciBjb21wYXRpYmlsaXR5IHdoaWxlIGxv YWRpbmcgdGhlIEhWCi0JICogb3IgUFIgbW9kdWxlCi0JICovCi0JcmV0dXJuIDA7Ci19Ci0KIGlu dCBrdm1wcGNfYm9vazNzX2hjYWxsX2ltcGxlbWVudGVkKHN0cnVjdCBrdm0gKmt2bSwgdW5zaWdu ZWQgbG9uZyBoY2FsbCkKIHsKIAlyZXR1cm4ga3ZtLT5hcmNoLmt2bV9vcHMtPmhjYWxsX2ltcGxl bWVudGVkKGhjYWxsKTsKZGlmZiAtLWdpdCBhL2FyY2gvcG93ZXJwYy9rdm0vZTUwMC5jIGIvYXJj aC9wb3dlcnBjL2t2bS9lNTAwLmMKaW5kZXggYzhiMmI0NDc4NTQ1Li4wZWE2MTE5MGVjMDQgMTAw NjQ0Ci0tLSBhL2FyY2gvcG93ZXJwYy9rdm0vZTUwMC5jCisrKyBiL2FyY2gvcG93ZXJwYy9rdm0v ZTUwMC5jCkBAIC0zMTQsNyArMzE0LDcgQEAgc3RhdGljIHZvaWQga3ZtcHBjX2NvcmVfdmNwdV9w dXRfZTUwMChzdHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUpCiAJa3ZtcHBjX2Jvb2tlX3ZjcHVfcHV0KHZj cHUpOwogfQogCi1pbnQga3ZtcHBjX2NvcmVfY2hlY2tfcHJvY2Vzc29yX2NvbXBhdCh2b2lkKQor c3RhdGljIGludCBrdm1wcGNfZTUwMF9jaGVja19wcm9jZXNzb3JfY29tcGF0KHZvaWQpCiB7CiAJ aW50IHI7CiAKQEAgLTUwNyw3ICs1MDcsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBrdm1wcGNfZTUw MF9pbml0KHZvaWQpCiAJdW5zaWduZWQgbG9uZyBoYW5kbGVyX2xlbjsKIAl1bnNpZ25lZCBsb25n IG1heF9pdm9yID0gMDsKIAotCXIgPSBrdm1wcGNfY29yZV9jaGVja19wcm9jZXNzb3JfY29tcGF0 KCk7CisJciA9IGt2bXBwY19lNTAwX2NoZWNrX3Byb2Nlc3Nvcl9jb21wYXQoKTsKIAlpZiAocikK IAkJZ290byBlcnJfb3V0OwogCmRpZmYgLS1naXQgYS9hcmNoL3Bvd2VycGMva3ZtL2U1MDBtYy5j IGIvYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMuYwppbmRleCA1N2UwYWQ2YTJjYTMuLjQ1NjRhYTI3 ZWRjZiAxMDA2NDQKLS0tIGEvYXJjaC9wb3dlcnBjL2t2bS9lNTAwbWMuYworKysgYi9hcmNoL3Bv d2VycGMva3ZtL2U1MDBtYy5jCkBAIC0xNjgsNyArMTY4LDcgQEAgc3RhdGljIHZvaWQga3ZtcHBj X2NvcmVfdmNwdV9wdXRfZTUwMG1jKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSkKIAlrdm1wcGNfYm9v a2VfdmNwdV9wdXQodmNwdSk7CiB9CiAKLWludCBrdm1wcGNfY29yZV9jaGVja19wcm9jZXNzb3Jf Y29tcGF0KHZvaWQpCitpbnQga3ZtcHBjX2U1MDBtY19jaGVja19wcm9jZXNzb3JfY29tcGF0KHZv aWQpCiB7CiAJaW50IHI7CiAKQEAgLTM4OCw2ICszODgsMTAgQEAgc3RhdGljIGludCBfX2luaXQg a3ZtcHBjX2U1MDBtY19pbml0KHZvaWQpCiB7CiAJaW50IHI7CiAKKwlyID0ga3ZtcHBjX2U1MDBt Y19jaGVja19wcm9jZXNzb3JfY29tcGF0KCk7CisJaWYgKHIpCisJCWdvdG8gZXJyX291dDsKKwog CXIgPSBrdm1wcGNfYm9va2VfaW5pdCgpOwogCWlmIChyKQogCQlnb3RvIGVycl9vdXQ7CmRpZmYg LS1naXQgYS9hcmNoL3Bvd2VycGMva3ZtL3Bvd2VycGMuYyBiL2FyY2gvcG93ZXJwYy9rdm0vcG93 ZXJwYy5jCmluZGV4IDVmYWY2OTQyMWYxMy4uZDQ0Yjg1YmE4Y2VmIDEwMDY0NAotLS0gYS9hcmNo L3Bvd2VycGMva3ZtL3Bvd2VycGMuYworKysgYi9hcmNoL3Bvd2VycGMva3ZtL3Bvd2VycGMuYwpA QCAtNDQyLDcgKzQ0Miw3IEBAIGludCBrdm1fYXJjaF9oYXJkd2FyZV9lbmFibGUodm9pZCkKIAog aW50IGt2bV9hcmNoX2NoZWNrX3Byb2Nlc3Nvcl9jb21wYXQodm9pZCAqb3BhcXVlKQogewotCXJl dHVybiBrdm1wcGNfY29yZV9jaGVja19wcm9jZXNzb3JfY29tcGF0KCk7CisJcmV0dXJuIDA7CiB9 CiAKIGludCBrdm1fYXJjaF9pbml0X3ZtKHN0cnVjdCBrdm0gKmt2bSwgdW5zaWduZWQgbG9uZyB0 eXBlKQoKYmFzZS1jb21taXQ6IDAwZTQ0OTNkYjdjNjE2M2Q0OGQ1YjQ1MDM0ZDFhNzdlMTZhMWM4 ZGMKLS0gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo=