From: Andrew Lunn <andrew@lunn.ch>
To: Conor Dooley <conor@kernel.org>
Cc: Yanhong Wang <yanhong.wang@starfivetech.com>,
linux-riscv@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Richard Cochran <richardcochran@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH v1 7/7] riscv: dts: starfive: visionfive-v2: Add phy delay_chain configuration
Date: Thu, 1 Dec 2022 20:42:30 +0100 [thread overview]
Message-ID: <Y4kDppmVnL3BV44Z@lunn.ch> (raw)
In-Reply-To: <Y4kAyAhBseNmmDo8@spud>
On Thu, Dec 01, 2022 at 07:30:16PM +0000, Conor Dooley wrote:
> On Thu, Dec 01, 2022 at 05:49:08PM +0000, Conor Dooley wrote:
> > On Thu, Dec 01, 2022 at 05:02:42PM +0800, Yanhong Wang wrote:
> > > riscv: dts: starfive: visionfive-v2: Add phy delay_chain configuration
> > >
> > > Add phy delay_chain configuration to support motorcomm phy driver for
> > > StarFive VisionFive 2 board.
>
> nit: please re-word this commit next time around to actually say what
> you're doing here. I didn't notice it initially, but this patch is doing
> a lot more than adding `delay_chain` configuration. To my dwmac unaware
> brain, there's nothing hits for that term outside of the changelog :(
Hi Conor
I suspect once we see the documentation of the binding, it will get
rejected and implemented differently. So i would not worry too much
about this at the moment.
Andrew
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Conor Dooley <conor@kernel.org>
Cc: Yanhong Wang <yanhong.wang@starfivetech.com>,
linux-riscv@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Richard Cochran <richardcochran@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH v1 7/7] riscv: dts: starfive: visionfive-v2: Add phy delay_chain configuration
Date: Thu, 1 Dec 2022 20:42:30 +0100 [thread overview]
Message-ID: <Y4kDppmVnL3BV44Z@lunn.ch> (raw)
In-Reply-To: <Y4kAyAhBseNmmDo8@spud>
On Thu, Dec 01, 2022 at 07:30:16PM +0000, Conor Dooley wrote:
> On Thu, Dec 01, 2022 at 05:49:08PM +0000, Conor Dooley wrote:
> > On Thu, Dec 01, 2022 at 05:02:42PM +0800, Yanhong Wang wrote:
> > > riscv: dts: starfive: visionfive-v2: Add phy delay_chain configuration
> > >
> > > Add phy delay_chain configuration to support motorcomm phy driver for
> > > StarFive VisionFive 2 board.
>
> nit: please re-word this commit next time around to actually say what
> you're doing here. I didn't notice it initially, but this patch is doing
> a lot more than adding `delay_chain` configuration. To my dwmac unaware
> brain, there's nothing hits for that term outside of the changelog :(
Hi Conor
I suspect once we see the documentation of the binding, it will get
rejected and implemented differently. So i would not worry too much
about this at the moment.
Andrew
next prev parent reply other threads:[~2022-12-01 19:46 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 9:02 [PATCH v1 0/7] Add Ethernet driver for StarFive JH7110 SoC Yanhong Wang
2022-12-01 9:02 ` Yanhong Wang
2022-12-01 9:02 ` [PATCH v1 1/7] dt-bindings: net: snps,dwmac: Add compatible string for dwmac-5.20 version Yanhong Wang
2022-12-01 9:02 ` Yanhong Wang
2022-12-01 16:18 ` Krzysztof Kozlowski
2022-12-01 16:18 ` Krzysztof Kozlowski
2022-12-02 2:53 ` yanhong wang
2022-12-02 2:53 ` yanhong wang
2022-12-02 8:01 ` Krzysztof Kozlowski
2022-12-02 8:01 ` Krzysztof Kozlowski
2022-12-07 13:56 ` Emil Renner Berthing
2022-12-07 13:56 ` Emil Renner Berthing
2022-12-08 1:34 ` yanhong wang
2022-12-08 1:34 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 2/7] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Yanhong Wang
2022-12-01 9:02 ` Yanhong Wang
2022-12-07 13:58 ` Emil Renner Berthing
2022-12-07 13:58 ` Emil Renner Berthing
2022-12-08 1:42 ` yanhong wang
2022-12-08 1:42 ` yanhong wang
2022-12-09 1:59 ` Ben Dooks
2022-12-09 1:59 ` Ben Dooks
2022-12-09 2:26 ` yanhong wang
2022-12-09 2:26 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 3/7] dt-bindings: net: Add bindings for StarFive dwmac Yanhong Wang
2022-12-01 9:02 ` Yanhong Wang
2022-12-01 13:36 ` Rob Herring
2022-12-01 13:36 ` Rob Herring
2022-12-01 16:45 ` Conor Dooley
2022-12-01 16:45 ` Conor Dooley
2022-12-02 10:52 ` Krzysztof Kozlowski
2022-12-02 10:52 ` Krzysztof Kozlowski
2022-12-01 16:21 ` Krzysztof Kozlowski
2022-12-01 16:21 ` Krzysztof Kozlowski
2022-12-01 17:35 ` Conor Dooley
2022-12-01 17:35 ` Conor Dooley
2022-12-01 19:32 ` Rob Herring
2022-12-01 19:32 ` Rob Herring
2022-12-02 7:16 ` yanhong wang
2022-12-02 7:16 ` yanhong wang
2022-12-02 8:02 ` Krzysztof Kozlowski
2022-12-02 8:02 ` Krzysztof Kozlowski
2022-12-02 7:07 ` yanhong wang
2022-12-02 7:07 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 4/7] net: phy: motorcomm: Add YT8531 phy support Yanhong Wang
2022-12-01 9:02 ` Yanhong Wang
2022-12-01 15:40 ` Andrew Lunn
2022-12-01 15:40 ` Andrew Lunn
2022-12-06 7:39 ` yanhong wang
2022-12-06 7:39 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 5/7] net: stmmac: Add StarFive dwmac supoort Yanhong Wang
2022-12-01 9:02 ` Yanhong Wang
2022-12-07 14:16 ` Emil Renner Berthing
2022-12-07 14:16 ` Emil Renner Berthing
2022-12-08 2:22 ` yanhong wang
2022-12-08 2:22 ` yanhong wang
2022-12-09 2:03 ` yanhong wang
2022-12-09 2:03 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 6/7] riscv: dts: starfive: jh7110: Add ethernet device node Yanhong Wang
2022-12-01 9:02 ` Yanhong Wang
2022-12-01 17:45 ` Conor Dooley
2022-12-01 17:45 ` Conor Dooley
2022-12-02 5:53 ` yanhong wang
2022-12-02 5:53 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 7/7] riscv: dts: starfive: visionfive-v2: Add phy delay_chain configuration Yanhong Wang
2022-12-01 9:02 ` Yanhong Wang
2022-12-01 17:49 ` Conor Dooley
2022-12-01 17:49 ` Conor Dooley
2022-12-01 19:30 ` Conor Dooley
2022-12-01 19:30 ` Conor Dooley
2022-12-01 19:42 ` Andrew Lunn [this message]
2022-12-01 19:42 ` Andrew Lunn
2022-12-09 1:28 ` yanhong wang
2022-12-09 1:28 ` yanhong wang
2022-12-09 1:19 ` yanhong wang
2022-12-09 1:19 ` yanhong wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4kDppmVnL3BV44Z@lunn.ch \
--to=andrew@lunn.ch \
--cc=conor@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yanhong.wang@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.