From: Brian Masney <bmasney@redhat.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: krzysztof.kozlowski+dt@linaro.org, agross@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_shazhuss@quicinc.com,
psodagud@quicinc.com, ahalaney@redhat.com, echanude@redhat.com
Subject: Re: [PATCH v2] arm64: dts: qcom: sa8540p-ride: enable PCIe support
Date: Thu, 1 Dec 2022 17:35:05 -0500 [thread overview]
Message-ID: <Y4ksGdtQAqQQ9Shb@x1> (raw)
In-Reply-To: <20221201223012.r6mvz4updf3qoilj@builder.lan>
On Thu, Dec 01, 2022 at 04:30:12PM -0600, Bjorn Andersson wrote:
> On Thu, Dec 01, 2022 at 12:19:31PM -0500, Brian Masney wrote:
> > + vreg_l11a: ldo11 {
> > + regulator-name = "vreg_l11a";
> > + regulator-min-microvolt = <880000>;
> > + regulator-max-microvolt = <880000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> > + regulator-allow-set-load;
>
> In order to specify regulator-allow-set-load you also need
> regulator-allowed-modes.
>
> But if I read the implementation correction, we don't actually alter the
> load, so perhaps best to just omit this for now?
I can drop regulator-allow-set-load in v3. I almost left it off and
verified the other day that PCIe still works without it.
Brian
prev parent reply other threads:[~2022-12-01 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 17:19 [PATCH v2] arm64: dts: qcom: sa8540p-ride: enable PCIe support Brian Masney
2022-12-01 22:30 ` Bjorn Andersson
2022-12-01 22:35 ` Brian Masney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4ksGdtQAqQQ9Shb@x1 \
--to=bmasney@redhat.com \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=echanude@redhat.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=psodagud@quicinc.com \
--cc=quic_shazhuss@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.