Re: [PATCH 00/10] Move group specific code into group.c

[Jason Gunthorpe <jgg@nvidia.com>]

On Fri, Dec 02, 2022 at 09:57:45PM +0800, Yi Liu wrote:
> On 2022/12/2 04:39, Jason Gunthorpe wrote:
> > On Thu, Dec 01, 2022 at 06:55:25AM -0800, Yi Liu wrote:
> > > With the introduction of iommufd[1], VFIO is towarding to provide device
> > > centric uAPI after adapting to iommufd. With this trend, existing VFIO
> > > group infrastructure is optional once VFIO converted to device centric.
> > > 
> > > This series moves the group specific code out of vfio_main.c, prepares
> > > for compiling group infrastructure out after adding vfio device cdev[2]
> > > 
> > > Complete code in below branch:
> > > 
> > > https://github.com/yiliu1765/iommufd/commits/vfio_group_split_v1
> > > 
> > > This is based on Jason's "Connect VFIO to IOMMUFD"[3] and my "Make mdev driver
> > > dma_unmap callback tolerant to unmaps come before device open"[4]
> > > 
> > > [1] https://lore.kernel.org/all/0-v5-4001c2997bd0+30c-iommufd_jgg@nvidia.com/
> > > [2] https://github.com/yiliu1765/iommufd/tree/wip/vfio_device_cdev
> > > [3] https://lore.kernel.org/kvm/0-v4-42cd2eb0e3eb+335a-vfio_iommufd_jgg@nvidia.com/
> > > [4] https://lore.kernel.org/kvm/20221129105831.466954-1-yi.l.liu@intel.com/
> > 
> > This looks good to me, and it applies OK to my branch here:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/jgg/iommufd.git/
> > 
> > Alex, if you ack this in the next few days I can include it in the
> > iommufd PR, otherwise it can go into the vfio tree in January
> > 
> > Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> > 
> 
> thanks. btw. I've updated my github to incorporate Kevin's nit and also
> r-b from you and Kevin.

Please rebase it on the above branch also

Thanks,
Jason