Re: [PATCH v4 1/5] vfio/migration: Add debugfs to live migration driver

[Jason Gunthorpe <jgg@nvidia.com>]

On Fri, Dec 02, 2022 at 05:26:21PM +0800, Longfang Liu wrote:

> +static ssize_t vfio_pci_vf_state_read(struct file *filp, char __user *buffer,
> +			   size_t count, loff_t *pos)
> +{

This would be better to use debugfs_create_devm_seqfile()

Then you can simply use seq_printf()

> @@ -119,6 +129,8 @@ struct vfio_migration_ops {
>  				   enum vfio_device_mig_state *curr_state);
>  	int (*migration_get_data_size)(struct vfio_device *device,
>  				       unsigned long *stop_copy_length);
> +	int (*migration_get_data)(struct vfio_device *device, char *buffer);
> +	int (*migration_get_attr)(struct vfio_device *device, char
>  				   *buffer);

Still no to passing through debugfs ops, create these files in the
driver.

Jason