All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jisheng Zhang <jszhang@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
	joey.gouly@arm.com, will@kernel.org
Subject: Re: [PATCH] arm64: alternatives: make apply_alternatives_vdso() static
Date: Sat, 3 Dec 2022 00:12:35 +0800	[thread overview]
Message-ID: <Y4oj88D66/orL56Z@xhacker> (raw)
In-Reply-To: <20221117131650.4056636-1-mark.rutland@arm.com>

On Thu, Nov 17, 2022 at 01:16:50PM +0000, Mark Rutland wrote:
> We define and use apply_alternatives_vdso() within alternative.c, and
> don't provide a prototype in a header. There's no need for it to be
> visible outside of alternative.c, so mark it as static.
> 
> There should be no functional change as a result of this patch.
> 
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Joey Gouly <joey.gouly@arm.com>
> Cc: Will Deacon <will@kernel.org>
> ---
>  arch/arm64/kernel/alternative.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/alternative.c b/arch/arm64/kernel/alternative.c
> index 91263d09ea65..0f5eaa4c3a39 100644
> --- a/arch/arm64/kernel/alternative.c
> +++ b/arch/arm64/kernel/alternative.c
> @@ -196,7 +196,7 @@ static void __apply_alternatives(const struct alt_region *region,
>  	}
>  }
>  
> -void apply_alternatives_vdso(void)
> +static void apply_alternatives_vdso(void)

I found this function can be marked as __init as well.

Thanks
>  {
>  	struct alt_region region;
>  	const struct elf64_hdr *hdr;
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply	other threads:[~2022-12-02 16:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 13:16 [PATCH] arm64: alternatives: make apply_alternatives_vdso() static Mark Rutland
2022-11-18 19:40 ` Will Deacon
2022-12-02 16:12 ` Jisheng Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4oj88D66/orL56Z@xhacker \
    --to=jszhang@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=joey.gouly@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.