From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH] blkdev: make struct block_device_operations.devnode() take a const *
Date: Fri, 2 Dec 2022 19:28:09 +0100 [thread overview]
Message-ID: <Y4pDuSd2wkCyarCf@kroah.com> (raw)
In-Reply-To: <Y3NYI04dFGgtQke9@infradead.org>
On Tue, Nov 15, 2022 at 01:13:07AM -0800, Christoph Hellwig wrote:
> On Wed, Nov 09, 2022 at 03:48:43PM +0100, Greg Kroah-Hartman wrote:
> > The devnode() callback in struct block_device_operations should not be
> > modifying the device that is passed into it, so mark it as a const * and
> > propagate the function signature changes out into the one subsystem that
> > actually uses this callback.
>
> Yes. In fact it really shouldn't exist at all. I wonder if we can
> do another attempt at dropping pktcdvd?
>
Patch removing it now sent.
prev parent reply other threads:[~2022-12-02 18:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 14:48 [PATCH] blkdev: make struct block_device_operations.devnode() take a const * Greg Kroah-Hartman
2022-11-09 19:41 ` Jens Axboe
2022-11-10 17:23 ` Greg Kroah-Hartman
2022-11-15 9:13 ` Christoph Hellwig
2022-11-15 10:30 ` Greg Kroah-Hartman
2022-12-02 18:28 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4pDuSd2wkCyarCf@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.