From: Dan Carpenter <error27@gmail.com>
To: Joe Peterson <jwp.linux@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: board: Remove control flow from macro
Date: Sat, 3 Dec 2022 11:37:14 +0300 [thread overview]
Message-ID: <Y4sKulRutmI+ESrB@kadam> (raw)
In-Reply-To: <20221203030544.11543-1-jwp.linux@gmail.com>
On Fri, Dec 02, 2022 at 09:05:44PM -0600, Joe Peterson wrote:
> Adhere to Linux coding style
>
> Reported by checkpatch:
>
> WARNING: Macros with flow control statements should be avoided
>
> There is only one return value possible. Remove the checkpatch warning
> without effecting functionality.
>
> Signed-off-by: Joe Peterson <jwp.linux@gmail.com>
> ---
Does this break the build?
Anyway, checkpatch is wrong here. Just ignore checkpatch if it says
silly stuff.
regards,
dan carpenter
next prev parent reply other threads:[~2022-12-03 8:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 3:05 [PATCH] staging: board: Remove control flow from macro Joe Peterson
2022-12-03 8:37 ` Dan Carpenter [this message]
2022-12-03 10:46 ` kernel test robot
2022-12-05 8:52 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4sKulRutmI+ESrB@kadam \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jwp.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.